From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 34CF41BEC7 for ; Wed, 27 Jun 2018 11:57:54 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id v16-v6so5093389wmv.5 for ; Wed, 27 Jun 2018 02:57:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=yh1ukaDlFn8D7GFaJ2q9bE1+uHIp2Sf0Jy2n+NcnXF8=; b=s3YI08uQ5mjQC+jXgCnCITzrj+I4e7wameZdyTdA/VEjbpD9XpkyUY8FEf10jDZA0y 3uUbSceodnQeSy5MXYtFdFjCWm3rsoEKiUaotIbbpy45s98S2FXvtlqHqkPc3cPLKbpo 3j47vlGJkgyHGODI0oQpn9+X9nVhVi0B/EuFqVP7vNDNNOqVx+OprSNok5I9f9IdznvA 7hlPlPA7YahPy9xFGQ/enVFdLMHADYTuQs40xTnYk+cgbFfq+NNGC/Zo7tiSiBeb2DJ/ vdFaz09Y38t3aL0r5m65fF7sZUS091aeO04zubqiEzUe4xtaxGl6GqixwCJVsQVmP7bm c8OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=yh1ukaDlFn8D7GFaJ2q9bE1+uHIp2Sf0Jy2n+NcnXF8=; b=UHlunW6ChSrZFZ3F6hypTIqOplA5aSh4w1D/a05Yh1B4SaxGr7YFETe2ifuhhgByZ8 ujrdK5KsyxbNRjREZVs3MO4k7tdympaVbNPliUji6XLM9APHvGSTdcS8WeUTUU2X8wxC aTaHZNqKY6EgDaviy9pailM3jvVu2uGeAs4iD6Av6aS2MlliBEgd0C8leoEzdmopAcGQ DgFS55VXaVAsdHbr0chXXBD/sPRfBFKIFxoosztKtLmH9hySPqMtpg0DuP7SVfOh/9G4 sk5V89wo2O5Uki+BvE/8ELYK/CdF0UM+4mYm49BBf4HPthhWeOqY/suVvph/ie1cDoHd c/cw== X-Gm-Message-State: APt69E34lyfx3LjLVq0JZZARvQQ+jW4FksUYGnfJ9ruqBagHoITdHig3 yrjzjr5AtuDepm9jfp3RN7j2aw== X-Google-Smtp-Source: AAOMgpc6AlMWtG+DL5YmKorh4hNDzuU0D2gwxOZbhKjJVWKy27j8JdCSztSlDxbX3C8AMdsuDt9L9w== X-Received: by 2002:a1c:338c:: with SMTP id z134-v6mr4526898wmz.93.1530093473794; Wed, 27 Jun 2018 02:57:53 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id v65-v6sm5030370wme.26.2018.06.27.02.57.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Jun 2018 02:57:52 -0700 (PDT) Date: Wed, 27 Jun 2018 11:57:36 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Pavan Nikhilesh Cc: Shahaf Shuler , "jerin.jacob@caviumnetworks.com" , Thomas Monjalon , Ferruh Yigit , dev@dpdk.org Message-ID: <20180627095736.jty7lbqesxufwiby@bidouze.vm.6wind.com> References: <20180615044359.20692-1-pbhagavatula@caviumnetworks.com> <20180627083959.cqyq2bwwuz3z7vof@bidouze.vm.6wind.com> <20180627085529.GA14236@ltp-pvn> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180627085529.GA14236@ltp-pvn> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 09:57:54 -0000 On Wed, Jun 27, 2018 at 02:25:30PM +0530, Pavan Nikhilesh wrote: > Hi Gaëtan, > > On Wed, Jun 27, 2018 at 10:39:59AM +0200, Gaëtan Rivet wrote: > > Hi Ferruh, Pavan, > > > > sorry for the delay, > > > > On Tue, Jun 26, 2018 at 04:40:21PM +0100, Ferruh Yigit wrote: > > > On 6/26/2018 1:48 PM, Shahaf Shuler wrote: > > > > Hi Pavan, > > > > > > > > Friday, June 15, 2018 7:44 AM, Pavan Nikhilesh: > > > >> Subject: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev > > > >> args > > > >> > > > >> Currently, the only way of supplying device argument to a pci device is to > > > >> whitelist it i.e. -w 000X:00:0X.0,self_test=1. This is not a very feasible method > > > >> as whitelisting a device has its own side effects i.e only the whitelisted pci > > > >> devices are probed. > > > >> > > > >> Add a new eal command line option --pci-args to pass device args without the > > > >> need to whitelist the devices. > > > >> --pci-args 000X:00:0X.0,self_test=1 > > > >> > > > >> Signed-off-by: Pavan Nikhilesh > > > > > > > > Tested-by: Shahaf Shuler > > > > > > > > It seems to work. > > > > Please see small comments below > > > > > > Isn't this conflict with Gaetan's devarg work which has wider scope? > > > > > > > Indeed it does. > > > > Pavan, I have submitted a new version of a series adding generic kvargs > > to several layers (bus, class, driver). > > > > It does cover this exact use-case. > > > > However, while writing it, I wasn't able to find PCI bus specific > > parameters, that could showcase the functionality. > > The idea of the patch is to avoid whitelising a device when we want to > supply kvargs to it, I tried mapping it to devargs rework patchset but couldn't > do it at a glance. For example, the following patch[1] reads kvargs through > whitelisting which should be avoided. > > [1]http://patches.dpdk.org/patch/41223/ > I see. Actually, your use-case won't be covered by the devargs rework. I am still dumbfounded by how this blacklist/whitelist mode stuff is kept against all odds. But that's not the time to deal with it. The issue is that the two features "declaring a device" and "configuring a bus" are currently awkwardly merged. You are piling stuff on the "declaring a device" part to enhance the "configuring a bus" feature. Instead of going this way, I would advise to separate the two features. If buses could be configured with a generic EAL option "--blacklist=pci,vdev" for example, then you could provide devargs as much as you want, the buses themselves would stay properly configured. This means removing devargs policy, device types and rewriting bus logic about it. Regards, -- Gaëtan Rivet 6WIND