From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <adrien.mazarguil@6wind.com>
Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com
[209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 340661BB72
for <dev@dpdk.org>; Wed, 27 Jun 2018 15:32:20 +0200 (CEST)
Received: by mail-wr0-f195.google.com with SMTP id e18-v6so2079320wrs.5
for <dev@dpdk.org>; Wed, 27 Jun 2018 06:32:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:in-reply-to;
bh=qz/DKwHAB9oSn4DUlfSqnnPAVkmp3t2zCXHhc/uWORQ=;
b=GZ2QAD2iJWzHO+0Uqv06fe9ttBQSRN8fSM68sc8q0pvvfBVB59Q+OhA0NjbTwcuypx
XStmNGg7U1TsVWXvVfExXn9MGUvhTIjkTcNsPBZTo1OZUfmQ2XjFv5vzVntaB3+lsKpL
C9poLlXKi4dn8gFAm4weegbGIfA5K5ja7iPJQVGO7r38hsJNgvpvC9G1K1CR89bkdC6x
TLR85bsz2tydtyVv1IPQ+iHCnRIwVoCV+HHYy/Fy5/naICGeR13jlQYnkHWL1Z73XC4u
HkO53CWaK8090BErROtZZNlT3f8JQH2jfIAkNl7gK4zSry9v/XH8a4tNT/JnAJ8C8slG
Z/TA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:in-reply-to;
bh=qz/DKwHAB9oSn4DUlfSqnnPAVkmp3t2zCXHhc/uWORQ=;
b=iKO039weX9somTa7mi6Np3P8XR69PCsQRM3fm1VsMZIIeoXpff76fEuZuz7Nfpqc5A
u4iPS1nXBSYcelDh2ZgzP6egtrgr4urnTYoJRWrMmHCo+y+LUMHTfQtDagDZBqLhvVr2
nHauThpPcRowqZlzSdXEazoW3qvzatjVQQ//vts6gjpqrqgMH795LLmLNESS1Vb6gt6b
FuubTnc/fiXMx7sFW6bcOPrTVg5j10qHdYhZqMNiHGu2L8JhGpmQmBsFHIkGXw7pn6JQ
wRADnlG+lIe0jE6vH98wWL/sDdaSmcpp5DF+wb2cVwykRL4pG/BaaHKsH/4aa19wPOBP
e4Dg==
X-Gm-Message-State: APt69E06/xGYzxv76AKBYZjyDgiJu1n0BpjF1xP6dHbJXiVEac9ZzX9+
udKTXSFNCZR75R42a+ehufDbgETL
X-Google-Smtp-Source: AAOMgpdew3e1xl091GTQ2hK6LHnkfyvRkixpcIE8CsvdpI7G2WGsDvGGU68k199i1GtFbf1Spzqm3Q==
X-Received: by 2002:adf:aec7:: with SMTP id
y65-v6mr5170594wrc.140.1530106339981;
Wed, 27 Jun 2018 06:32:19 -0700 (PDT)
Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])
by smtp.gmail.com with ESMTPSA id h18-v6sm6887985wrq.36.2018.06.27.06.32.18
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Wed, 27 Jun 2018 06:32:19 -0700 (PDT)
Date: Wed, 27 Jun 2018 15:32:03 +0200
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: "Xueming(Steven) Li" <xuemingl@mellanox.com>
Cc: Shahaf Shuler <shahafs@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20180627133202.GT4025@6wind.com>
References: <20180525161814.13873-1-adrien.mazarguil@6wind.com>
<20180614083047.10812-1-adrien.mazarguil@6wind.com>
<20180614083047.10812-6-adrien.mazarguil@6wind.com>
<AM5PR0501MB24206A03C4D206AF8DACF521AC730@AM5PR0501MB2420.eurprd05.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AM5PR0501MB24206A03C4D206AF8DACF521AC730@AM5PR0501MB2420.eurprd05.prod.outlook.com>
Subject: Re: [dpdk-dev] [PATCH v2 5/7] net/mlx5: add port representor
awareness
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Jun 2018 13:32:20 -0000
On Sat, Jun 16, 2018 at 08:37:14AM +0000, Xueming(Steven) Li wrote:
> Reviewed-by: Xueming Li <xuemingl@mellanox.com>
>
> One minor issue we should be able to ignore.
<snip>
> > +static int
> > +mlx5_cmp_ibv_name(const void *a, const void *b) {
> > + const char *name_a = (*(const struct ibv_device *const *)a)->name;
> > + const char *name_b = (*(const struct ibv_device *const *)b)->name;
> > + size_t i = 0;
> > +
> > + while (name_a[i] && name_a[i] == name_b[i])
> > + ++i;
> > + while (i && isdigit(name_a[i - 1]) && isdigit(name_b[i - 1]))
>
> name_a[i - 1] and name_b[i - 1] must be same here.
Indeed, I'll simplify it in v3, thanks.
--
Adrien Mazarguil
6WIND