Re: [dpdk-dev] [PATCH v5] ethdev: add flow API to expand RSS flows

[Adrien Mazarguil <adrien.mazarguil@6wind.com>]

On Thu, Jun 28, 2018 at 06:01:21PM +0200, Nelio Laranjeiro wrote:
> Introduce an helper for PMD to expand easily flows items list with RSS
> action into multiple flow items lists with priority information.
> 
> For instance a user items list being "eth / end" with rss action types
> "ipv4-udp ipv6-udp end" needs to be expanded into three items lists:
> 
>  - eth
>  - eth / ipv4 / udp
>  - eth / ipv6 / udp
> 
> to match the user request.  Some drivers are unable to reach such
> request without this expansion, this API is there to help those.
> Only PMD should use such API for their internal cooking, the application
> will still handle a single flow.
> 
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> 
> ---
> 
> Changes in v5:
> 
> - Replace the struct rte_flow_expand_rss field by a flexible array,
> - Address all nits.

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

With just a couple of tiny nits, not sure they're worth a v6. See below.

<snip>
> +/** Node object of input graph for rte_flow_expand_rss(). */
> +struct rte_flow_expand_node {
> +	const int *const next;
> +	/**< List of next node indexes. Index 0 is interpreted as a
> +	 * terminator. */
> +	const enum rte_flow_item_type type;
> +	/**< Pattern item type of current node. */
> +	uint64_t rss_types;
> +	/**< RSS types bit-field associated with this node (see ETH_RSS_*
> +	 * definitions).*/
> +};

Multi-line comments should have opening and closing tokens on dedicated
lines.

<snip>
> + * @param[in] graph.

Extra "."

-- 
Adrien Mazarguil
6WIND