[dpdk-dev] [PATCH] kni: Fix kni_autotest for new Rx/Tx offloads API

[dpdk-dev] [PATCH] kni: Fix kni_autotest for new Rx/Tx offloads API

[Dan Gora]

Fixed a bug where kni_autotest would not start due to the lack of the
ETH_TXQ_FLAGS_IGNORE flag being set in the rte_eth_txconf structure
passed to rte_eth_tx_queue_setup.

This was introduced in commit 4b954bb16747 ("ethdev: remove new to
old offloads API helpers")

Signed-off-by: Dan Gora <dg@adax.com>
---
 test/test/test_kni.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/test/test/test_kni.c b/test/test/test_kni.c
index ec051c07e..0b08e9d66 100644
--- a/test/test/test_kni.c
+++ b/test/test/test_kni.c
@@ -67,6 +67,7 @@ static const struct rte_eth_txconf tx_conf = {
 	},
 	.tx_free_thresh = 0,
 	.tx_rs_thresh = 0,
+	.txq_flags = ETH_TXQ_FLAGS_IGNORE,
 };
 
 static const struct rte_eth_conf port_conf = {
-- 
2.18.0.rc1.1.g6f333ff2f

Re: [dpdk-dev] [PATCH] kni: Fix kni_autotest for new Rx/Tx offloads API

[Thomas Monjalon]

29/06/2018 01:02, Dan Gora:
> Fixed a bug where kni_autotest would not start due to the lack of the
> ETH_TXQ_FLAGS_IGNORE flag being set in the rte_eth_txconf structure
> passed to rte_eth_tx_queue_setup.
> 
> This was introduced in commit 4b954bb16747 ("ethdev: remove new to
> old offloads API helpers")

The flag ETH_TXQ_FLAGS_IGNORE has been removed in 18.08.

Re: [dpdk-dev] [PATCH] kni: Fix kni_autotest for new Rx/Tx offloads API

[Dan Gora]

Hi Thomas,

thanks... Is it worthwhile to mark this patch as eligible for backporting?

d


On Wed, Aug 1, 2018 at 1:43 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 29/06/2018 01:02, Dan Gora:
> > Fixed a bug where kni_autotest would not start due to the lack of the
> > ETH_TXQ_FLAGS_IGNORE flag being set in the rte_eth_txconf structure
> > passed to rte_eth_tx_queue_setup.
> >
> > This was introduced in commit 4b954bb16747 ("ethdev: remove new to
> > old offloads API helpers")
>
> The flag ETH_TXQ_FLAGS_IGNORE has been removed in 18.08.
>
>

Re: [dpdk-dev] [PATCH] kni: Fix kni_autotest for new Rx/Tx offloads API

[Thomas Monjalon]

01/08/2018 21:50, Dan Gora:
> Hi Thomas,
> 
> thanks... Is it worthwhile to mark this patch as eligible for backporting?

I don't think so.
Ferruh?


> On Wed, Aug 1, 2018 at 1:43 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 29/06/2018 01:02, Dan Gora:
> > > Fixed a bug where kni_autotest would not start due to the lack of the
> > > ETH_TXQ_FLAGS_IGNORE flag being set in the rte_eth_txconf structure
> > > passed to rte_eth_tx_queue_setup.
> > >
> > > This was introduced in commit 4b954bb16747 ("ethdev: remove new to
> > > old offloads API helpers")
> >
> > The flag ETH_TXQ_FLAGS_IGNORE has been removed in 18.08.
> >
> >
> 

Re: [dpdk-dev] [PATCH] kni: Fix kni_autotest for new Rx/Tx offloads API

[Ferruh Yigit]

On 8/2/2018 6:49 AM, Thomas Monjalon wrote:
> 01/08/2018 21:50, Dan Gora:
>> Hi Thomas,
>>
>> thanks... Is it worthwhile to mark this patch as eligible for backporting?
> 
> I don't think so.
> Ferruh?

Same here, I don't think required to backport this.

> 
> 
>> On Wed, Aug 1, 2018 at 1:43 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
>>>
>>> 29/06/2018 01:02, Dan Gora:
>>>> Fixed a bug where kni_autotest would not start due to the lack of the
>>>> ETH_TXQ_FLAGS_IGNORE flag being set in the rte_eth_txconf structure
>>>> passed to rte_eth_tx_queue_setup.
>>>>
>>>> This was introduced in commit 4b954bb16747 ("ethdev: remove new to
>>>> old offloads API helpers")
>>>
>>> The flag ETH_TXQ_FLAGS_IGNORE has been removed in 18.08.
>>>
>>>
>>
> 
> 
> 
> 
>