From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id E29C01B439 for ; Fri, 29 Jun 2018 17:51:45 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jun 2018 08:51:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,285,1526367600"; d="scan'208";a="241389740" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.228]) by fmsmga005.fm.intel.com with ESMTP; 29 Jun 2018 08:51:43 -0700 Date: Fri, 29 Jun 2018 23:51:45 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: zhihong.wang@intel.com, jfreimann@redhat.com, dev@dpdk.org, mst@redhat.com, jasowang@redhat.com, wexu@redhat.com Message-ID: <20180629155145.GB31010@debian> References: <20180622134327.18973-1-maxime.coquelin@redhat.com> <20180622134327.18973-3-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180622134327.18973-3-maxime.coquelin@redhat.com> User-Agent: Mutt/1.9.5 (2018-04-13) Subject: Re: [dpdk-dev] [PATCH v5 02/15] vhost: add helpers for packed virtqueues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2018 15:51:46 -0000 On Fri, Jun 22, 2018 at 03:43:14PM +0200, Maxime Coquelin wrote: > From: Jens Freimann > > Add some helper functions to check descriptor flags > and check if a vring is of type packed. > > Signed-off-by: Jens Freimann > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost.h | 6 ++++++ > lib/librte_vhost/virtio-packed.h | 16 ++++++++++++++++ > 2 files changed, 22 insertions(+) > > diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h > index bf2059198..34a614c97 100644 > --- a/lib/librte_vhost/vhost.h > +++ b/lib/librte_vhost/vhost.h > @@ -319,6 +319,12 @@ struct virtio_net { > struct vhost_user_extern_ops extern_ops; > } __rte_cache_aligned; > > +static __rte_always_inline bool > +vq_is_packed(struct virtio_net *dev) > +{ > + return dev->features & (1ull << VIRTIO_F_RING_PACKED); > +} > + > #define VHOST_LOG_PAGE 4096 > > /* > diff --git a/lib/librte_vhost/virtio-packed.h b/lib/librte_vhost/virtio-packed.h > index 744b3991b..21fe5045b 100644 > --- a/lib/librte_vhost/virtio-packed.h > +++ b/lib/librte_vhost/virtio-packed.h > @@ -19,4 +19,20 @@ struct vring_desc_packed { > uint16_t flags; > }; > > + > +static inline int Better to return bool. > +desc_is_avail(struct vring_desc_packed *desc, uint16_t wrap_counter) > +{ > + if (wrap_counter == 1) { > + if ((desc->flags & VRING_DESC_F_AVAIL) && > + !(desc->flags & VRING_DESC_F_USED)) > + return 1; > + } else { > + if (!(desc->flags & VRING_DESC_F_AVAIL) && > + (desc->flags & VRING_DESC_F_USED)) > + return 1; > + } > + return 0; Maybe something like: return wrap_counter == !!(desc->flags & VRING_DESC_F_AVAIL) && wrap_counter != !!(dsec->flags & VRING_DESC_F_USED); is better? Best regards, Tiwei Bie > +} > + > #endif /* __VIRTIO_PACKED_H */ > -- > 2.14.4 >