From: Tiwei Bie <tiwei.bie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: zhihong.wang@intel.com, dev@dpdk.org, yong.liu@intel.com
Subject: Re: [dpdk-dev] [PATCH v4 0/4] net/virtio: Tx simple path removal and offload improvements
Date: Tue, 3 Jul 2018 10:49:03 +0800 [thread overview]
Message-ID: <20180703024902.GA26043@debian> (raw)
In-Reply-To: <20180702152547.31423-1-maxime.coquelin@redhat.com>
On Mon, Jul 02, 2018 at 05:25:43PM +0200, Maxime Coquelin wrote:
> In this v3, the main change is the removal of the Tx simple path.
> Indeed, this path is not compliant with the Virtio specification,
> so could cause problems with some host implementations.
>
> Since Marvin has introduced the in-order path, we have a good
> replacement for simple Tx and so we think it is better to
> remove it than disabling it by defaul
>
> Maxime Coquelin (4):
> net/virtio: remove simple Tx path
> net/virtio: improve Tx offload features negotiation
> net/virtio: don't use simple Rx if TCP LRO or VLAN strip
> net/virtio: improve offload check performance
>
> drivers/net/virtio/virtio_ethdev.c | 49 ++++++++++++++++------
> drivers/net/virtio/virtio_ethdev.h | 3 --
> drivers/net/virtio/virtio_pci.h | 4 +-
> drivers/net/virtio/virtio_rxtx.c | 74 ++++++---------------------------
> drivers/net/virtio/virtio_rxtx_simple.c | 67 -----------------------------
> drivers/net/virtio/virtio_rxtx_simple.h | 49 ----------------------
> drivers/net/virtio/virtio_user_ethdev.c | 1 -
> 7 files changed, 51 insertions(+), 196 deletions(-)
>
> --
> 2.14.4
>
For the series:
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Thanks!
next prev parent reply other threads:[~2018-07-03 2:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 15:25 Maxime Coquelin
2018-07-02 15:25 ` [dpdk-dev] [PATCH v4 1/4] net/virtio: remove simple Tx path Maxime Coquelin
2018-07-02 15:25 ` [dpdk-dev] [PATCH v4 2/4] net/virtio: improve Tx offload features negotiation Maxime Coquelin
2018-07-02 15:25 ` [dpdk-dev] [PATCH v4 3/4] net/virtio: don't use simple Rx if TCP LRO or VLAN strip Maxime Coquelin
2018-07-02 15:25 ` [dpdk-dev] [PATCH v4 4/4] net/virtio: improve offload check performance Maxime Coquelin
2018-07-03 2:49 ` Tiwei Bie [this message]
2018-07-04 5:17 ` [dpdk-dev] [PATCH v4 0/4] net/virtio: Tx simple path removal and offload improvements Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703024902.GA26043@debian \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=yong.liu@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).