From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 27A4C1BE6A for ; Tue, 3 Jul 2018 04:49:04 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jul 2018 19:49:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,301,1526367600"; d="scan'208";a="53629860" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.228]) by orsmga007.jf.intel.com with ESMTP; 02 Jul 2018 19:49:01 -0700 Date: Tue, 3 Jul 2018 10:49:03 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: zhihong.wang@intel.com, dev@dpdk.org, yong.liu@intel.com Message-ID: <20180703024902.GA26043@debian> References: <20180702152547.31423-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180702152547.31423-1-maxime.coquelin@redhat.com> User-Agent: Mutt/1.9.5 (2018-04-13) Subject: Re: [dpdk-dev] [PATCH v4 0/4] net/virtio: Tx simple path removal and offload improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 02:49:05 -0000 On Mon, Jul 02, 2018 at 05:25:43PM +0200, Maxime Coquelin wrote: > In this v3, the main change is the removal of the Tx simple path. > Indeed, this path is not compliant with the Virtio specification, > so could cause problems with some host implementations. > > Since Marvin has introduced the in-order path, we have a good > replacement for simple Tx and so we think it is better to > remove it than disabling it by defaul > > Maxime Coquelin (4): > net/virtio: remove simple Tx path > net/virtio: improve Tx offload features negotiation > net/virtio: don't use simple Rx if TCP LRO or VLAN strip > net/virtio: improve offload check performance > > drivers/net/virtio/virtio_ethdev.c | 49 ++++++++++++++++------ > drivers/net/virtio/virtio_ethdev.h | 3 -- > drivers/net/virtio/virtio_pci.h | 4 +- > drivers/net/virtio/virtio_rxtx.c | 74 ++++++--------------------------- > drivers/net/virtio/virtio_rxtx_simple.c | 67 ----------------------------- > drivers/net/virtio/virtio_rxtx_simple.h | 49 ---------------------- > drivers/net/virtio/virtio_user_ethdev.c | 1 - > 7 files changed, 51 insertions(+), 196 deletions(-) > > -- > 2.14.4 > For the series: Reviewed-by: Tiwei Bie Thanks!