From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 9B1C61BE31 for ; Tue, 3 Jul 2018 05:28:21 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jul 2018 20:28:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,301,1526367600"; d="scan'208";a="68200081" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.228]) by fmsmga004.fm.intel.com with ESMTP; 02 Jul 2018 20:28:18 -0700 Date: Tue, 3 Jul 2018 11:28:19 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: zhihong.wang@intel.com, dev@dpdk.org Message-ID: <20180703032819.GA3041@debian> References: <20180627144959.17277-1-maxime.coquelin@redhat.com> <20180627144959.17277-2-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180627144959.17277-2-maxime.coquelin@redhat.com> User-Agent: Mutt/1.9.5 (2018-04-13) Subject: Re: [dpdk-dev] [PATCH v3 1/7] vhost: use shadow used ring in dequeue path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 03:28:22 -0000 On Wed, Jun 27, 2018 at 04:49:53PM +0200, Maxime Coquelin wrote: [...] > @@ -1164,8 +1136,7 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id, > > if (mbuf_is_consumed(zmbuf->mbuf)) { > used_idx = vq->last_used_idx++ & (vq->size - 1); Above line and other `used_idx` related code in this function should be removed too. Apart from that, Reviewed-by: Tiwei Bie Thanks! > - update_used_ring(dev, vq, used_idx, > - zmbuf->desc_idx); > + update_shadow_used_ring(vq, zmbuf->desc_idx, 0); > nr_updated += 1; > > TAILQ_REMOVE(&vq->zmbuf_list, zmbuf, next); [...]