DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH v2 5/8] dpaa2: fix default IOVA build setting for meson builds
Date: Tue,  3 Jul 2018 11:31:16 +0100	[thread overview]
Message-ID: <20180703103119.15747-6-bruce.richardson@intel.com> (raw)
In-Reply-To: <20180703103119.15747-1-bruce.richardson@intel.com>

By default, the DPAA2_USE_PHYS_IOVA setting with the make build-system
is "y", which is overridden to "n" in the config file specifically for
the arm64-dpaa2-linuxapp-gcc builds. The lack of this setting in meson
builds causes issues for 32-bit build, as the alternative code paths
have compiler warnings e.g. for i686 builds. Therefore we should align
the meson and make settings, setting the value to "true" by default and
overriding it to "false" for dpaa2-specific builds.

Fixes: 6ec78c2463ac ("build: add meson support for dpaaX platforms")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Series-acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 config/arm/meson.build | 2 +-
 config/meson.build     | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 5ad926eda..40dbc87f7 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -64,7 +64,7 @@ flags_dpaa2 = [
 	['RTE_CACHE_LINE_SIZE', 64],
 	['RTE_MAX_NUMA_NODES', 1],
 	['RTE_MAX_LCORE', 16],
-	['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', 'n']]
+	['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false]]
 
 ## Arm implementer ID (ARM DDI 0487C.a, Section G7.2.106, Page G7-5321)
 impl_generic = ['Generic armv8', flags_generic, machine_args_generic]
diff --git a/config/meson.build b/config/meson.build
index 1531d9f0e..7a84fa8d0 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -78,6 +78,7 @@ dpdk_conf.set('RTE_EAL_ALLOW_INV_SOCKET_ID', get_option('allow_invalid_socket_id
 # values which have defaults which may be overridden
 dpdk_conf.set('RTE_MAX_VFIO_GROUPS', 64)
 dpdk_conf.set('RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB', 64)
+dpdk_conf.set('RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', true)
 
 compile_time_cpuflags = []
 if host_machine.cpu_family().startswith('x86')
-- 
2.17.1

  parent reply	other threads:[~2018-07-03 10:32 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08 16:38 [dpdk-dev] [PATCH 0/7] Enable 32-bit native builds with meson Bruce Richardson
2018-06-08 16:38 ` [dpdk-dev] [PATCH 1/7] kni: disable for 32-bit meson builds Bruce Richardson
2018-07-02 23:45   ` Ferruh Yigit
2018-06-08 16:38 ` [dpdk-dev] [PATCH 2/7] bpf: fix 32-bit build support with meson Bruce Richardson
2018-06-14 11:57   ` Ananyev, Konstantin
2018-06-08 16:38 ` [dpdk-dev] [PATCH 3/7] net/sfc: disable for 32-bit builds Bruce Richardson
2018-06-08 17:10   ` Andrew Rybchenko
2018-06-08 16:38 ` [dpdk-dev] [PATCH 4/7] build: disable pointer to int conversion warnings for 32-bit Bruce Richardson
2018-06-08 16:38 ` [dpdk-dev] [PATCH 5/7] dpaa2: fix default IOVA build setting for meson builds Bruce Richardson
2018-06-29  8:52   ` Hemant Agrawal
2018-06-08 16:38 ` [dpdk-dev] [PATCH 6/7] examples/kni: fix dependency check for building with meson Bruce Richardson
2018-07-02 23:47   ` Ferruh Yigit
2018-07-03 10:07     ` Bruce Richardson
2018-06-08 16:38 ` [dpdk-dev] [PATCH 7/7] net/avp: fix 32-bit meson builds Bruce Richardson
2018-06-08 16:58   ` Legacy, Allain
2018-06-29  8:53 ` [dpdk-dev] [PATCH 0/7] Enable 32-bit native builds with meson Hemant Agrawal
2018-07-03 10:31 ` [dpdk-dev] [PATCH v2 0/8] " Bruce Richardson
2018-07-03 10:31   ` [dpdk-dev] [PATCH v2 1/8] kni: disable for 32-bit meson builds Bruce Richardson
2018-07-03 10:31   ` [dpdk-dev] [PATCH v2 2/8] bpf: fix 32-bit build support with meson Bruce Richardson
2018-07-03 10:31   ` [dpdk-dev] [PATCH v2 3/8] net/sfc: disable for 32-bit builds Bruce Richardson
2018-07-03 10:31   ` [dpdk-dev] [PATCH v2 4/8] build: disable pointer to int conversion warnings for 32-bit Bruce Richardson
2018-07-03 10:31   ` Bruce Richardson [this message]
2018-07-03 10:31   ` [dpdk-dev] [PATCH v2 6/8] examples/kni: fix dependency check for building with meson Bruce Richardson
2018-07-03 12:09     ` Ferruh Yigit
2018-07-03 10:31   ` [dpdk-dev] [PATCH v2 7/8] net/avp: fix 32-bit meson builds Bruce Richardson
2018-07-03 10:31   ` [dpdk-dev] [PATCH v2 8/8] net/kni: fix check for meson build Bruce Richardson
2018-07-03 12:10     ` Ferruh Yigit
2018-07-12 10:29   ` [dpdk-dev] [PATCH v2 0/8] Enable 32-bit native builds with meson Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180703103119.15747-6-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).