DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH v2 6/8] examples/kni: fix dependency check for building with meson
Date: Tue,  3 Jul 2018 11:31:17 +0100	[thread overview]
Message-ID: <20180703103119.15747-7-bruce.richardson@intel.com> (raw)
In-Reply-To: <20180703103119.15747-1-bruce.richardson@intel.com>

Rather than hard-coding the example app to be built only when a set of
conditions are met, we can simplify things by having the app built when
KNI library itself is available. That saves us duplicating the same set
of restrictions on both library and example app.

Fixes: 89f0711f9ddf ("examples: build some samples with meson")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Series-acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 examples/kni/meson.build | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/examples/kni/meson.build b/examples/kni/meson.build
index 0443ab99b..791316394 100644
--- a/examples/kni/meson.build
+++ b/examples/kni/meson.build
@@ -6,9 +6,8 @@
 # To build this example as a standalone application with an already-installed
 # DPDK instance, use 'make'
 
-if host_machine.system() != 'linux'
-	build = false
-endif
+# this app can be built if-and-only-if KNI library is buildable
+build = dpdk_conf.has('RTE_LIBRTE_KNI')
 deps += ['kni', 'bus_pci']
 sources = files(
 	'main.c'
-- 
2.17.1

  parent reply	other threads:[~2018-07-03 10:32 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08 16:38 [dpdk-dev] [PATCH 0/7] Enable 32-bit native builds " Bruce Richardson
2018-06-08 16:38 ` [dpdk-dev] [PATCH 1/7] kni: disable for 32-bit meson builds Bruce Richardson
2018-07-02 23:45   ` Ferruh Yigit
2018-06-08 16:38 ` [dpdk-dev] [PATCH 2/7] bpf: fix 32-bit build support with meson Bruce Richardson
2018-06-14 11:57   ` Ananyev, Konstantin
2018-06-08 16:38 ` [dpdk-dev] [PATCH 3/7] net/sfc: disable for 32-bit builds Bruce Richardson
2018-06-08 17:10   ` Andrew Rybchenko
2018-06-08 16:38 ` [dpdk-dev] [PATCH 4/7] build: disable pointer to int conversion warnings for 32-bit Bruce Richardson
2018-06-08 16:38 ` [dpdk-dev] [PATCH 5/7] dpaa2: fix default IOVA build setting for meson builds Bruce Richardson
2018-06-29  8:52   ` Hemant Agrawal
2018-06-08 16:38 ` [dpdk-dev] [PATCH 6/7] examples/kni: fix dependency check for building with meson Bruce Richardson
2018-07-02 23:47   ` Ferruh Yigit
2018-07-03 10:07     ` Bruce Richardson
2018-06-08 16:38 ` [dpdk-dev] [PATCH 7/7] net/avp: fix 32-bit meson builds Bruce Richardson
2018-06-08 16:58   ` Legacy, Allain
2018-06-29  8:53 ` [dpdk-dev] [PATCH 0/7] Enable 32-bit native builds with meson Hemant Agrawal
2018-07-03 10:31 ` [dpdk-dev] [PATCH v2 0/8] " Bruce Richardson
2018-07-03 10:31   ` [dpdk-dev] [PATCH v2 1/8] kni: disable for 32-bit meson builds Bruce Richardson
2018-07-03 10:31   ` [dpdk-dev] [PATCH v2 2/8] bpf: fix 32-bit build support with meson Bruce Richardson
2018-07-03 10:31   ` [dpdk-dev] [PATCH v2 3/8] net/sfc: disable for 32-bit builds Bruce Richardson
2018-07-03 10:31   ` [dpdk-dev] [PATCH v2 4/8] build: disable pointer to int conversion warnings for 32-bit Bruce Richardson
2018-07-03 10:31   ` [dpdk-dev] [PATCH v2 5/8] dpaa2: fix default IOVA build setting for meson builds Bruce Richardson
2018-07-03 10:31   ` Bruce Richardson [this message]
2018-07-03 12:09     ` [dpdk-dev] [PATCH v2 6/8] examples/kni: fix dependency check for building with meson Ferruh Yigit
2018-07-03 10:31   ` [dpdk-dev] [PATCH v2 7/8] net/avp: fix 32-bit meson builds Bruce Richardson
2018-07-03 10:31   ` [dpdk-dev] [PATCH v2 8/8] net/kni: fix check for meson build Bruce Richardson
2018-07-03 12:10     ` Ferruh Yigit
2018-07-12 10:29   ` [dpdk-dev] [PATCH v2 0/8] Enable 32-bit native builds with meson Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180703103119.15747-7-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).