From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70072.outbound.protection.outlook.com [40.107.7.72]) by dpdk.org (Postfix) with ESMTP id 7B3961B4AD for ; Tue, 3 Jul 2018 19:05:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=USfCPUSxwH1HZF1SXJJiN1AL6LWLpElx6673hGNdvOQ=; b=u/o9mTiUYH3cmY7UsKnEd5s3PMe535efaDaRPdPmgfy0XwGicHBCDKJBna9SIrUIW2FaOjuLVo9d2vyPSGpaA2Xirp6GPrAU1KDwHk0XIh+/587E+C3WKAgN+cmsmYnxi38U0xV+syXCAbzj9TVjNengkmEelX8/9EwLfo5HYQo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from yongseok-MBP.local (209.116.155.178) by VI1PR0501MB2046.eurprd05.prod.outlook.com (2603:10a6:800:36::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.24; Tue, 3 Jul 2018 17:05:19 +0000 Date: Tue, 3 Jul 2018 10:05:05 -0700 From: Yongseok Koh To: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Cc: dev@dpdk.org, Adrien Mazarguil Message-ID: <20180703170504.GA41721@yongseok-MBP.local> References: <1368a8720f3ec3c40e47a6b1d9ef1edf0f38a646.1530111623.git.nelio.laranjeiro@6wind.com> <20180703010703.GB38831@yongseok-MBP.local> <20180703071756.5fqggm5o77ytaptg@laranjeiro-vm.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180703071756.5fqggm5o77ytaptg@laranjeiro-vm.dev.6wind.com> User-Agent: Mutt/1.9.3 (2018-01-21) X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CY4PR1101CA0016.namprd11.prod.outlook.com (2603:10b6:910:15::26) To VI1PR0501MB2046.eurprd05.prod.outlook.com (2603:10a6:800:36::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3af05472-f2d4-437d-9d11-08d5e1072854 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2046; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2046; 3:ErC0+BPBZcufHe/AVLlOlzDbLUPc88CWDTNCG+rxaQ1eGpN1fSfQT0vm7XZUlYduQzYW59+abKUhp+3BGBPFSoey73QK3drln4MdDLOw75mmU/+6FYB5H3LBzYUDRk29AtOXg31QFJO3IRmW+GcXgGTn+FXA87piGiaEHuaXcPPg0+wbgEEvdWy8Phq+xfoJaz4StxcCw7zQ6XFPxEeqbMO8dfaUW6LthO/vk+CSHaffcsTbLQRGPjUTyYz3g9s7; 25:Op5+v8FHnIRauyCmLqu0hPTFYpTqGVPrgYwz6G2VG7wiDcV/CkivXoMTmbt1T4t3RnhUZVJpOWKC9I0mJDgcbgqiIbHU1rct8bSouCAbJzQXYvaEtxny2mmcxBSZTbwmsUuocJSaA2/E3F8lJvmGIREbQ13v/LzbhkD2lsDIL5AqhTBuHBx0FmPaT91JCM8F1iG1TM2tiwdVX4K0svkrIZamtgTxpg0MayociL2DDQqvqe5mI9xUj2OAacJ3EyKZ34oNsweQgFWh/vb44o8N8iXNf3G2o4n/kLubalckNc54LL+s8KVSuDy67BOv34/LNLOKXWlgzqmjVBurPGqPeQ==; 31:EgFf5oh9VoiWvQEbOeoYD+d+51JpEs2iYZnkkXM6CJUocG8pLGYJQOpgLx8Wg1SUhhYrfvqM9kLnZ9tTinL+ipsIhuEwEQyrcU3GR3zAZQPSf2Y7GmlXAJgrnTOkMRIb5ha89W2nss043wzsMQE7uRcWtQOvA84QPaitCkgWuaeWU39Cg9nHymAoIRUygrGN/sp0DxHpOGI1X0wzCNKOFiWJwUQ4MCpoiGW+xb7oRSo= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2046: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2046; 20:X2JnqjFUql8Xz6NZrsnes9HMWZg5VlabnMRAHxUVUXMjiSla+lVbLtGJON3718RKLshLbm3NOjb6VB7NN8eQqc0ouw9yIebmFCTI8Fi0vMdtuF+HP6XGGsewKEH1asB6SgXn+vVI/G34RMGpPo9Y9a2hLiOuyyG1mx4xaKDfWWTq9U/jJz8sDk34Es+YDA8v37b29oOMEDpxPYz6HAa71r3ZzvesdEqAhCMnVIl46n8gwnJ51zOqzMkG2W3GLM4Shq/mxC7VFN9SwNKoGOFPaXnfzp2NbLcHe+soRqm7+cBcJ5+xZiXf1fL/JhEQKqVMBKYpNrILi3bkV/Rf7zubUxyo3I2rmMKokhurWOpQ98PJ8wTobT86fYd5269OcAIYTXlwai4klLJwVzNPfcev0KC26QBv9+fm44W5DPNeWKq71SxJfFuS/NZpTYcJMKNqsCmjdbns+HTPU1bdByKwLK5/NPCEhq32EjXIjJ6jI9qo76cXdacDzOus3GS9mCpB; 4:U74bnCxB5X2bTle/CRmkgJ+bF+khPKRUiVGahdHVVC5mCTBacgweWn4CQLQk+j9T1QkAoWzpeGwBtyP6U84qvsv1azTZNVH8HEtValZ1mpP0tc00EIHoMDQpkD9lqTYxTs+nTCYXoMbcCB2VzLcshOngN4AFnJQo/dXw7WDMSheItvxWKqhLZ0Sp/rZ1YlIV7bYtUzMYjhtZyJIj5sDwumbJEuab7CTErif72NO1B943zAntwSR2vpmXB21NyqkQSa5w/R0oKbmI+sLX7yCqbPlUcBRwM939VCrAMmyhbc2sYGXf+8lAzrykp+tI3Iro X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(17755550239193); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231254)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB2046; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2046; X-Forefront-PRVS: 0722981D2A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(136003)(366004)(376002)(396003)(189003)(199004)(50466002)(81166006)(81156014)(229853002)(4326008)(956004)(486006)(476003)(66066001)(6916009)(8936002)(106356001)(105586002)(9686003)(478600001)(6116002)(186003)(68736007)(3846002)(446003)(16526019)(11346002)(25786009)(14444005)(1076002)(26005)(8676002)(47776003)(305945005)(33656002)(386003)(7736002)(6506007)(316002)(6246003)(98436002)(55016002)(2906002)(58126008)(86362001)(7696005)(76176011)(52116002)(6666003)(23756003)(33896004)(53936002)(93886005)(5660300001)(97736004)(2870700001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2046; H:yongseok-MBP.local; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1; VI1PR0501MB2046; 23:wDqAz7Gi53/5fcTNG6m88oU9BPLI+pRIG4Kjf?= =?iso-8859-1?Q?GAKCKs+gufvbqgCnSEfqr6TLYexykoUY9oItXAHWruoCTwLjSxbfHguB/y?= =?iso-8859-1?Q?AOLHCiZrSGbixWngMsXQBObtTM/bJK1T64x9Nx0Jmwo/8gv48eO5VRvxHp?= =?iso-8859-1?Q?TDwiL26R64xdKl6swwSooeU77bdrNhwWf0Begd7AUifL41AQg+iLznUhea?= =?iso-8859-1?Q?eaI/p/eNJYqi8coGRWLWPwK18G8QlkqpssBy9g0PtOyRPKpo7EhCYFSiTd?= =?iso-8859-1?Q?y4aaKC8vFT8mBEU/FVbEBKqjiK22tY5X9Ll67B5naDcpO5Jsep3WmA6fIT?= =?iso-8859-1?Q?CbYYr/27gvG4Sdd1hVY66loJiPqnN/3Y2QuUf73uNLx2RJ+kJSu/yw9zxg?= =?iso-8859-1?Q?NG0aIZq0X4NK2Rvn/WxtTYn3O3jwUkpGEQjeE5Ef5xlT47mViGQ1qwSBiu?= =?iso-8859-1?Q?FeSeq58CYaSSyzEYRasqGrTFWFEWpBe7g3/uIliu3nI7SpaAvYHnK+dpQ3?= =?iso-8859-1?Q?Wvab2FKe89J8N4/ZPD7OZscCT538HSA9scOpFqWD2zUquoAF5HTIPy2C13?= =?iso-8859-1?Q?oZUtzVF1SmZomFPfFahtTH5nBYwAWWJGqHlPZy71DZod2wanJterinOfG7?= =?iso-8859-1?Q?KsdnWiu7MotK4OTz+PAWSNfmiInmknUyLipkxtHRUvr3FLdeO75uWlCCly?= =?iso-8859-1?Q?sEX9LKi8zb6NH3N4N7VrJbBbEQW5DuMZmJJTo29y/hWi3E0kxWE2Mm7ff1?= =?iso-8859-1?Q?/DBiuPq/90TP1c9U0RoGBFnAXKzh59T43PLSMrG7ikxx7V/azJ6tKGY+ft?= =?iso-8859-1?Q?oqjCj2hox2eGBkad3wnQkTUkX6DSbE3aXYaAu4VVDAQDcIuaex4u6J82PS?= =?iso-8859-1?Q?BCMwx7a0wOkiHQhMdgTg/XrqJ/eH5kqP0QxXtFGlGqRF+4GzaTP/rrc8Ye?= =?iso-8859-1?Q?n7Ap3Vmj0NKusSPfwxGM/egLMWlxD8rSXc+S/HsY5Jnhrd+lKo4BRloWK7?= =?iso-8859-1?Q?mVy5PgvPwk7V230LP3NxP6nka5+ZDLKYTPDRgVnlMKvMllfjivz+1GIQQL?= =?iso-8859-1?Q?ckWdtWB8FoZv+0X5FuCQaYQ3ip2UIxLAUXwjkaX5K2FKED7Q66QSXSzbwU?= =?iso-8859-1?Q?RxkqaKVQWzP0NzpxmvBLL5N1yjmYIr0fvMKALxf1PEhBuJdtapGOGA1ZAU?= =?iso-8859-1?Q?RakJAKtS9On36rxhqf4isYyHA6gkIE8rRuFLbqNdti5Q6pLXvaziRWuUop?= =?iso-8859-1?Q?VsDRDMC766KyEltdl0tIFL80ft6DrxV+3aCOMMveoJqhNJW5LjrBSYzJO2?= =?iso-8859-1?Q?dk72FRUEbAkaoCs9fO4R2arnOZUayGcTCMODdz7eECvztfYzZqUuixK0qd?= =?iso-8859-1?Q?Sce34ZIkEQ=3D?= X-Microsoft-Antispam-Message-Info: yQ4iqZk4LOfroixkeiiBlJb4kjEY0zW+gc5UMP9EG5elbivFDAAE087pAUgp4WpduKD6BT4WPJSMP9cNf4r9p7is6E+PamQKYrJiJFBnSsPzKQYYhi1wWG2jjhyML6F9N2nv9TvFvZCKv28srBbUFsgm06SlYgKTx9fv0arlEb7nOEoIIJ/kcy8eFYMzz5bgsrOHECEuvoAogiqeG8DNwlu95vxYAJxycg6kCLJMfjoqTJSqOb0KhcBZVvQGqOB7BmlVoZIt5Nb44KCf71c4/8Lfvg2oYDuZHKdz8qmhrFMYTtXkKYcmmWPO0XyRN4fx8mgQB/K/IIybnsNqH7HJLcvnMu7A8p769tYFTUWbm94= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2046; 6:ZS7eINROeDwetiknDvVV5UqBT4IYo4vWjCd8u4MuWFstHxmlCuc14xcENYUgOb5EZAVhT0Hpi56RjLaicmpyxLb2rGKXWapP9Nj+dNcvs/Jc6CBQMAQrMZTGGCqbUtiUqb+bEVCFTVfsTY+dEHSbDfBll6PTW1pk8NUoBhchfh9qGszChBKHJ67imtE7RtcByrH8VIevPtyLLOgBOGa3MAFSPJTLp9AcWfLXY7y8PC07X5lVRooI9yuVTUihTY7qK4MCd8GgMTgPUrcY9u2Md/XOPyNsv4E0Wi3ZNWLKI5FiYmoLj77IrsHaGAarwTXx+cgPKS8nPZzIpSEX9nuLg56n0lz3nkuNv0yXxSSigAuewubgU1uwvickD31jzD39XcLZLfi128jZR2pkxAFopbonlZlFKe60Ma5g5sJadF7izCaAJNd2ENhL+YeCl3LJw2i6TOOQYQ34e2GCA2FXPQ==; 5:cd5txroZrJbZcisq0gjIDXbYY9gZRohFVmIEAbPKA/zmJRhArU1lgA1aTmWmvkuXWYEI3Dyupl2K2rsgNCRizmyMMbi7SCaQ9Cub7/nVvd8H76Zz23WklKIgpSHJ+2ufSOSTnVS7SQ/DH9TJr/6Zlt36p8hQlyGdyDjGbwPDC/M=; 24:WysYUIfvq/WHqbwHSBaHcpe5jP9dsB8aGOrSbpFWKYdApyyoBKOlKkNP0fA5HOzEjEP+NIR0rnUyH1r3rO3F2UKLOP+u0yc5bdaEXKrc0NA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2046; 7:+iY0WlVAZ5uET3YUsgWIcPLikpZRFjoystwAJtSVtQw4+9PsekIGg5Bi0bnd+XrDxGP5JYzLvU2XIFn+taOtjJxHMyqxoSw+rzWaYFW2w/cy5b4FHWQqYvNPntEHtGgGU5lrwHzckKifynlbbrxPlYfTBz3LMc/V3follrcSIv+Hw1PSDrpmQyVc7PENwNFtc1CYtyjkPLIBvjcYQbqrZPzzKRAyqp+LV5u8PESYKgwdHtAb5PXYecmwnDDSCdau X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2018 17:05:19.1610 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3af05472-f2d4-437d-9d11-08d5e1072854 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2046 Subject: Re: [dpdk-dev] [PATCH v2 02/20] net/mlx5: handle drop queues are regular queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 17:05:21 -0000 On Tue, Jul 03, 2018 at 09:17:56AM +0200, Nélio Laranjeiro wrote: > On Mon, Jul 02, 2018 at 06:07:03PM -0700, Yongseok Koh wrote: > > On Wed, Jun 27, 2018 at 05:07:34PM +0200, Nelio Laranjeiro wrote: [...] > flow_drop_queue is also confusing as it is a drop hash rx queue, it can > be used without a flow as a regular queue. > Renaming it to drop_hrxq. Not so much critical to me but the entry has a field having repeating name. priv->drop_hrxq.hrxq and priv->drop_hrxq.rxq Sounds still confusing... > > > +/** > > > + * Release a drop Rx queue Verbs object. > > > + * > > > + * @param dev > > > + * Pointer to Ethernet device. > > > + * @param rxq > > > + * Pointer to the drop Verbs Rx queue. > > > + * > > > + * @return > > > + * The Verbs object initialised, NULL otherwise and rte_errno is set. > > > + */ > > > +void > > > +mlx5_rxq_ibv_drop_release(struct rte_eth_dev *dev, struct mlx5_rxq_ibv *rxq) > > > > If rxq for drop is saved in priv->drop.rxq, then why does it have to get rxq > > pointer as an argument? Looks redundant. > >[...] > > Like for all hrxqs, indirection tables, rxqs, which are stored in priv > inside a list or an array. However, the assumption is there's only one drop queue while the regular ones have multiple instances. > Priv is used as a storage place which is only access through > *_{new,get,release} functions. Yes, that's what I'm telling you. *_{new,get,release}() accesses priv, then why the pointer (which is saved in priv) is needed as an argument? > This is also to keep a consistency between regular hrxqs, and drop hrxq also. Not sure why that consistency has to be kept. int mlx5_rxq_release(struct rte_eth_dev *dev, uint16_t idx); int mlx5_hrxq_release(struct rte_eth_dev *dev, struct mlx5_hrxq *hxrq); mlx5_rxq_release() takes index as the instances are stored in an array and mlx5_hrxq_release() takes pointer as the instances are stored in a list. Then, what if there's only one instance and no need to search? Not taking such an argument sounds more consistent... Thanks, Yongseok > > > > +void > > > +mlx5_ind_table_ibv_drop_release(struct rte_eth_dev *dev, > > > + struct mlx5_ind_table_ibv *ind_tbl) > > > > ind_tbl is a redundant argument. Can be referenced by > > priv->drop.hrxq->ind_table. > >[...] > > Ditto. > > > > +/** > > > + * Release a drop hash Rx queue. > > > + * > > > + * @param dev > > > + * Pointer to Ethernet device. > > > + * @param hrxq > > > + * Pointer to Hash Rx queue to release. > > > + */ > > > +void > > > +mlx5_hrxq_drop_release(struct rte_eth_dev *dev, struct mlx5_hrxq *hrxq) > >[...] > > > > hrxq is a redundant argument. Can be referenced by priv->drop.hrxq. > >[...] > > Ditto. > > Thanks, > > -- > Nélio Laranjeiro > 6WIND