From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 0752A1C363 for ; Thu, 5 Jul 2018 11:37:49 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id s12-v6so10002857wmc.1 for ; Thu, 05 Jul 2018 02:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to:openpgp :user-agent; bh=6Bsw/h+bzLaQct+V3n9pRTaa9H26W4Cq2LOSpiE/Pvs=; b=aGLtHV5p0ECwjIOytoHDl5r1aKs88cWgE9QSm9WY8eFPKDBWpm0u72sa0jsXc9yq8K yi2O5H8B/Z3CxYg0xdRGpQmedzQwPSj9lNL3tbhXi0hBZEKFL+6PnsTHYxwce1DhJiPz RUus/ismU22NUNXvj61Bz+i9UU6pGILpm3h24eLZVmKLI3HwqAiy45IrbkKIJIBV2MeY 8/ACMvqibh5ggr8Rw/3vmM7D1iMmaM0LRNbwMb/P0TJzNPpYMBaGtwLhE+0n8MAU1MVy rRz2hLvvy+J7HLiqM0iJds/pqzFRlkJSSmfLKEMDPRdA83vmEHaXthP1kBzHJlZPXuMm Jl9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:openpgp:user-agent; bh=6Bsw/h+bzLaQct+V3n9pRTaa9H26W4Cq2LOSpiE/Pvs=; b=GlpLUhFcQojq5ZZGMhgGl88MxDjam8s+jBM8mgwVnmWW9llwLkgFIK3H+fX5GAQk/S 6TDQ2PWBubMYwAOT32WYcOntG94TDiXk+0zSKxvtU0AhYKhkmdU0MI7wxijacVhGIZ5r 1dUNZUkOiWDNC9kujzL2kX3eezUi6fRSQuwKrH7/mWeWyr8T9Jnw75Lgxg5RyChfWQx/ TE1w6EmRFN66Kb+14tlV9Tw9JMeqeA/JQ/wZn3hLMfikZmbP8l1A/Nxo2RJRkHTUHgHe laKlX/7b873m9bMRK9MsaTrRbYhXT+KxBYspBoA7Zwk/SBGgNfONacU6Xk3y2Hk7QRl3 YRZQ== X-Gm-Message-State: APt69E1GDIf0sg2a1OHMhOl3zBJNpxYTF3b+OQGWryIwnWgN3YsPU+4+ p6QNqDTWbSXEfJ1HLoa1imjR X-Google-Smtp-Source: AAOMgpfRJkqO9keAmWRMHMu+azaKCBPkO/i/8MFLNrcgtUCH5uB018uOoIICyWVAiz5oRM9NweOHEg== X-Received: by 2002:adf:c44c:: with SMTP id a12-v6mr4224893wrg.20.1530783469764; Thu, 05 Jul 2018 02:37:49 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id m17-v6sm8856950wrg.65.2018.07.05.02.37.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Jul 2018 02:37:49 -0700 (PDT) Date: Thu, 5 Jul 2018 11:37:47 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Ferruh Yigit Cc: Mohammad Abdul Awal , dev@dpdk.org, Adrien Mazarguil , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , Stephen Hemminger , Ori Kam Message-ID: <20180705093747.4mwgpoxktifva546@laranjeiro-vm.dev.6wind.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: OpenPGP: id=A0075DA8F66A5949 preference=signencrypt User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v7 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 09:37:50 -0000 On Wed, Jul 04, 2018 at 03:54:32PM +0100, Ferruh Yigit wrote: > On 7/2/2018 11:40 AM, Mohammad Abdul Awal wrote: > > > > On 27/06/2018 12:45, Nelio Laranjeiro wrote: > >> This series adds an easy and maintainable configuration version support for > >> those two actions for 18.08 by using global variables in testpmd to store the > >> necessary information for the tunnel encapsulation. Those variables are used > >> in conjunction of RTE_FLOW_ACTION_{VXLAN,NVGRE}_ENCAP action to create easily > >> the action for flows. > >> > >> A common way to use it: > >> > >> set vxlan ipv4 4 4 4 127.0.0.1 128.0.0.1 11:11:11:11:11:11 22:22:22:22:22:22 > >> flow create 0 ingress pattern end actions vxlan_encap / queue index 0 / end > >> > >> set vxlan ipv6 4 4 4 ::1 ::2222 11:11:11:11:11:11 22:22:22:22:22:22 > >> flow create 0 ingress pattern end actions vxlan_encap / queue index 0 / end > >> > >> set nvgre ipv4 4 127.0.0.1 128.0.0.1 11:11:11:11:11:11 22:22:22:22:22:22 > >> flow create 0 ingress pattern end actions nvgre_encap / queue index 0 / end > >> > >> set nvgre ipv6 4 ::1 ::2222 11:11:11:11:11:11 22:22:22:22:22:22 > >> flow create 0 ingress pattern end actions nvgre_encap / queue index 0 / end > >> > >> This also replace the proposal done by Mohammad Abdul Awal [1] which handles > >> in a more complex way for the same work. > >> > >> Note this API has already a modification planned for 18.11 [2] thus those > >> series should have a limited life for a single release. > >> > >> [1] https://dpdk.org/ml/archives/dev/2018-May/101403.html > >> [2] https://dpdk.org/ml/archives/dev/2018-June/103485.html > >> > >> Changes in v7: > >> > >> - add missing documentation added in v5 and removed in v6 by mistake. > >> > >> Changes in v6: > >> > >> - fix compilation under redhat 7.5 with gcc 4.8.5 20150623 > >> > >> Changes in v5: > >> > >> - fix documentation generation. > >> - add more explanation on how to generate several encapsulated flows. > >> > >> Changes in v4: > >> > >> - fix big endian issue on vni and tni. > >> - add samples to the documentation. > >> - set the VXLAN UDP source port to 0 by default to let the driver generate it > >> from the inner hash as described in the RFC 7348. > >> - use default rte flow mask for each item. > >> > >> Changes in v3: > >> > >> - support VLAN in the outer encapsulation. > >> - fix the documentation with missing arguments. > >> > >> Changes in v2: > >> > >> - add default IPv6 values for NVGRE encapsulation. > >> - replace VXLAN to NVGRE in comments concerning NVGRE layer. > >> > >> Nelio Laranjeiro (2): > >> app/testpmd: add VXLAN encap/decap support > >> app/testpmd: add NVGRE encap/decap support > >> > >> app/test-pmd/cmdline.c | 252 ++++++++++++++++++ > >> app/test-pmd/cmdline_flow.c | 274 ++++++++++++++++++++ > >> app/test-pmd/testpmd.c | 32 +++ > >> app/test-pmd/testpmd.h | 32 +++ > >> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 82 ++++++ > >> 5 files changed, 672 insertions(+) > > > > > > Hi, > > > > I have one concern in terms of usability though. > > In testpmd, the rte_flow command line options have auto-completion with > > " " format which make using the command very > > much user friendly. > > > > For the command "set vxlan ipv4 4 4 4 127.0.0.1 128.0.0.1 > > 11:11:11:11:11:11 22:22:22:22:22:22", it does not look much user > > friendly to me. A user may easily lose track of sequence of 9 param > > items. It would be much user friendly if the options would be like below > > and has auto-completion. > > > > set vxlan ip_ver vni udp_src > > udp-dst ip_src ip_dst > > eth_src eth_dst > > Hi Nelio, Adrien, > > I tend to agree with Awal here, this is to forget/confuse and key-value pairs > makes it easier to use. > > Meanwhile this is an usability improvement and I prefer not to block this patch > for this. > > What is your comment on this, how should we proceed? > > Thanks, > ferruh Hi, I also agree with this proposal, I'll prepare a v8 with those fix tokens. > > This way an user may never feel confused. Can maintainers comment on > > this point please? > > > > Regards, > > Awal. Thanks -- Nélio Laranjeiro 6WIND