Re: [dpdk-dev] [PATCH v8 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap

[Adrien Mazarguil <adrien.mazarguil@6wind.com>]

On Thu, Jul 05, 2018 at 04:33:08PM +0200, Nelio Laranjeiro wrote:
> This series adds an easy and maintainable configuration version support for
> those two actions for 18.08 by using global variables in testpmd to store the
> necessary information for the tunnel encapsulation.  Those variables are used
> in conjunction of RTE_FLOW_ACTION_{VXLAN,NVGRE}_ENCAP action to create easily
> the action for flows.
> 
> A common way to use it:
> 
>  set vxlan ip-version ipv4 vni 4 udp-src 4 udp-dst 4 ip-src 27.0.0.1
>         ip-dst 128.0.0.1 eth-src 11:11:11:11:11:11 eth-dst 22:22:22:22:22:22
>  flow create 0 ingress pattern end actions vxlan_encap /
>         queue index 0 / end
> 
>  set vxlan-with-vlan ip-version ipv4 vni 4 udp-src 4 udp-dst 4 p-src
>          127.0.0.1 ip-dst 128.0.0.1 vlan-tci 34 eth-src 11:11:11:11:11:11
>          eth-dst 22:22:22:22:22:22
>  flow create 0 ingress pattern end actions vxlan_encap /
>          queue index 0 / end
> 
>  set vxlan ip-version ipv6 vni 4 udp-src 4 udp-dst 4 ip-src ::1
>         ip-dst ::2222 eth-src 11:11:11:11:11:11 eth-dst 22:22:22:22:22:22
>  flow create 0 ingress pattern end actions vxlan_encap /
>          queue index 0 / end
> 
>  set vxlan-with-vlan ip-version ipv6 vni 4 udp-src 4 udp-dst 4
>          ip-src ::1 ip-dst ::2222 vlan-tci 34 eth-src 11:11:11:11:11:11
>          eth-dst 22:22:22:22:22:22
>  flow create 0 ingress pattern end actions vxlan_encap /
>          queue index 0 / end
> 
> This also replace the proposal done by Mohammad Abdul Awal [1] which handles
> in a more complex way for the same work.
> 
> Note this API has already a modification planned for 18.11 [2] thus those
> series should have a limited life for a single release.
> 
> [1] https://dpdk.org/ml/archives/dev/2018-May/101403.html
> [2] https://dpdk.org/ml/archives/dev/2018-June/103485.html
> 
> Changes in v8:
> 
> - add static tokens in the command line to be user friendly.

Looks good to me,

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

-- 
Adrien Mazarguil
6WIND