From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: tiwei.bie@intel.com, zhihong.wang@intel.com, dev@dpdk.org
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [dpdk-dev] [PATCH v4 5/5] vhost: improve prefetching in enqueue path
Date: Fri, 6 Jul 2018 09:04:49 +0200 [thread overview]
Message-ID: <20180706070449.1946-6-maxime.coquelin@redhat.com> (raw)
In-Reply-To: <20180706070449.1946-1-maxime.coquelin@redhat.com>
This is an optimization to prefetch next buffer while the
current one is being processed.
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
lib/librte_vhost/virtio_net.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index 2662a1d32..82d5d9e17 100644
--- a/lib/librte_vhost/virtio_net.c
+++ b/lib/librte_vhost/virtio_net.c
@@ -393,6 +393,9 @@ copy_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,
buf_iova = buf_vec[vec_idx].buf_iova;
buf_len = buf_vec[vec_idx].buf_len;
+ if (nr_vec > 1)
+ rte_prefetch0((void *)(uintptr_t)buf_vec[1].buf_addr);
+
if (unlikely(buf_len < dev->vhost_hlen && nr_vec <= 1)) {
error = -1;
goto out;
@@ -404,7 +407,6 @@ copy_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,
hdr = &tmp_hdr;
else
hdr = (struct virtio_net_hdr_mrg_rxbuf *)(uintptr_t)hdr_addr;
- rte_prefetch0((void *)(uintptr_t)hdr_addr);
VHOST_LOG_DEBUG(VHOST_DATA, "(%d) RX: num merge buffers %d\n",
dev->vid, num_buffers);
@@ -436,8 +438,10 @@ copy_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,
buf_iova = buf_vec[vec_idx].buf_iova;
buf_len = buf_vec[vec_idx].buf_len;
- /* Prefetch buffer address. */
- rte_prefetch0((void *)(uintptr_t)buf_addr);
+ /* Prefetch next buffer address. */
+ if (vec_idx + 1 < nr_vec)
+ rte_prefetch0((void *)(uintptr_t)
+ buf_vec[vec_idx + 1].buf_addr);
buf_offset = 0;
buf_avail = buf_len;
}
@@ -579,6 +583,8 @@ virtio_dev_rx(struct virtio_net *dev, uint16_t queue_id,
break;
}
+ rte_prefetch0((void *)(uintptr_t)buf_vec[0].buf_addr);
+
VHOST_LOG_DEBUG(VHOST_DATA, "(%d) current index %d | end index %d\n",
dev->vid, vq->last_avail_idx,
vq->last_avail_idx + num_buffers);
--
2.14.4
next prev parent reply other threads:[~2018-07-06 7:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 7:04 [dpdk-dev] [PATCH v4 0/5] vhost: generalize buffer vectors Maxime Coquelin
2018-07-06 7:04 ` [dpdk-dev] [PATCH v4 1/5] vhost: use shadow used ring in dequeue path Maxime Coquelin
2018-07-06 7:59 ` Maxime Coquelin
2018-07-06 7:04 ` [dpdk-dev] [PATCH v4 2/5] vhost: use buffer vectors " Maxime Coquelin
[not found] ` <2DBBFF226F7CF64BAFCA79B681719D953A4EB9E3@SHSMSX101.ccr.corp.intel.com>
[not found] ` <E0CBA5A1980F1F408E1F28F9991B5B1D50D03E40@SHSMSX104.ccr.corp.intel.com>
2018-07-17 7:17 ` Wang, Yinan
2018-07-06 7:04 ` [dpdk-dev] [PATCH v4 3/5] vhost: improve prefetching " Maxime Coquelin
2018-07-06 7:04 ` [dpdk-dev] [PATCH v4 4/5] vhost: prefetch first descriptor " Maxime Coquelin
2018-07-06 7:04 ` Maxime Coquelin [this message]
2018-07-09 1:39 ` [dpdk-dev] [PATCH v4 0/5] vhost: generalize buffer vectors Tiwei Bie
2018-07-09 7:01 ` Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706070449.1946-6-maxime.coquelin@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).