From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 438E71BDDE for ; Fri, 6 Jul 2018 12:13:57 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jul 2018 03:13:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,315,1526367600"; d="scan'208";a="213886320" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga004.jf.intel.com with SMTP; 06 Jul 2018 03:13:54 -0700 Received: by (sSMTP sendmail emulation); Fri, 06 Jul 2018 11:13:53 +0100 Date: Fri, 6 Jul 2018 11:13:53 +0100 From: Bruce Richardson To: Alex Kiselev Cc: "dev@dpdk.org" Message-ID: <20180706101352.GA6220@bricha3-MOBL.ger.corp.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.0 (2018-05-17) Subject: Re: [dpdk-dev] [PATCH v2] librte_lpm: Improve performance of the delete and add functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 10:13:57 -0000 On Mon, Jul 02, 2018 at 07:42:11PM +0300, Alex Kiselev wrote: > There are two major problems with the library: > first, there is no need to rebuild the whole LPM tree > when a rule is deleted and second, due to the current > rules algorithm with complexity O(n) it's almost > impossible to deal with large rule sets (50k or so rules). > This patch addresses those two issues. > > Signed-off-by: Alex Kiselev > --- > lib/librte_lpm/rte_lpm6.c | 1073 ++++++++++++++++++++++++++++++++++----------- > 1 file changed, 816 insertions(+), 257 deletions(-) > I get a compiler error with gcc8 after this patch: /home/bruce/dpdk.org/lib/librte_lpm/rte_lpm6.c: In function ‘rte_lpm6_add_v1705’: /home/bruce/dpdk.org/lib/librte_lpm/rte_lpm6.c:748:18: error: ‘tbl_next_num’ may be used uninitialized in this function [-Werror=maybe-uninitialized] lpm->tbl8_hdrs[tbl_ind].ref_cnt++; ^ "check-git-log.sh" and "checkpatches.sh" are also reporting issues with this patch. Please check these too. Some code review comments to follow. Regards, /Bruce