From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 0E9C11B1EF for ; Mon, 9 Jul 2018 15:09:27 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id q10-v6so10933152wrd.4 for ; Mon, 09 Jul 2018 06:09:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to:openpgp :user-agent; bh=6jxJ2w2u0IpHrfwK2Wtyi7V52PdMbL7mfoxMDXNrNdQ=; b=ZiwcCsK8Csr6G22VfdvYFQhQqWiahNYRsG2aNxtBpKT7MqpzeBtMt8QGdh/t7ztBoI fsHVAkS4xByuBEtOgeON6Ff3pU+UuZhTjPXmVGMlIiTUHR+JiYpUPy69cryE5AF4IZio 4ARFrKqKMhfCk+m3vpxBLP1KZTOxXlnsjGTrfl8yiqEH79sLAX1M7rKxcBB5wFFUBtCe kaTrF2XowH2XObZ+uXIIAZeRq+6BQ9fdf0TYjqk4iGTttGF4gY9Se+vvcX0qP6wriH/l x7s8wxQIuBlM+qvdq6ULa8Ypd1h3ST4W4BAJ5H529vkksCpQ3t5ckSHELMIAMke+2tHq jT5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:openpgp:user-agent; bh=6jxJ2w2u0IpHrfwK2Wtyi7V52PdMbL7mfoxMDXNrNdQ=; b=EES9vUxsuht5y46am2kW+/KNLTEhtAOcW1JWaSgMlztiKELWCTZAWziMiA9/fN0FuE UeomflUFXW6RTtm3qYVmC0fZ34MGF8M6BNUR2PF5fRxblvoQFbkhLt/OLpjDI3bhjN1C hbt4i7Qhdh+T4C2XRW3wqp+HLfuyK5n+svqA/jH/LATiZH7v5tibqKlYL3sHzrDlH0y+ 36YE8mR1UZqXz2pa23PNP+rEzoP/ngwqNAawW6yD1KmYThc+iW8a1QgS1Xo743lf5wAM vkx0ByDEoJ3UWevzKWWIvZTVraUxZ6z+VOOgXSYsyJs47EA1UKqndjEqfOhzqtS/POWy Eoxw== X-Gm-Message-State: APt69E17jVrV0wKMW9KhHYtnVO48Dm7gEuIefT9+wIbSEBiCCDK5hdYW HLykw16HMQJbGjCD8W59C3yj X-Google-Smtp-Source: AAOMgpf/a+uPbkb/APQgXyNuGbr5jLEwuWHZirMfmjZxElRjtiAjMCpMJDMjYT8rHKvVr9QMYE4n2g== X-Received: by 2002:adf:8712:: with SMTP id a18-v6mr15852838wra.178.1531141766821; Mon, 09 Jul 2018 06:09:26 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id u135-v6sm2235485wmf.2.2018.07.09.06.09.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Jul 2018 06:09:26 -0700 (PDT) Date: Mon, 9 Jul 2018 15:09:10 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Yongseok Koh Cc: "dev@dpdk.org" , Adrien Mazarguil Message-ID: <20180709130910.dzuhsbtynnxpji5c@laranjeiro-vm.dev.6wind.com> References: <20180706021630.GB47821@yongseok-MBP.local> <20180706155907.x7geq7jxmbzs76im@laranjeiro-vm.dev.6wind.com> <143310F7-24FB-419C-BDB3-C21C9978DA7F@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <143310F7-24FB-419C-BDB3-C21C9978DA7F@mellanox.com> OpenPGP: id=A0075DA8F66A5949 preference=signencrypt User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 13/20] net/mlx5: add RSS flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2018 13:09:27 -0000 On Fri, Jul 06, 2018 at 05:35:22PM +0000, Yongseok Koh wrote: > > > On Jul 6, 2018, at 8:59 AM, Nélio Laranjeiro wrote: > > > > Hi Yongseok, > > > > I am only addressing your questions concerns here, almost all other > > points I also agree with them. > > > > On Thu, Jul 05, 2018 at 07:16:35PM -0700, Yongseok Koh wrote: > >> On Wed, Jun 27, 2018 at 05:07:45PM +0200, Nelio Laranjeiro wrote: > >>> Signed-off-by: Nelio Laranjeiro > >>> --- > >> [...] > >> > >>> + */ > >>> +static void > >>> +mlx5_flow_layers_update(struct rte_flow *flow, uint32_t layers) > >>> +{ > >>> + if (flow->expand) { > >>> + if (flow->cur_verbs) > >>> + flow->cur_verbs->layers |= layers; > >> > >> If flow->cur_verbs is null, does that mean it is a testing call? Then, is it > >> unnecessary to update layers for the testing call? Confusing.. > > > > No it may also happen if the buffer was too small, in any case the code > > continues its validation. > > Okay, understand. Thanks. > But another question was, if it is a testing call (flow->cur_verbs is null) with > flow->expand being set, then no 'layers' isn't updated in this code. Is it okay? yes it was ok, after I've fixed the issue in the layers themselves, again no layer position was done when the expanded was enabled. Thanks, -- Nélio Laranjeiro 6WIND