DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dariusz Stojaczyk <darek.stojaczyk@gmail.com>
To: dev@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>,
	Olivier Matz <olivier.matz@6wind.com>,
	stable@dpdk.org
Cc: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Subject: [dpdk-dev] [PATCH v2 1/3] eal/thread: ignore rte_thread_setname() failure in ctrl thread
Date: Tue, 10 Jul 2018 12:44:45 +0200	[thread overview]
Message-ID: <20180710104447.16756-1-darek.stojaczyk@gmail.com> (raw)
In-Reply-To: <1528461427-164113-1-git-send-email-dariuszx.stojaczyk@intel.com>

From: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>

The error is not fatal and we can physically continue
creating the thread. It simply won't have a name.

If rte_thread_setname() fails, we will just print
a debug log now. EAL does the same for lcore threads.

Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
---
 lib/librte_eal/common/eal_common_thread.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c
index 42398630a..8110ac2ae 100644
--- a/lib/librte_eal/common/eal_common_thread.c
+++ b/lib/librte_eal/common/eal_common_thread.c
@@ -191,7 +191,8 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
 	if (name != NULL) {
 		ret = rte_thread_setname(*thread, name);
 		if (ret < 0)
-			goto fail;
+			RTE_LOG(DEBUG, EAL,
+				"Cannot set name for ctrl thread\n");
 	}
 
 	cpu_found = 0;
-- 
2.11.0

  parent reply	other threads:[~2018-07-10 10:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08 12:37 [dpdk-dev] [PATCH 1/2] eal/thread: fix return codes for rte_thread_setname() Dariusz Stojaczyk
2018-06-08  9:02 ` Stojaczyk, DariuszX
2018-06-08 12:37 ` [dpdk-dev] [PATCH 2/2] eal/thread: fix return codes for rte_ctrl_thread_create() Dariusz Stojaczyk
2018-06-18 10:01   ` Burakov, Anatoly
2018-06-25 14:40     ` Olivier Matz
2018-06-18 10:00 ` [dpdk-dev] [PATCH 1/2] eal/thread: fix return codes for rte_thread_setname() Burakov, Anatoly
2018-06-25 14:35   ` Olivier Matz
2018-06-25 16:58     ` Stojaczyk, DariuszX
2018-07-10 10:44 ` Dariusz Stojaczyk [this message]
2018-07-10 10:44   ` [dpdk-dev] [PATCH v2 2/3] " Dariusz Stojaczyk
2018-07-10 10:44   ` [dpdk-dev] [PATCH v2 3/3] eal/thread: fix return codes for rte_ctrl_thread_create() Dariusz Stojaczyk
2018-07-12 22:19   ` [dpdk-dev] [dpdk-stable] [PATCH v2 1/3] eal/thread: ignore rte_thread_setname() failure in ctrl thread Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180710104447.16756-1-darek.stojaczyk@gmail.com \
    --to=darek.stojaczyk@gmail.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dariuszx.stojaczyk@intel.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).