From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f42.google.com (mail-lf0-f42.google.com [209.85.215.42]) by dpdk.org (Postfix) with ESMTP id 849481B47C; Tue, 10 Jul 2018 12:46:40 +0200 (CEST) Received: by mail-lf0-f42.google.com with SMTP id f18-v6so1775317lfc.2; Tue, 10 Jul 2018 03:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AcO3oDIsvA9BRy9ZNjuKpPvw3/NwcgZ6y4MJH3+Eo2c=; b=l62u/zN+PuohLsvC1o145glUFoIs74twINm4HgH43FZIJptTOFeGhFfY77xBUTyyzb P5hVjtKb5X+2Nzwe8JvdW0kFeNNcynIEb+qtNLs7IWlFFYTwzy8AhaULPeyDPYBU+7Xx KfAX7tR4OckvEB3CtUNBSZ4YITQr2s6hGWwy1xyYjnwZGwvfWZRzqmfXUp1NZTeCuOAb QtGZ3cejq13hhR9pxKRMAYECf+/uiOgZjbwwqPWmtGWcpehBTTAvgxJ2ky0WXfTBoBmG rgJLY9/Jm940GUE423YfO6i7UTx5s7wn0eR9dfUVz6Ir0RPby3oiJMDYQUSbIRmtNX2W qlHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AcO3oDIsvA9BRy9ZNjuKpPvw3/NwcgZ6y4MJH3+Eo2c=; b=AmuB0Qu3+NiL8ixEl6/aNhb3iymH76xiuJLX9WfJ6ts6QJSliWGUoeYpl1ln0g8pAZ 0F1UowGbY5mGKXmoAJqzDEpyg1O9VXaRuvxJsp3Zi3xDsWB9fVbNxXRSv2iIq9ckpNNW 8bI/lkCn065pAx10MkU+lGrfvMC8/mVG9p8zrKbcuIDod2QcDuT7ARpYBesSss46NsBr V5//97Hpu5GgvcZdpHjjd7NAaYIbi/MfU9mLsrrsUnEWIFzbm47hUWTLsGin+PinmyrD U7WLqLbOmKZ7yN6qM2NXDBqbEX7ZEKIMRa9+J2AymKpKsMtS3CFsrhhyje0Gqd1UcMht pPXQ== X-Gm-Message-State: APt69E2M6BWAZy3Ui7lXQSwPxJLW6w9Jg5tmDMDhkCnd60fO8deufJhr JJHoRwyfYZyFDocIrD9C7h3MiQ== X-Google-Smtp-Source: AAOMgpdwx9etvBn6xDHJRcy8EjWusbpsnzinz6KxuUy2fbi5APSosQs6vzRzFtU+w0SnUzpkdwhbEg== X-Received: by 2002:a19:e9d7:: with SMTP id j84-v6mr2527437lfk.115.1531219599169; Tue, 10 Jul 2018 03:46:39 -0700 (PDT) Received: from localhost.localdomain (89-68-114-161.dynamic.chello.pl. [89.68.114.161]) by smtp.gmail.com with ESMTPSA id q4-v6sm4591320lfj.81.2018.07.10.03.46.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Jul 2018 03:46:38 -0700 (PDT) From: Dariusz Stojaczyk To: dev@dpdk.org, Anatoly Burakov , Olivier Matz , stable@dpdk.org Cc: Dariusz Stojaczyk Date: Tue, 10 Jul 2018 12:44:45 +0200 Message-Id: <20180710104447.16756-1-darek.stojaczyk@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <1528461427-164113-1-git-send-email-dariuszx.stojaczyk@intel.com> References: <1528461427-164113-1-git-send-email-dariuszx.stojaczyk@intel.com> Subject: [dpdk-dev] [PATCH v2 1/3] eal/thread: ignore rte_thread_setname() failure in ctrl thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2018 10:46:40 -0000 From: Dariusz Stojaczyk The error is not fatal and we can physically continue creating the thread. It simply won't have a name. If rte_thread_setname() fails, we will just print a debug log now. EAL does the same for lcore threads. Signed-off-by: Dariusz Stojaczyk Acked-by: Anatoly Burakov Reviewed-by: Olivier Matz --- lib/librte_eal/common/eal_common_thread.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c index 42398630a..8110ac2ae 100644 --- a/lib/librte_eal/common/eal_common_thread.c +++ b/lib/librte_eal/common/eal_common_thread.c @@ -191,7 +191,8 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name, if (name != NULL) { ret = rte_thread_setname(*thread, name); if (ret < 0) - goto fail; + RTE_LOG(DEBUG, EAL, + "Cannot set name for ctrl thread\n"); } cpu_found = 0; -- 2.11.0