DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dariusz Stojaczyk <darek.stojaczyk@gmail.com>
To: dev@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>,
	Olivier Matz <olivier.matz@6wind.com>,
	stable@dpdk.org
Cc: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Subject: [dpdk-dev] [PATCH v2 3/3] eal/thread: fix return codes for rte_ctrl_thread_create()
Date: Tue, 10 Jul 2018 12:44:47 +0200	[thread overview]
Message-ID: <20180710104447.16756-3-darek.stojaczyk@gmail.com> (raw)
In-Reply-To: <20180710104447.16756-1-darek.stojaczyk@gmail.com>

From: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>

This function returned positive error numbers instead
of negative ones as desbribed in the doc. What's worse,
multiple of its callers only check for (rc < 0) to detect
failure.

It was incorrectly assumed that pthread_create
and pthread_setaffinity_np return negative errnos. They
always returns positive ones, so this patch negates their
return values before returning.

Fixes: 9e5afc72c909 ("eal: add function to create control threads")
Cc: olivier.matz@6wind.com
Cc: stable@dpdk.org

Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
---
 lib/librte_eal/common/eal_common_thread.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c
index 8110ac2ae..48ef4d6de 100644
--- a/lib/librte_eal/common/eal_common_thread.c
+++ b/lib/librte_eal/common/eal_common_thread.c
@@ -175,7 +175,7 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
 
 	params = malloc(sizeof(*params));
 	if (!params)
-		return -1;
+		return -ENOMEM;
 
 	params->start_routine = start_routine;
 	params->arg = arg;
@@ -185,7 +185,7 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
 	ret = pthread_create(thread, attr, rte_thread_init, (void *)params);
 	if (ret != 0) {
 		free(params);
-		return ret;
+		return -ret;
 	}
 
 	if (name != NULL) {
@@ -228,5 +228,5 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
 	}
 	pthread_cancel(*thread);
 	pthread_join(*thread, NULL);
-	return ret;
+	return -ret;
 }
-- 
2.11.0

  parent reply	other threads:[~2018-07-10 10:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08 12:37 [dpdk-dev] [PATCH 1/2] eal/thread: fix return codes for rte_thread_setname() Dariusz Stojaczyk
2018-06-08  9:02 ` Stojaczyk, DariuszX
2018-06-08 12:37 ` [dpdk-dev] [PATCH 2/2] eal/thread: fix return codes for rte_ctrl_thread_create() Dariusz Stojaczyk
2018-06-18 10:01   ` Burakov, Anatoly
2018-06-25 14:40     ` Olivier Matz
2018-06-18 10:00 ` [dpdk-dev] [PATCH 1/2] eal/thread: fix return codes for rte_thread_setname() Burakov, Anatoly
2018-06-25 14:35   ` Olivier Matz
2018-06-25 16:58     ` Stojaczyk, DariuszX
2018-07-10 10:44 ` [dpdk-dev] [PATCH v2 1/3] eal/thread: ignore rte_thread_setname() failure in ctrl thread Dariusz Stojaczyk
2018-07-10 10:44   ` [dpdk-dev] [PATCH v2 2/3] eal/thread: fix return codes for rte_thread_setname() Dariusz Stojaczyk
2018-07-10 10:44   ` Dariusz Stojaczyk [this message]
2018-07-12 22:19   ` [dpdk-dev] [dpdk-stable] [PATCH v2 1/3] eal/thread: ignore rte_thread_setname() failure in ctrl thread Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180710104447.16756-3-darek.stojaczyk@gmail.com \
    --to=darek.stojaczyk@gmail.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dariuszx.stojaczyk@intel.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).