[dpdk-dev] [BUG] mlx5 build failure on Debian testing

[dpdk-dev] [BUG] mlx5 build failure on Debian testing

[Stephen Hemminger]

I am seeing a build failure of MLX5 driver on Debian testing (buster)
with dpdk.org master branch.

This is using libibverbs-dev version 19.0-1

The failure is:
mlx5_glue.h:94:11: error: ‘struct ibv_counter_set_init_attr’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
    struct ibv_counter_set_init_attr *init_attr);
           ^~~~~~~~~~~~~~~~~~~~~~~~~

It looks like this is being caused because HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT is not set, but
the header file does not have the counter stuff.

The Makefile is generating this mlx5 autoconf file by looking for "enum IBV_FLOW_SPEC_ACTION_COUNT"
in /usr/include/infiniband/verbs.h.  This enum is present, but counters are not.

$ grep IBV_FLOW_SPEC_ACTION /usr/include/infiniband/verbs.h 
	IBV_FLOW_SPEC_ACTION_TAG	= 0x1000,
	IBV_FLOW_SPEC_ACTION_DROP	= 0x1001,
	IBV_FLOW_SPEC_ACTION_HANDLE	= 0x1002,
	IBV_FLOW_SPEC_ACTION_COUNT	= 0x1003,

Re: [dpdk-dev] [BUG] mlx5 build failure on Debian testing

[Shahaf Shuler]

Hi Stephen,

Thursday, July 12, 2018 12:08 AM, Stephen Hemminger:
> Subject: [BUG] mlx5 build failure on Debian testing
> 
> I am seeing a build failure of MLX5 driver on Debian testing (buster) with
> dpdk.org master branch.
> 
> This is using libibverbs-dev version 19.0-1
> 
> The failure is:
> mlx5_glue.h:94:11: error: ‘struct ibv_counter_set_init_attr’ declared inside
> parameter list will not be visible outside of this definition or declaration [-
> Werror]
>     struct ibv_counter_set_init_attr *init_attr);
>            ^~~~~~~~~~~~~~~~~~~~~~~~~
> 
> It looks like this is being caused because
> HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT is not set, but the header file
> does not have the counter stuff.
> 
> The Makefile is generating this mlx5 autoconf file by looking for "enum
> IBV_FLOW_SPEC_ACTION_COUNT"
> in /usr/include/infiniband/verbs.h.  This enum is present, but counters are
> not.
> 
> $ grep IBV_FLOW_SPEC_ACTION /usr/include/infiniband/verbs.h
> 	IBV_FLOW_SPEC_ACTION_TAG	= 0x1000,
> 	IBV_FLOW_SPEC_ACTION_DROP	= 0x1001,
> 	IBV_FLOW_SPEC_ACTION_HANDLE	= 0x1002,
> 	IBV_FLOW_SPEC_ACTION_COUNT	= 0x1003,

Thanks for reporting, this was also raised by Ferruh.
We will fix this issue. The fix is pending series [1] as it changes the entire flow engine.

[1]
https://patches.dpdk.org/project/dpdk/list/?series=512