From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 9C6CB1B475 for ; Thu, 12 Jul 2018 09:41:43 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id b15-v6so20632030wrv.10 for ; Thu, 12 Jul 2018 00:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=i26qwa57E7lMWktBX140hQPWe3pe4lsiOhx/vlPjvnk=; b=0Z1TQZPFxCxjcxYc9LPKLdfqhh1TOW2FcyCAGlFHlpqTBKkBnJl344PRgg+JpeaXvu yykpvVzf9+JJAA95XNW8R84wlomiWm6bsp9X0b9OZ9uqUyODcKgl8OnNUwarjW2nj2l9 0moih/Jqj9QzhRNm/EGOxTlK15TuOuPcSgGT4HcbZ+kfB8Jh5cpbnKoG1hG6KEqIgwKL 6828MUgcmBKepN91WIaQliPJUXW807IiM6lyCVPuKnhkgkizozHZ6J3tv9RpsCjE4z1x yFVzkslJN4wAv4z+HxsJqDn3mODQROXYFBPiZ8IzakUq2pwHpppfuvmMhgPh/SDQ1d10 AvRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=i26qwa57E7lMWktBX140hQPWe3pe4lsiOhx/vlPjvnk=; b=G2J8rFVoQldwamwxWncUqSn8fvBErKfpxFiXqFf1JoXrA7satWsEaU84WzrbYAHZqy x5mn1J1Fyt2AgdDXz9dcViPX1PvLbkdE0y8Vx9FplR1GNxo3Tn5MxQUfw4IQZ1eywKd4 h+juZt7NAf7v0VdBKRG/guO498OxN5waX1Upq9XVz9P/6Lm6wrO199ykMf5Qr4mK3h3Z XwB1KmkbHKNCHh9NWdFzxZHC2zwOXfwNP/fOKmlh44Q6acPOXl0olMDgVP5gj3z2t2kk BhnCD8kc8myGT0qjcgjc01lV4W3L0xonp9OY11XK59EFqzCtDP16pjws6udNy2GsrVzr JDpg== X-Gm-Message-State: AOUpUlGYjyMZbl1DT/SeLO1jiRpcK+xGToK7SbI/id70Cz0A8d4HCf60 mGveKj0u3e6LDR2yW3Gkg/7Lq+90 X-Google-Smtp-Source: AAOMgpeA8Mp+O6Bwf4WJ1gzMeENxlJjuZ5sSG4qeelqc7UGrP9LHk2P5paLLmDjNjGUH5t7lpPzNNw== X-Received: by 2002:adf:9bc9:: with SMTP id e9-v6mr893215wrc.240.1531381302956; Thu, 12 Jul 2018 00:41:42 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id s12-v6sm28092202wrf.0.2018.07.12.00.41.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Jul 2018 00:41:42 -0700 (PDT) Date: Thu, 12 Jul 2018 09:41:25 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Shreyansh Jain Cc: dev@dpdk.org Message-ID: <20180712074125.hfio7uffddoitui5@bidouze.vm.6wind.com> References: <2ebad882d26ce9964b313428d5c07fe83acc880a.1531345404.git.gaetan.rivet@6wind.com> <19f9132f-cbaf-5ac5-8159-1f86e478b9f6@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <19f9132f-cbaf-5ac5-8159-1f86e478b9f6@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v11 07/25] eal: introduce device class abstraction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 07:41:43 -0000 On Thu, Jul 12, 2018 at 12:19:09PM +0530, Shreyansh Jain wrote: > On Thursday 12 July 2018 03:14 AM, Gaetan Rivet wrote: > > This abstraction exists since the infancy of DPDK. > > It needs to be fleshed out however, to allow a generic > > description of devices properties and capabilities. > > > > A device class is the northbound interface of the device, intended > > for applications to know what it can be used for. > > > > It is conceptually just above buses. > > > > Signed-off-by: Gaetan Rivet > > --- > > [...] > > > --- a/lib/librte_eal/rte_eal_version.map > > +++ b/lib/librte_eal/rte_eal_version.map > > @@ -244,6 +244,8 @@ DPDK_18.05 { > > EXPERIMENTAL { > > global: > > + rte_class_register; > > + rte_class_unregister; > > rte_ctrl_thread_create; > > rte_dev_event_callback_register; > > rte_dev_event_callback_unregister; > > > > Any reason you don't want the rte_class_find and rte_class_find_by_name as > exposed APIs? There is no experimental tag on these APIs either. > No actually I just overlooked that part! Thanks for catching this, I think it should be exposed and tagged experimental. -- Gaëtan Rivet 6WIND