From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com
 [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id E345F1B3A0
 for <dev@dpdk.org>; Fri, 13 Jul 2018 00:18:14 +0200 (CEST)
Received: by mail-pf0-f196.google.com with SMTP id i26-v6so9974606pfo.12
 for <dev@dpdk.org>; Thu, 12 Jul 2018 15:18:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=nqIi11F9t5zGh1y5F+aUHHhsvvt3Mgj/TF6oYwIzlfY=;
 b=vDIqYqXBg18IISVnHiTBBRDaORsgnAvhc4ge2+ZPveCpfyUC7i7u4LqL2Gy4SS8Y05
 BZWiC56ASKxI5Lh/qEqkPNoZKXBjdAg0ZKm/K1lS6fHKVWYMmgjQ9i9LgzIvYUDXkmbX
 lh1Wo0Kvn2NbPvLA5Et46APfwFK/EbRdj+dYmWw+whkoDnq/3me6IOGoYN22ocmS6+Zu
 BsGDMCNg5y3HZRyn+/k76jt/665hbJ3B3D0KlALGvK7zZocHEabVULRrhc4NBSF+CI6Y
 9mOmfMS508Be3MY3BIa41WrC6CrJUPlBLWdiQsSZvxQXLyGEuI/AjWdNUq/qlcXOzYze
 EmVQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=nqIi11F9t5zGh1y5F+aUHHhsvvt3Mgj/TF6oYwIzlfY=;
 b=b3Tr5byzZiTNurJI4hfovJvVBYnjZsxPgyB5cPBGbwLoQqyVDnikvckXt8G2f1Dbqn
 hb5JNlXttq1XOQWSLUGaHs/O/yAxIf3XAxXUThsA0z+fLIi9Juzl5ZJpZXDnca8impon
 vgZg/f5LcVbx9XEwiedrDHz21MTH2nyK6SWUmDTt86I6oL2oT3Jysu1p/Oas2vtibRix
 j1adXG0PC66aqL5/o28zPAhSv8FnId62i454qixu7xbdcQ4kT9J+gzsl1heky01NWJND
 6E1n2POfmWsKnAOHmpbhgRuzNK9ehKeHSP7FiXuCyUzaPlPCfi82GoES7+nxT4uoXcAf
 lJLA==
X-Gm-Message-State: AOUpUlH8nAK68F04iC785ACiwhK36zEJ3A1RR9EnhYUGlZXMGYhnHUig
 bZk6mkywyUKwoku5lqw0KTnT8g==
X-Google-Smtp-Source: AAOMgpex3Y+bY6KjeDCdaaPGur+nqMbsboaf9xIvezug9BWSSCzAhbgByIojW45XOOleR3pYlc0WYg==
X-Received: by 2002:a65:420d:: with SMTP id
 c13-v6mr3652650pgq.265.1531433894021; 
 Thu, 12 Jul 2018 15:18:14 -0700 (PDT)
Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id b73-v6sm29480549pfl.152.2018.07.12.15.18.13
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Thu, 12 Jul 2018 15:18:13 -0700 (PDT)
Date: Thu, 12 Jul 2018 15:18:11 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: David Hunt <david.hunt@intel.com>, dev@dpdk.org
Message-ID: <20180712151811.2c9482ea@xeon-e3>
In-Reply-To: <6993574.EjTxxvdgkU@xps>
References: <20180621132414.39047-2-david.hunt@intel.com>
 <20180626092317.11031-1-david.hunt@intel.com>
 <20180626092317.11031-4-david.hunt@intel.com>
 <6993574.EjTxxvdgkU@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 3/9] examples/vm_power: add oob monitoring
 functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jul 2018 22:18:15 -0000

On Thu, 12 Jul 2018 21:13:26 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> 26/06/2018 11:23, David Hunt:
> > +#include <unistd.h>
> > +#include <stdio.h>
> > +#include <stdlib.h>
> > +#include <stdint.h>
> > +#include <signal.h>
> > +#include <errno.h>
> > +#include <string.h>
> > +#include <sys/types.h>
> > +#include <sys/epoll.h>
> > +#include <sys/queue.h>
> > +#include <sys/time.h>
> > +#include <fcntl.h>
> > +
> > +#include <rte_log.h>
> > +#include <rte_memory.h>
> > +#include <rte_malloc.h>
> > +#include <rte_atomic.h>
> > +#include <rte_cycles.h>
> > +#include <rte_ethdev.h>
> > +#include <rte_pmd_i40e.h>
> > +
> > +#include <libvirt/libvirt.h>
> > +#include "oob_monitor.h"
> > +#include "power_manager.h"
> > +#include "channel_manager.h"
> > +
> > +#include <rte_log.h>
> > +#define RTE_LOGTYPE_CHANNEL_MONITOR RTE_LOGTYPE_USER1  
> 
> I'm sure you don't need all these headers.
> rte_log.h is included twice.
> rte_pmd_i40e is more than suspicious...
> 
> This is a hint that the whole file was probably written too fast :)
> 

This tool can help
  https://include-what-you-use.org/