DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
To: fiona.trahe@intel.com, tomaszx.jozwiak@intel.com,
	john.griffin@intel.com, deepak.k.jain@intel.com
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v7 06/16] compress/qat: check that correct firmware is in use
Date: Fri, 13 Jul 2018 03:28:15 +0100	[thread overview]
Message-ID: <20180713022825.33106-7-pablo.de.lara.guarch@intel.com> (raw)
In-Reply-To: <20180713022825.33106-1-pablo.de.lara.guarch@intel.com>

From: Fiona Trahe <fiona.trahe@intel.com>

Check bit in response message to verify that correct firmware
is in use for compression. If not return an error.

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
---
 drivers/compress/qat/qat_comp.c | 16 +++++++++++++++-
 drivers/compress/qat/qat_comp.h |  2 ++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c
index a32d6ef1d..e8019ebc8 100644
--- a/drivers/compress/qat/qat_comp.c
+++ b/drivers/compress/qat/qat_comp.c
@@ -2,7 +2,6 @@
  * Copyright(c) 2018 Intel Corporation
  */
 
-
 #include <rte_mempool.h>
 #include <rte_mbuf.h>
 #include <rte_hexdump.h>
@@ -79,6 +78,8 @@ qat_comp_process_response(void **op, uint8_t *resp)
 			(struct icp_qat_fw_comp_resp *)resp;
 	struct rte_comp_op *rx_op = (struct rte_comp_op *)(uintptr_t)
 			(resp_msg->opaque_data);
+	struct qat_comp_xform *qat_xform = (struct qat_comp_xform *)
+				(rx_op->private_xform);
 
 #if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
 	QAT_DP_LOG(DEBUG, "Direction: %s",
@@ -88,6 +89,19 @@ qat_comp_process_response(void **op, uint8_t *resp)
 			sizeof(struct icp_qat_fw_comp_resp));
 #endif
 
+	if (likely(qat_xform->qat_comp_request_type
+			!= QAT_COMP_REQUEST_DECOMPRESS)) {
+		if (unlikely(ICP_QAT_FW_COMN_HDR_CNV_FLAG_GET(
+				resp_msg->comn_resp.hdr_flags)
+					== ICP_QAT_FW_COMP_NO_CNV)) {
+			rx_op->status = RTE_COMP_OP_STATUS_ERROR;
+			rx_op->debug_status = ERR_CODE_QAT_COMP_WRONG_FW;
+			*op = (void *)rx_op;
+			QAT_DP_LOG(ERR, "QAT has wrong firmware");
+			return 0;
+		}
+	}
+
 	if ((ICP_QAT_FW_COMN_RESP_CMP_STAT_GET(resp_msg->comn_resp.comn_status)
 		| ICP_QAT_FW_COMN_RESP_XLAT_STAT_GET(
 				resp_msg->comn_resp.comn_status)) !=
diff --git a/drivers/compress/qat/qat_comp.h b/drivers/compress/qat/qat_comp.h
index 46105b40d..937f3c83e 100644
--- a/drivers/compress/qat/qat_comp.h
+++ b/drivers/compress/qat/qat_comp.h
@@ -15,6 +15,8 @@
 #include "icp_qat_fw_comp.h"
 #include "icp_qat_fw_la.h"
 
+#define ERR_CODE_QAT_COMP_WRONG_FW -99
+
 enum qat_comp_request_type {
 	QAT_COMP_REQUEST_FIXED_COMP_STATELESS,
 	QAT_COMP_REQUEST_DYNAMIC_COMP_STATELESS,
-- 
2.14.4

  parent reply	other threads:[~2018-07-13 10:34 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23 18:40 [dpdk-dev] [PATCH] compress/qat: add compression PMD Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 00/16] " Fiona Trahe
2018-07-05 17:32   ` [dpdk-dev] [PATCH v3 " Fiona Trahe
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 " Fiona Trahe
2018-07-11 11:56       ` [dpdk-dev] [PATCH v5 " Fiona Trahe
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 " Fiona Trahe
2018-07-13  2:28           ` [dpdk-dev] [PATCH v7 " Pablo de Lara
2018-07-13  2:28             ` [dpdk-dev] [PATCH v7 01/16] common/qat: updated firmware headers Pablo de Lara
2018-07-13  2:28             ` [dpdk-dev] [PATCH v7 02/16] compress/qat: add makefiles for PMD Pablo de Lara
2018-07-13  2:28             ` [dpdk-dev] [PATCH v7 03/16] compress/qat: add meson build Pablo de Lara
2018-07-13  2:28             ` [dpdk-dev] [PATCH v7 04/16] compress/qat: add xform processing Pablo de Lara
2018-07-13  2:28             ` [dpdk-dev] [PATCH v7 05/16] compress/qat: create FW request and process response Pablo de Lara
2018-07-13  2:28             ` Pablo de Lara [this message]
2018-07-13  2:28             ` [dpdk-dev] [PATCH v7 07/16] compress/qat: add stats functions Pablo de Lara
2018-07-13  2:28             ` [dpdk-dev] [PATCH v7 08/16] compress/qat: setup queue-pairs for compression service Pablo de Lara
2018-07-13  2:28             ` [dpdk-dev] [PATCH v7 09/16] compress/qat: add fns to configure and clear device Pablo de Lara
2018-07-13  2:28             ` [dpdk-dev] [PATCH v7 10/16] compress/qat: add fn to return device info Pablo de Lara
2018-07-13  2:28             ` [dpdk-dev] [PATCH v7 11/16] compress/qat: add enqueue/dequeue functions Pablo de Lara
2018-07-13  2:28             ` [dpdk-dev] [PATCH v7 12/16] compress/qat: add device start and stop fns Pablo de Lara
2018-07-13  2:28             ` [dpdk-dev] [PATCH v7 13/16] compress/qat: create and populate the ops structure Pablo de Lara
2018-07-13  2:28             ` [dpdk-dev] [PATCH v7 14/16] compress/qat: add fns to create and destroy the PMD Pablo de Lara
2018-07-13  2:28             ` [dpdk-dev] [PATCH v7 15/16] compress/qat: prevent device usage if incorrect firmware Pablo de Lara
2018-07-13  2:28             ` [dpdk-dev] [PATCH v7 16/16] doc/qat: refactor docs adding compression guide Pablo de Lara
2018-07-13 14:22             ` [dpdk-dev] [PATCH v7 00/16] compress/qat: add compression PMD De Lara Guarch, Pablo
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 01/16] common/qat: updated firmware headers Fiona Trahe
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 02/16] compress/qat: add makefiles for PMD Fiona Trahe
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 03/16] compress/qat: add meson build Fiona Trahe
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 04/16] compress/qat: add xform processing Fiona Trahe
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 05/16] compress/qat: create fw request and process response Fiona Trahe
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 06/16] compress/qat: check that correct firmware is in use Fiona Trahe
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 07/16] compress/qat: add stats functions Fiona Trahe
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 08/16] compress/qat: setup queue-pairs for compression service Fiona Trahe
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 09/16] compress/qat: add fns to configure and clear device Fiona Trahe
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 10/16] compress/qat: add fn to return device info Fiona Trahe
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 11/16] compress/qat: add enqueue/dequeue functions Fiona Trahe
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 12/16] compress/qat: add device start and stop fns Fiona Trahe
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 13/16] compress/qat: create and populate the ops structure Fiona Trahe
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 14/16] compress/qat: add fns to create and destroy the PMD Fiona Trahe
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 15/16] compress/qat: prevent device usage if incorrect firmware Fiona Trahe
2018-07-12 16:04         ` [dpdk-dev] [PATCH v6 16/16] docs/qat: refactor docs adding compression guide Fiona Trahe
2018-07-11 11:56       ` [dpdk-dev] [PATCH v5 01/16] common/qat: updated firmware headers Fiona Trahe
2018-07-11 11:56       ` [dpdk-dev] [PATCH v5 02/16] compress/qat: add makefiles for PMD Fiona Trahe
2018-07-12 12:41         ` De Lara Guarch, Pablo
2018-07-11 11:56       ` [dpdk-dev] [PATCH v5 03/16] compress/qat: add meson build Fiona Trahe
2018-07-11 11:56       ` [dpdk-dev] [PATCH v5 04/16] compress/qat: add xform processing Fiona Trahe
2018-07-11 11:56       ` [dpdk-dev] [PATCH v5 05/16] compress/qat: create fw request and process response Fiona Trahe
2018-07-11 11:56       ` [dpdk-dev] [PATCH v5 06/16] compress/qat: check that correct firmware is in use Fiona Trahe
2018-07-11 11:57       ` [dpdk-dev] [PATCH v5 07/16] compress/qat: add stats functions Fiona Trahe
2018-07-11 11:57       ` [dpdk-dev] [PATCH v5 08/16] compress/qat: setup queue-pairs for compression service Fiona Trahe
2018-07-11 11:57       ` [dpdk-dev] [PATCH v5 09/16] compress/qat: add fns to configure and clear device Fiona Trahe
2018-07-11 11:57       ` [dpdk-dev] [PATCH v5 10/16] compress/qat: add fn to return device info Fiona Trahe
2018-07-11 11:57       ` [dpdk-dev] [PATCH v5 11/16] compress/qat: add enqueue/dequeue functions Fiona Trahe
2018-07-11 11:57       ` [dpdk-dev] [PATCH v5 12/16] compress/qat: add device start and stop fns Fiona Trahe
2018-07-11 11:57       ` [dpdk-dev] [PATCH v5 13/16] compress/qat: create and populate the ops structure Fiona Trahe
2018-07-11 11:57       ` [dpdk-dev] [PATCH v5 14/16] compress/qat: add fns to create and destroy the PMD Fiona Trahe
2018-07-11 11:57       ` [dpdk-dev] [PATCH v5 15/16] compress/qat: prevent device usage if incorrect firmware Fiona Trahe
2018-07-11 11:57       ` [dpdk-dev] [PATCH v5 16/16] docs/qat: refactor docs adding compression guide Fiona Trahe
2018-07-12 15:56         ` De Lara Guarch, Pablo
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 01/16] common/qat: updated firmware headers Fiona Trahe
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 02/16] compress/qat: add makefiles for PMD Fiona Trahe
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 03/16] compress/qat: add meson build Fiona Trahe
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 04/16] compress/qat: add xform processing Fiona Trahe
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 05/16] compress/qat: create fw request and process response Fiona Trahe
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 06/16] compress/qat: check that correct firmware is in use Fiona Trahe
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 07/16] compress/qat: add stats functions Fiona Trahe
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 08/16] compress/qat: setup queue-pairs for compression service Fiona Trahe
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 09/16] compress/qat: add fns to configure and clear device Fiona Trahe
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 10/16] compress/qat: add fn to return device info Fiona Trahe
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 11/16] compress/qat: add enqueue/dequeue functions Fiona Trahe
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 12/16] compress/qat: add device start and stop fns Fiona Trahe
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 13/16] compress/qat: create and populate the ops structure Fiona Trahe
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 14/16] compress/qat: add fns to create and destroy the PMD Fiona Trahe
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 15/16] compress/qat: prevent device usage if incorrect firmware Fiona Trahe
2018-07-10  0:41     ` [dpdk-dev] [PATCH v4 16/16] docs/qat: refactor docs adding compression guide Fiona Trahe
2018-07-05 17:32   ` [dpdk-dev] [PATCH v3 01/16] common/qat: updated firmware headers Fiona Trahe
2018-07-05 17:32   ` [dpdk-dev] [PATCH v3 02/16] compress/qat: add makefiles for PMD Fiona Trahe
2018-07-05 17:32   ` [dpdk-dev] [PATCH v3 03/16] compress/qat: add meson build Fiona Trahe
2018-07-05 17:32   ` [dpdk-dev] [PATCH v3 04/16] compress/qat: add xform processing Fiona Trahe
2018-07-05 17:32   ` [dpdk-dev] [PATCH v3 05/16] compress/qat: create fw request and process response Fiona Trahe
2018-07-05 17:32   ` [dpdk-dev] [PATCH v3 06/16] compress/qat: check that correct firmware is in use Fiona Trahe
2018-07-05 17:32   ` [dpdk-dev] [PATCH v3 07/16] compress/qat: add stats functions Fiona Trahe
2018-07-05 17:32   ` [dpdk-dev] [PATCH v3 08/16] compress/qat: setup queue-pairs for compression service Fiona Trahe
2018-07-05 17:32   ` [dpdk-dev] [PATCH v3 09/16] compress/qat: add fns to configure and clear device Fiona Trahe
2018-07-05 17:32   ` [dpdk-dev] [PATCH v3 10/16] compress/qat: add fn to return device info Fiona Trahe
2018-07-05 17:32   ` [dpdk-dev] [PATCH v3 11/16] compress/qat: add enqueue/dequeue functions Fiona Trahe
2018-07-05 17:32   ` [dpdk-dev] [PATCH v3 12/16] compress/qat: add device start and stop fns Fiona Trahe
2018-07-05 17:32   ` [dpdk-dev] [PATCH v3 13/16] compress/qat: create and populate the ops structure Fiona Trahe
2018-07-05 17:32   ` [dpdk-dev] [PATCH v3 14/16] compress/qat: add fns to create and destroy the PMD Fiona Trahe
2018-07-05 17:32   ` [dpdk-dev] [PATCH v3 15/16] compress/qat: prevent device usage if incorrect firmware Fiona Trahe
2018-07-05 17:33   ` [dpdk-dev] [PATCH v3 16/16] docs/qat: refactor docs adding compression guide Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 01/16] common/qat: updated firmware headers Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 02/16] compress/qat: add makefiles for PMD Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 03/16] compress/qat: add meson build Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 04/16] compress/qat: add xform processing Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 05/16] compress/qat: create fw request and process response Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 06/16] compress/qat: check that correct firmware is in use Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 07/16] compress/qat: add stats functions Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 08/16] compress/qat: setup queue-pairs for compression service Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 09/16] compress/qat: add fns to configure and clear device Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 10/16] compress/qat: add fn to return device info Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 11/16] compress/qat: add enqueue/dequeue functions Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 12/16] compress/qat: add device start and stop fns Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 13/16] compress/qat: create and populate the ops structure Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 14/16] compress/qat: add fns to create and destroy the PMD Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 15/16] compress/qat: prevent device usage if incorrect firmware Fiona Trahe
2018-07-05 16:05 ` [dpdk-dev] [PATCH v2 16/16] docs/qat: refactor docs adding compression guide Fiona Trahe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180713022825.33106-7-pablo.de.lara.guarch@intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=deepak.k.jain@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=john.griffin@intel.com \
    --cc=tomaszx.jozwiak@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).