* [dpdk-dev] [PATCH] test/power: fix 32-bit build
@ 2018-07-13 4:12 Pablo de Lara
2018-07-13 4:51 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Pablo de Lara @ 2018-07-13 4:12 UTC (permalink / raw)
To: radu.nicolau, david.hunt; +Cc: dev, Pablo de Lara
Compilation issue:
test/test/test_power_acpi_cpufreq.c:556:31:
error: format ‘%lx’ expects argument of type ‘long unsigned int’,
but argument 2 has type ‘uint64_t {aka long long unsigned int}’
-Werror=format=]
printf("ACPI: Capabilities %lx\n", caps.capabilities);
~~^ ~~~~~~~~~~~~~~~~~
%llx
Fixes: 39e38d583075 ("test/power: add unit test for get capabilities API")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
test/test/test_power_acpi_cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test/test_power_acpi_cpufreq.c b/test/test/test_power_acpi_cpufreq.c
index 6410969e0..ff908e4e1 100644
--- a/test/test/test_power_acpi_cpufreq.c
+++ b/test/test/test_power_acpi_cpufreq.c
@@ -553,7 +553,7 @@ test_power_acpi_caps(void)
return -1;
}
- printf("ACPI: Capabilities %lx\n", caps.capabilities);
+ printf("ACPI: Capabilities %"PRIx64"\n", caps.capabilities);
rte_power_unset_env();
return 0;
--
2.14.4
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH v2] test/power: fix 32-bit build
2018-07-13 4:12 [dpdk-dev] [PATCH] test/power: fix 32-bit build Pablo de Lara
@ 2018-07-13 4:51 ` Pablo de Lara
2018-07-13 16:12 ` Thomas Monjalon
2018-07-13 12:36 ` [dpdk-dev] [PATCH] " Radu Nicolau
2018-07-13 12:52 ` De Lara Guarch, Pablo
2 siblings, 1 reply; 5+ messages in thread
From: Pablo de Lara @ 2018-07-13 4:51 UTC (permalink / raw)
To: radu.nicolau, david.hunt; +Cc: dev, Pablo de Lara
Compilation issue:
test/test/test_power_acpi_cpufreq.c:556:31:
error: format ‘%lx’ expects argument of type ‘long unsigned int’,
but argument 2 has type ‘uint64_t {aka long long unsigned int}’
-Werror=format=]
printf("ACPI: Capabilities %lx\n", caps.capabilities);
~~^ ~~~~~~~~~~~~~~~~~
%llx
Fixes: 39e38d583075 ("test/power: add unit test for get capabilities API")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Radu Nicolau <radu.nicolau@intel.com>
---
v2:
- Added missing include
test/test/test_power_acpi_cpufreq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/test/test/test_power_acpi_cpufreq.c b/test/test/test_power_acpi_cpufreq.c
index 6410969e0..22e541d65 100644
--- a/test/test/test_power_acpi_cpufreq.c
+++ b/test/test/test_power_acpi_cpufreq.c
@@ -7,6 +7,7 @@
#include <unistd.h>
#include <limits.h>
#include <string.h>
+#include <inttypes.h>
#include "test.h"
@@ -553,7 +554,7 @@ test_power_acpi_caps(void)
return -1;
}
- printf("ACPI: Capabilities %lx\n", caps.capabilities);
+ printf("ACPI: Capabilities %"PRIx64"\n", caps.capabilities);
rte_power_unset_env();
return 0;
--
2.14.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] test/power: fix 32-bit build
2018-07-13 4:51 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
@ 2018-07-13 16:12 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2018-07-13 16:12 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev, radu.nicolau, david.hunt
13/07/2018 06:51, Pablo de Lara:
> Compilation issue:
>
> test/test/test_power_acpi_cpufreq.c:556:31:
> error: format ‘%lx’ expects argument of type ‘long unsigned int’,
> but argument 2 has type ‘uint64_t {aka long long unsigned int}’
> -Werror=format=]
>
> printf("ACPI: Capabilities %lx\n", caps.capabilities);
> ~~^ ~~~~~~~~~~~~~~~~~
> %llx
>
> Fixes: 39e38d583075 ("test/power: add unit test for get capabilities API")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Radu Nicolau <radu.nicolau@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] test/power: fix 32-bit build
2018-07-13 4:12 [dpdk-dev] [PATCH] test/power: fix 32-bit build Pablo de Lara
2018-07-13 4:51 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
@ 2018-07-13 12:36 ` Radu Nicolau
2018-07-13 12:52 ` De Lara Guarch, Pablo
2 siblings, 0 replies; 5+ messages in thread
From: Radu Nicolau @ 2018-07-13 12:36 UTC (permalink / raw)
To: Pablo de Lara, david.hunt; +Cc: dev
On 7/13/2018 5:12 AM, Pablo de Lara wrote:
> Compilation issue:
>
> test/test/test_power_acpi_cpufreq.c:556:31:
> error: format ‘%lx’ expects argument of type ‘long unsigned int’,
> but argument 2 has type ‘uint64_t {aka long long unsigned int}’
> -Werror=format=]
>
> printf("ACPI: Capabilities %lx\n", caps.capabilities);
> ~~^ ~~~~~~~~~~~~~~~~~
> %llx
>
> Fixes: 39e38d583075 ("test/power: add unit test for get capabilities API")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>
Acked-by: Radu Nicolau <radu.nicolau@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] test/power: fix 32-bit build
2018-07-13 4:12 [dpdk-dev] [PATCH] test/power: fix 32-bit build Pablo de Lara
2018-07-13 4:51 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2018-07-13 12:36 ` [dpdk-dev] [PATCH] " Radu Nicolau
@ 2018-07-13 12:52 ` De Lara Guarch, Pablo
2 siblings, 0 replies; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2018-07-13 12:52 UTC (permalink / raw)
To: Nicolau, Radu, Hunt, David; +Cc: dev
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Friday, July 13, 2018 5:13 AM
> To: Nicolau, Radu <radu.nicolau@intel.com>; Hunt, David
> <david.hunt@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH] test/power: fix 32-bit build
>
> Compilation issue:
>
> test/test/test_power_acpi_cpufreq.c:556:31:
> error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2
> has type ‘uint64_t {aka long long unsigned int}’
> -Werror=format=]
>
> printf("ACPI: Capabilities %lx\n", caps.capabilities);
> ~~^ ~~~~~~~~~~~~~~~~~
> %llx
>
> Fixes: 39e38d583075 ("test/power: add unit test for get capabilities API")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
NACK. Missing include. Will send v2.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-13 16:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-13 4:12 [dpdk-dev] [PATCH] test/power: fix 32-bit build Pablo de Lara
2018-07-13 4:51 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2018-07-13 16:12 ` Thomas Monjalon
2018-07-13 12:36 ` [dpdk-dev] [PATCH] " Radu Nicolau
2018-07-13 12:52 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).