From: Stephen Hemminger <stephen@networkplumber.org>
To: "Montorsi, Francesco" <fmontorsi@empirix.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] warnings when including DPDK headers from a C++17 source file
Date: Fri, 13 Jul 2018 08:52:05 -0700 [thread overview]
Message-ID: <20180713085205.1a255bf3@xeon-e3> (raw)
In-Reply-To: <1531489881821.76380@empirix.com>
On Fri, 13 Jul 2018 13:51:21 +0000
"Montorsi, Francesco" <fmontorsi@empirix.com> wrote:
> Hi all,
>
>
> I just noticed that, because of the removal of the "register" keyword in C++17, when I compile my DPDK-enabled code with -std=c++17 I get the following:
>
>
>
> In file included from ../../../Third-Party/cpp-libs/dpdk/include/rte_ether.h:53:0,
> from ../../../Third-Party/cpp-libs/dpdk/include/rte_ethdev.h:186,
> from HwEmulCaptureDPDK.cpp:43:
> ../../../Third-Party/cpp-libs/dpdk/include/rte_byteorder.h: In function 'uint16_t rte_arch_bswap16(uint16_t)':
> ../../../Third-Party/cpp-libs/dpdk/include/rte_byteorder.h:57:20: warning: ISO C++1z does not allow 'register' storage class specifier [-Wregister]
> register uint16_t x = _x;
> ^
> ../../../Third-Party/cpp-libs/dpdk/include/rte_byteorder.h: In function 'uint32_t rte_arch_bswap32(uint32_t)':
> ../../../Third-Party/cpp-libs/dpdk/include/rte_byteorder.h:72:20: warning: ISO C++1z does not allow 'register' storage class specifier [-Wregister]
> register uint32_t x = _x;
> ^
> In file included from ../../../Third-Party/cpp-libs/dpdk/include/rte_byteorder.h:121:0,
> from ../../../Third-Party/cpp-libs/dpdk/include/rte_ether.h:53,
> from ../../../Third-Party/cpp-libs/dpdk/include/rte_ethdev.h:186,
> from HwEmulCaptureDPDK.cpp:43:
> ../../../Third-Party/cpp-libs/dpdk/include/rte_byteorder_64.h: In function 'uint64_t rte_arch_bswap64(uint64_t)':
> ../../../Third-Party/cpp-libs/dpdk/include/rte_byteorder_64.h:52:20: warning: ISO C++1z does not allow 'register' storage class specifier [-Wregister]
> register uint64_t x = _x;
> ^
>
>
> ?Just thought to let you know... that's a small issue for me since I'm using -Werror
>
>
> Thanks,
> Francesco
>
>
Why is DPDK code using register keyword at all? It is ignored by modern compilers.
next prev parent reply other threads:[~2018-07-13 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 13:51 Montorsi, Francesco
2018-07-13 15:52 ` Stephen Hemminger [this message]
2018-07-15 13:00 ` Montorsi, Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713085205.1a255bf3@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=fmontorsi@empirix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).