From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f180.google.com (mail-pf0-f180.google.com [209.85.192.180]) by dpdk.org (Postfix) with ESMTP id 36C10160 for ; Fri, 13 Jul 2018 17:52:09 +0200 (CEST) Received: by mail-pf0-f180.google.com with SMTP id c21-v6so18255930pfn.8 for ; Fri, 13 Jul 2018 08:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1FDCH+ffZ4I05oERzTltZZrS6FjhiY91WCPYluxq5AA=; b=lDqRNa9VowMX2xG9cYYtjZkp+Ew27U6D7Ga5r/vU3p+nlR7RWhLC6Wlg5Zn6jqb+H9 xQQwdp4o3OYoKeZvxW1IWFDyPOt3LC69ctP/xb4MhLS7AaDgGeLjSrbjKWQ5gM9uqSgn XpAZqwQSgr43e2Lupj2sRGcGJpkl0PjSQBpIyzsSRo1JNe7B9SPBCtv0jZ9kZadFsRyl 51QcYo82PzEfjF6w2zsJnDysxqcSXaRYtaY3MDvheU8DRp+CPHobW/6XVDRYd/kLdh94 fV3KQ78GNnQVLy1p7oUVrzp+pgAWaC82y+ZwLC8BmzKJRjc2IGd9re45e3UUdkUHOJk7 8zvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1FDCH+ffZ4I05oERzTltZZrS6FjhiY91WCPYluxq5AA=; b=juXZvbuZancxDPMVHqwuktVOSLUzVbJ5/R05hF2qwfH+M/haVsuSwTVVzGdGnAjpSA +NxhKLGQLPLkP0Hx9irxXpS05tG/pQLjj6SFvxLYytaQQmEJ/+Kyobz03cw/LrbK2HCD I8bU7n4uc7FmJeXh0nZKoPEIOZL9I/AZlteSBnF+75x3uaas/oNG8sbdvnc89l0GcLzD fvyNYAihALpR5ABDdmYhqvxJenL3RZMCmxo2iD9rJIwcylNzuy1BW4qiEyqaBViAc8B6 1pPZBL3i24MP6mrsSl1MbgW5wczOiQ5dl9CwaVMap5VokrNdiZ1rbfLbEdJCmp7a6hws yWrg== X-Gm-Message-State: AOUpUlFXYos8RyztpOZ2N91JOgstlXCve29mjBj9xK+48/qeDcivHROk MEE0iX1HuxHakg/kMq4WAzStCQ== X-Google-Smtp-Source: AAOMgpfcV4tU6lmC6fFidflLOVv61imZY+fsurYBd10+eqof0x4Egu/X2iCiXme5nU3Z+mM3AE22iQ== X-Received: by 2002:a62:6cc7:: with SMTP id h190-v6mr7712527pfc.113.1531497128280; Fri, 13 Jul 2018 08:52:08 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id t14-v6sm4277761pgu.0.2018.07.13.08.52.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Jul 2018 08:52:08 -0700 (PDT) Date: Fri, 13 Jul 2018 08:52:05 -0700 From: Stephen Hemminger To: "Montorsi, Francesco" Cc: "dev@dpdk.org" Message-ID: <20180713085205.1a255bf3@xeon-e3> In-Reply-To: <1531489881821.76380@empirix.com> References: <1531489881821.76380@empirix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] warnings when including DPDK headers from a C++17 source file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 15:52:09 -0000 On Fri, 13 Jul 2018 13:51:21 +0000 "Montorsi, Francesco" wrote: > Hi all, > > > I just noticed that, because of the removal of the "register" keyword in C++17, when I compile my DPDK-enabled code with -std=c++17 I get the following: > > > > In file included from ../../../Third-Party/cpp-libs/dpdk/include/rte_ether.h:53:0, > from ../../../Third-Party/cpp-libs/dpdk/include/rte_ethdev.h:186, > from HwEmulCaptureDPDK.cpp:43: > ../../../Third-Party/cpp-libs/dpdk/include/rte_byteorder.h: In function 'uint16_t rte_arch_bswap16(uint16_t)': > ../../../Third-Party/cpp-libs/dpdk/include/rte_byteorder.h:57:20: warning: ISO C++1z does not allow 'register' storage class specifier [-Wregister] > register uint16_t x = _x; > ^ > ../../../Third-Party/cpp-libs/dpdk/include/rte_byteorder.h: In function 'uint32_t rte_arch_bswap32(uint32_t)': > ../../../Third-Party/cpp-libs/dpdk/include/rte_byteorder.h:72:20: warning: ISO C++1z does not allow 'register' storage class specifier [-Wregister] > register uint32_t x = _x; > ^ > In file included from ../../../Third-Party/cpp-libs/dpdk/include/rte_byteorder.h:121:0, > from ../../../Third-Party/cpp-libs/dpdk/include/rte_ether.h:53, > from ../../../Third-Party/cpp-libs/dpdk/include/rte_ethdev.h:186, > from HwEmulCaptureDPDK.cpp:43: > ../../../Third-Party/cpp-libs/dpdk/include/rte_byteorder_64.h: In function 'uint64_t rte_arch_bswap64(uint64_t)': > ../../../Third-Party/cpp-libs/dpdk/include/rte_byteorder_64.h:52:20: warning: ISO C++1z does not allow 'register' storage class specifier [-Wregister] > register uint64_t x = _x; > ^ > > > ?Just thought to let you know... that's a small issue for me since I'm using -Werror > > > Thanks, > Francesco > > Why is DPDK code using register keyword at all? It is ignored by modern compilers.