DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hyong Youb Kim <hyonkim@cisco.com>
To: John Daley <johndale@cisco.com>
Cc: ferruh.yigit@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/enic: pick the right Rx handler after changing MTU
Date: Sat, 14 Jul 2018 14:12:09 +0900	[thread overview]
Message-ID: <20180714051207.GA10152@HYONKIM-7R0DR.cisco.com> (raw)
In-Reply-To: <20180714005452.28195-1-johndale@cisco.com>

Hi Ferruh,

Please ignore this patch, as it never assigns the default handler to
rx_pkt_burst. We will send a v2. Sorry about that.

On Fri, Jul 13, 2018 at 05:54:52PM -0700, John Daley wrote:
> From: Hyong Youb Kim <hyonkim@cisco.com>
> 
> enic_set_mtu always reverts to the default Rx handler after changing
> MTU. Try to use the simpler, non-scatter handler in this case as well.
[...]
> +	/* Use the non-scatter, simplified RX handler if possible. */
> +	if (enic->rq_count > 0 && enic->rq[0].data_queue_enable == 0) {
> +		PMD_INIT_LOG(DEBUG, " use the non-scatter Rx handler");
> +		eth_dev = enic->rte_dev;
> +		eth_dev->rx_pkt_burst = &enic_noscatter_recv_pkts;
> +	} else {
> +		PMD_INIT_LOG(DEBUG, " use the normal Rx handler");

Here, we should set rx_pkt_burst = enic_recv_pkts

-Hyong

  reply	other threads:[~2018-07-14  5:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-14  0:54 John Daley
2018-07-14  5:12 ` Hyong Youb Kim [this message]
2018-07-18  2:02 ` [dpdk-dev] [PATCH v2] " John Daley
2018-07-18 13:10   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180714051207.GA10152@HYONKIM-7R0DR.cisco.com \
    --to=hyonkim@cisco.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=johndale@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).