From: Olivier Matz <olivier.matz@6wind.com>
To: Andy Green <andy@warmcat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/2] ring: fix declaration after code
Date: Mon, 16 Jul 2018 09:15:30 +0200 [thread overview]
Message-ID: <20180716071530.5gelmvk3htows3uj@platinum> (raw)
In-Reply-To: <152749821848.44120.9534717185541492433.stgit@localhost.localdomain>
On Mon, May 28, 2018 at 05:03:38PM +0800, Andy Green wrote:
> On gcc 5.4.0 / native aarch64 from Ubuntu 16.04:
>
> /home/agreen/lagopus/src/dpdk/build/include/
> rte_ring_c11_mem.h: In function
> '__rte_ring_move_prod_head':
> /home/agreen/lagopus/src/dpdk/build/include/
> rte_ring_c11_mem.h:69:3: warning: ISO C90
> forbids mixed declarations and code
> [-Wdeclaration-after-statement]
> const uint32_t cons_tail = r->cons.tail;
> ^
> /home/agreen/lagopus/src/dpdk/build/include/
> rte_ring_c11_mem.h: In function
> '__rte_ring_move_cons_head':
> /home/agreen/lagopus/src/dpdk/build/include/
> rte_ring_c11_mem.h:136:3: warning: ISO C90
> forbids mixed declarations and code
> [-Wdeclaration-after-statement]
> const uint32_t prod_tail = r->prod.tail;
> ^
>
> Signed-off-by: Andy Green <andy@warmcat.com>
> Fixes: 39368ebfc6 ("ring: introduce C11 memory model barrier option")
Acked-by: Olivier Matz <olivier.matz@6wind.com>
next prev parent reply other threads:[~2018-07-16 7:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 2:29 [dpdk-dev] [PATCH 0/2] dpdk header fixes for aarch64 Andy Green
2018-05-28 2:29 ` [dpdk-dev] [PATCH 1/2] ring: fix declaration after code Andy Green
2018-05-28 8:15 ` Gavin Hu
2018-05-28 8:46 ` Andy Green
2018-05-28 8:54 ` Gavin Hu
2018-05-28 2:29 ` [dpdk-dev] [PATCH 2/2] ring: fix sign conversion warning Andy Green
2018-05-28 9:03 ` [dpdk-dev] [PATCH v2 0/2] dpdk header fixes for aarch64 Andy Green
2018-05-28 9:03 ` [dpdk-dev] [PATCH v2 1/2] ring: fix declaration after code Andy Green
2018-07-16 7:15 ` Olivier Matz [this message]
2018-05-28 9:03 ` [dpdk-dev] [PATCH v2 2/2] ring: fix sign conversion warning Andy Green
2018-07-16 7:16 ` Olivier Matz
2018-07-26 13:30 ` [dpdk-dev] [PATCH v2 0/2] dpdk header fixes for aarch64 Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716071530.5gelmvk3htows3uj@platinum \
--to=olivier.matz@6wind.com \
--cc=andy@warmcat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).