From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700061.outbound.protection.outlook.com [40.107.70.61]) by dpdk.org (Postfix) with ESMTP id 084FC235 for ; Mon, 16 Jul 2018 13:07:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5qO9UmBrpjuuUjaWzSzDYil044x6dntmc0uHZmjfu9Q=; b=XKKqJr6jli4uiZazTCjYZpoaM/SqqUSIqJpO9xxqKrYxbwRJFTWpvcIp+85QWtFSFJvdLg+S/qgSHz4jdf4+s/7tSZS1YqaOzAgTKV2r3FBW4iXxzp6zn3MUUmcfdy2DwG2XQeMD9SLa4plDx/rZSbTCtVf5MkHl84cTiDia5OU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (12.108.191.226) by DM5PR07MB3465.namprd07.prod.outlook.com (2603:10b6:4:67::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.17; Mon, 16 Jul 2018 11:06:04 +0000 Date: Mon, 16 Jul 2018 16:35:52 +0530 From: Pavan Nikhilesh To: Thomas Monjalon , =?iso-8859-1?Q?Ga=EBtan?= Rivet , Shahaf Shuler , "jerin.jacob@caviumnetworks.com" , Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20180716110550.GA32313@ltp-pvn> References: <20180615044359.20692-1-pbhagavatula@caviumnetworks.com> <20180627095736.jty7lbqesxufwiby@bidouze.vm.6wind.com> <20180710101946.GB30393@ltp-pvn> <11431324.P0YfK9v5sK@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <11431324.P0YfK9v5sK@xps> User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [12.108.191.226] X-ClientProxiedBy: BYAPR02CA0038.namprd02.prod.outlook.com (2603:10b6:a03:54::15) To DM5PR07MB3465.namprd07.prod.outlook.com (2603:10b6:4:67::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2e3cc4eb-bcde-49e5-77f6-08d5eb0c2146 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:DM5PR07MB3465; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 3:1ohIfMruJDHlwEjrdZYXyoa/k+hQG8Qe4wM0BUzDIrXwUiBZv/UNjhtI678x/lrWAICCISMRK9q15V4s6zX7Ow86ruK0aOwts8JsNuTvHFDLFOpxjYcllEIvuNwfeTJi5Z9syq4o41vd4N1eaTZyWZVK9VbAQKhvHJ2EwrH4Bn2Ztg1f5HBxB4gHopzw6lMJrWvyMM0/PMgx1JDV4dvhcFCmtehQi1R0STBDwJc7w2F9jJ0Jq1xEVshE3esR8OJO; 25:kRqo9ky7GcXAon8m93lF2zqAi8ThV0euhGybAhLLqiURlmbRQogoaIIgDwj/SzAAyqOoOsm/qXL++dmjDlOueBkl9ggJyKSbh0F5gUS231Ax9X7I+B5JZ3hyH8wcK38uxMJfJJwvWjBC+0vtdkRFAAeinIWMkhqTTfpWsziCbdBCZwDwrxR4v5RT5kdFsSjLtOhDFSIDR6JltOlzXUX1Nm5oI3QYVqCHueUe4YSa0P/glj/JFRzz1IIJV0e2X5hvdH6azro2K+ixaz1dBGqivAYPBLywMyjC3uLtmW5EE46iuhX5LMofbBVsmJBauzT+uLI/xZxo6yh5HziefIlApA==; 31:LmPQlZxLxwD+WvhL0CMRrmR1phPtPIlo9IaoH9+yHFcNG4l8Xs/zIA1KET3Ho9FsU3qgODiV6Y/kwKx7Z00cLkIkv+8UKJb2SrBUa23Bk7J2muqXwKfXwKCKnlm2YeyOjFibOPAXxJONDx9U4LBaNRpUqgnMhxxD4ZGb10aFrnKTJ9U63SLDo090qgZbe2RjQUJp7betO0pmr8psY0OSEqSTEh7Jd4EnkjSh3XPp1vs= X-MS-TrafficTypeDiagnostic: DM5PR07MB3465: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 20:RRcBc6ofjvhDubKHgrUzYbo+dZavUBt2XoPz4R+i/yi9xVUzQyKGmilCooZj8EspKkS3RO8ijWq/0jURDskDqDwXJwGUdARTCVVgUmcSdg/3bW84ld8UfycPYU08c++kzfqffT093kV3VgCVNEWpO1HXWa7vzfSkAFKMkv8u5qkVMtOE5vyCWKF+KRWU9TNeOl7dHlWg5QM8LENCi3766NW1SQZEt+oCgInYAoPhCXzMZrEPwZd2TOKHLMQk28u0VdPn3h2QNlkgQPNEY4FGG3kyqZRGDEPVP8+XqP2rByPQHwhQeq6FAt1xp/+ByabAxTdsl6Awa8chr/K23nIXoP96klop2Nk0OutFYTEARdSBPPW6P90AeSslchhuzNFvMQLr4gbFpm5xZ8EJ5ywuNYFzwGXtOoR8FOgm3h0k+z0+BImC9ELGQVlDYq4CfMGJmwyC1Nq23yzpWN4OsfuWZBwEe3UvSdBGG8eq7c2kGl82dJmnEFJLOX2Q566B6v5sxKsVK5Y9I8I3aYyC5uCSdUfSCDXU8f8uzxG36JewxytcoDYsvx7TIOHpaxlpmBt65PTqukCrq+IdmNiEZF+F2lxEygkKoqDGr5ko+1/zduM=; 4:qyyzUl/ajEi9ko7Z4xH/sPUZVMD5kzPa6noL3EW7WhO9lFd33uF2u0T6YkP8bHd1B3xoPONCVUnq5GAUQFs2qnpg2qRzdo2aQrapDWu1Bgr+cHBsy5TEGR+IxviG0XI1aR2+Si9AAazaEJPjgLjZwr9udQW2hY25woHxGU1FxyiwZcY4IdsdVjb4wT6x3K8iB2+w7c9IBuglCewmHi8YnRhbB7YC4kbi9+QEoiYVn809GRZpzqclzSCjfCD9AxIJxBkcu/S6b56fLcHVOf7ZJg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(3002001)(3231311)(944501410)(52105095)(10201501046)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:DM5PR07MB3465; BCL:0; PCL:0; RULEID:; SRVR:DM5PR07MB3465; X-Forefront-PRVS: 073515755F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(346002)(136003)(366004)(376002)(199004)(189003)(66066001)(97736004)(93886005)(72206003)(47776003)(478600001)(58126008)(6246003)(2501003)(4326008)(25786009)(53936002)(316002)(23756003)(68736007)(5660300001)(110136005)(81156014)(6666003)(6496006)(52116002)(476003)(956004)(3846002)(1076002)(50466002)(6116002)(486006)(446003)(11346002)(229853002)(55016002)(76176011)(9686003)(6306002)(7736002)(106356001)(16526019)(186003)(8936002)(105586002)(2906002)(26005)(42882007)(81166006)(8676002)(33896004)(33656002)(53546011)(386003)(305945005)(33716001)(2870700001)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3465; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1; DM5PR07MB3465; 23:MMuDi0lgqsmcLvYrRIutV9PK3e7tnx81WkPX6mc?= =?iso-8859-1?Q?w83E5HEqy0hLpbyHA0yNN3V49bXzyf8noKmGOW5WE+92Guis60WiVlTBMf?= =?iso-8859-1?Q?qqPngxKIjfEnxVG0ckv50i5SFzZuS5fcFjBBCKhCrIpUVIMeWKrj2IcscC?= =?iso-8859-1?Q?qooNuSYSV6S3m/CYfgC5lQewyEnU/GNjKlmIYmx2m8acqHLIreus0haRRi?= =?iso-8859-1?Q?Va/WVnGfZoWlOFZNxNIln/sIZUJ28pwPnagl4ZnDpymEGzPe9ugpVa5mj6?= =?iso-8859-1?Q?s6lS988v6kb0JF7ms3JHK0RNc7XUqyld4juWaBeLAjabd5yMeOuPqlldiI?= =?iso-8859-1?Q?PfNrHVvY0J+JTC4iGJ83oGe0uLOPHKgukGytAlosMDM6wYcjzFd5qJtB5C?= =?iso-8859-1?Q?fR5nvsiR49AH5gaPpRXU5OQBFfcSZiQZuDJMdGXxjZ7uTnmsOZs/+wLpRK?= =?iso-8859-1?Q?cMMDNS5ytDJNjTxjbCix2NnVcJ6sOS7lxfVySLxuxAqjW/zdc8ccQ9lagl?= =?iso-8859-1?Q?SK2cccvcM1sRBaGd5rlnFihOQKTM8350rW+vx06snxfX/pTZ4cewlAaTb2?= =?iso-8859-1?Q?W/a8zzAda4D8915hzPt4VhYbsXua7gsnbLL2EKkRqjdovqrQNSER9sJvNl?= =?iso-8859-1?Q?mw/0TF78QUOVfHvvMkx9Y9mVhyv67/EMO+XA/wDdwQgEosHjPO/ie1XeSr?= =?iso-8859-1?Q?TL6P3eoYa5S8exuMV8CGuA2y9Sfr71BsOFDLZtwYVdxpIn00bfKfUSaRQq?= =?iso-8859-1?Q?QiC8pGQOhbILqK+KVx4noV9aq5VBlZBL67aDm33aosYxEDW1q5VTKBQseS?= =?iso-8859-1?Q?qNH6gWLex728plcEMpE68GhLArRwpP9nD3EV/JVR/YuukUF3kzmgGFyj0F?= =?iso-8859-1?Q?VF0cz9Gr1CHexzjo86hSlqdm3QTToXgu2oS+FKaOtMXYWN/S0TMDo9XJZK?= =?iso-8859-1?Q?kj/BAVE6s0jqX7517eid+lDr1+jjv1r1MrPLlU/Scn1tY23ArhrYeCMTTM?= =?iso-8859-1?Q?/3t/0ed+S4Pe9bZgRBQZiNGtQLOYDlBS4V1AiE23v6aCoCtAMb1jGbcM/z?= =?iso-8859-1?Q?8hw1IcEvFMbfvK7RnPugisOGP8yJ0C12Vuy7MNo3iKC2DZxZ/hZe/dX+MV?= =?iso-8859-1?Q?xdHf3GD15wr1injr1+fhMMlwE9Hc93XV30vrNzvHx35jH/nvcGA3myG+/E?= =?iso-8859-1?Q?PvrH4ZZWh5KKqCUR1aCxUqIRmAw6g808KzUiSCp48hSeS2HEVaP1odkqbx?= =?iso-8859-1?Q?SyNt0dld+vtcbv7wjwmRFf/ChMwhYu1c3CaMbaM57b5OBWSBcPuQd62U6x?= =?iso-8859-1?Q?TKinq2KQVdwsg8fGhU8pjugO9AFwPrrSrGZwMSOt/MuCKRZobPS7ZGqFKA?= =?iso-8859-1?Q?T+CuhpHgz02ds25gHhC5Bfj2ohfEpnKht5hqlKAuJ7Bk1XYQyugvvlh5CQ?= =?iso-8859-1?Q?6dt/Wfx75fqjBdFBsNvkBie2EK9gx2uIzZ6WPOk3vpNhF9GtinCbFwp6Q?= =?iso-8859-1?Q?=3D=3D?= X-Microsoft-Antispam-Message-Info: V3cusRrxtC4kL1Ss51d6DK99C43mWGLtQF/skJoxZ+uws6z/jC4xPNW2au2DW5p24e7Xqgu/pBCMulyBZNPxJspPkAsR2bERXUwVLTvVC6JlydMyYDvtLy5R58QDKHNybx+Edrcr4Rzo9E3/O1JpC4s7bDkB4Hg78dGED7FqFWcWky0t4Vd+PNZMHy9X7aubr6tNe2rmu39kWtwgeqF43nCEnGzizkyW/b0ZjZTcmYDeEh0NVeK1tVWNpEp9yT0twEKJMHvXSRGELNHKAHRNdu/cjhvVoWL5Y2ak8p+cYaNglEZk8dWUbtRsXTd85wcRhXyd4LzUEetwfpCJUPug0Y1sSi5GA1O07nA8EAVIffk= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 6:H9TfyBRiZZZrz/aJ3A71Rn7qDz2SZxUqlqYsVlvbBZsyPWknNt674NeIGUIw+oXZzn2Ut0FLMdtNSOAGrhFJvKMBOeW4PQ+O5hmSAXjD01Rx9Xf4/e2oyY43D2MpocoCw4gV8yrw1NbQlkn8vv71xamkbd945jS48pBlRrWLADBhvoT6m8GhcW2gB2dhH++ypTZqsUmfELp6L5HPuVHbGZGTlx0DXMljKuqx53EmELlVmoNi2DUz0c8bxN/FJ5X25JvHpfh1k0k/9+DCXusWHJHIF2ZLknO/Zr/hUfyHyyGrNPBihi2bHZgeUuSg5NC/JszC4vmOXCvAEoGaFuELBsN/czgguaGBpBgQ6DqMAgxBzxhcUqbyMkUYqwIiEtajdgQdYX7vTPLsmQDF9XdxZkLuJOKCUbjUvp4TbxnRab8vCkv510QZ6GNPQtPKpTj75f1sv/GaS7uBTizIGGVmmQ==; 5:2Tjmi1cnBQkJD/ULnb4b7ALCa5OqvnnDWULBOUWcu7v1SvBKqi/Rfeu+hRyA6b4ZT1ks7/V2CCDHvqFZVeXGzPoYbdcK9bTHFpDnh7PRf3F/xdk8YGtel6GIspg0sf0QPVEZbhxluvMGiVJnCGzCgFVY0PvpsDpAFsiYb8Wmzss=; 24:mtrqoP7nTAS90M2N8ucSaCvVDNtoSEVgHQUGsQ9CVSXxGWLaVXzPViYzKfA1MHm+65AOAhc6PWi8TWXzfO3IbzrqNXBzU6KYEeLKgltwJiU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 7:qQHXWC0JcjMfhq8nD7+468+11YBB+eUkMbsUQRvYD67SdnehsMo1r8gtuTlN1LL4Z+eZ/0T0//AWPPs7bCEyKAWbWMeMk/d0w+ZppN/WFftXpSatl99GAdmUqvyjE2bIx1k5DQ9LDv6rA0N6IwkIzGKRl5QrtIGjnMn46hLmpZ0hG4gD9pT934EqlzFerJjWfpE/YUqq+WHxa7Yn4nrOSTmYp/U2CMEe2tIbZ3GisrTcOgxEUCzVvp3BhcQwTZx/ X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2018 11:06:04.3843 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2e3cc4eb-bcde-49e5-77f6-08d5eb0c2146 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3465 Subject: Re: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2018 11:07:28 -0000 On Mon, Jul 16, 2018 at 12:25:29AM +0200, Thomas Monjalon wrote: > External Email > > 10/07/2018 12:19, Pavan Nikhilesh: > > Hi Gaëtan,Ferruh, > > > > On Wed, Jun 27, 2018 at 11:57:36AM +0200, Gaëtan Rivet wrote: > > > On Wed, Jun 27, 2018 at 02:25:30PM +0530, Pavan Nikhilesh wrote: > > > > Hi Gaëtan, > > > > > > > > On Wed, Jun 27, 2018 at 10:39:59AM +0200, Gaëtan Rivet wrote: > > > > > Hi Ferruh, Pavan, > > > > > > > > > > sorry for the delay, > > > > > > > > > > On Tue, Jun 26, 2018 at 04:40:21PM +0100, Ferruh Yigit wrote: > > > > > > On 6/26/2018 1:48 PM, Shahaf Shuler wrote: > > > > > > > Hi Pavan, > > > > > > > > > > > > > > Friday, June 15, 2018 7:44 AM, Pavan Nikhilesh: > > > > > > >> Subject: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev > > > > > > >> args > > > > > > >> > > > > > > >> Currently, the only way of supplying device argument to a pci device is to > > > > > > >> whitelist it i.e. -w 000X:00:0X.0,self_test=1. This is not a very feasible method > > > > > > >> as whitelisting a device has its own side effects i.e only the whitelisted pci > > > > > > >> devices are probed. > > > > > > >> > > > > > > >> Add a new eal command line option --pci-args to pass device args without the > > > > > > >> need to whitelist the devices. > > > > > > >> --pci-args 000X:00:0X.0,self_test=1 > > > > > > >> > > > > > > >> Signed-off-by: Pavan Nikhilesh > > > > > > > > > > > > > > Tested-by: Shahaf Shuler > > > > > > > > > > > > > > It seems to work. > > > > > > > Please see small comments below > > > > > > > > > > > > Isn't this conflict with Gaetan's devarg work which has wider scope? > > > > > > > > > > > > > > > > Indeed it does. > > > > > > > > > > Pavan, I have submitted a new version of a series adding generic kvargs > > > > > to several layers (bus, class, driver). > > > > > > > > > > It does cover this exact use-case. > > > > > > > > > > However, while writing it, I wasn't able to find PCI bus specific > > > > > parameters, that could showcase the functionality. > > > > > > > > The idea of the patch is to avoid whitelising a device when we want to > > > > supply kvargs to it, I tried mapping it to devargs rework patchset but couldn't > > > > do it at a glance. For example, the following patch[1] reads kvargs through > > > > whitelisting which should be avoided. > > > > > > > > [1]http://patches.dpdk.org/patch/41223/ > > > > > > > > > > I see. > > > > > > Actually, your use-case won't be covered by the devargs rework. > > > > > > I am still dumbfounded by how this blacklist/whitelist mode stuff is > > > kept against all odds. But that's not the time to deal with it. > > > > > > The issue is that the two features "declaring a device" and > > > "configuring a bus" are currently awkwardly merged. You are piling stuff > > > on the "declaring a device" part to enhance the "configuring a bus" > > > feature. > > > > The feature is very much needed to avoid polluting the cmdline args when we are > > trying to configure a device at probe (for now). > > > > > > > > Instead of going this way, I would advise to separate the two features. > > > > > > If buses could be configured with a generic EAL option > > > "--blacklist=pci,vdev" for example, then you could provide devargs as > > > much as you want, the buses themselves would stay properly configured. > > > > > > This means removing devargs policy, device types and rewriting bus logic > > > about it. > > > > I think this can be done as a future work and is not in the scope of this > > patch. > > > > @Ferruh, > > As Gaëtan mentioned this patch is not related to devargs rework can we make > > some forward progress. > > No, we should not add a new parameter just to fix one use case for one bus. > The work of Gaetan is opening the door to a generic syntax which can be > used for device matching (like for whitelisting), or for settings > (what you need) of any bus, any device class or any driver. > We can discuss about which option to add for generic device settings, > and whether or not it should be mixed with whitelisting, > but please let's work on a generic solution. Ok, I guess this can be taken up once Gaëtan devarsg patches are completely merged. If we split the work into a smaller list we could load balance the work and work towards 18.11?. > >