From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0057.outbound.protection.outlook.com [104.47.34.57]) by dpdk.org (Postfix) with ESMTP id CD538201 for ; Mon, 16 Jul 2018 13:33:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J5P4RtAI+VAjIn0fkDUpe0RFGOv8jEEcmvqkSUYDu4E=; b=lltu+a1V+56kbbBEXDzhEZzHsTlk3TXb4AbIAsLiL0+W/L3iPfex+CLjOG11SU1krDQc1ToA9tUrygTDrV2jWdSaVH4soaFH8E44UsjM5jH0OgE+910hKfVkcdt9u9lQanXw9hFUa5P3b5UUaR3OWRLqL6fXxV6UAycEqEfTBkg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (12.108.191.226) by CY4PR07MB3464.namprd07.prod.outlook.com (2603:10b6:910:75::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.20; Mon, 16 Jul 2018 11:33:19 +0000 Date: Mon, 16 Jul 2018 17:03:12 +0530 From: Pavan Nikhilesh To: nikhil.rao@intel.com, jkollanukkaran@caviumnetworks.com, olivier.matz@6wind.com Cc: dev@dpdk.org Message-ID: <20180716113311.GB3118@ltp-pvn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [12.108.191.226] X-ClientProxiedBy: MWHPR12CA0041.namprd12.prod.outlook.com (2603:10b6:301:2::27) To CY4PR07MB3464.namprd07.prod.outlook.com (2603:10b6:910:75::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ae9f927e-3802-4ed1-4832-08d5eb0fef5a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:CY4PR07MB3464; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 3:QjbfdDHX2TjqtzHkfIU58myZlLZubgxPnhIKcjH/fPa/YPErnj6CmlFqWQIyWkqifUnlcLl4F2RvWFwYJ+Ctk6iCeoqaMB4pkN3SAkEyVEtm4XPdrgJyjDd94sZlhljsTULxN/D+gGiemOver0qX3JfTJrzMVGRwjVn6PAla9IQjXaghoecoFa1ZGaKFb8E/KwJIaTyBJme0cU2qLJlACInoS0YORfF4y/+gOXpFGsL5MY2pIzf5jxTddvEeABwM; 25:nmgDdL2WQ9A+2Lj86YeU8jO6TCt2hVoOJ6/dmdI9CbRNGDaRA5gfmAXjchf0frQpeBobahGergeVqcvuS5PP2AAHpLV/djSqYYPSjrPVH7vOHpMW1yX9xsvMwynsNB2XZY4F5vHpz65M7QPEgj9/nIdT/Xh7R4aj3Gq5uenBAnBud/MOa9Op8aTlZfc3P+p+OlI5fICKeP0yz7LgQQIZZ0usmfkS6FckckxztBZyHklu3p8tM44GCagNmq/anFSt3Tg2hwYCPZqoZGm2JBoA+UGR8s5u/MFLd7UJ3rYSdyj7kXoUSWNnTpsa8e4LFipkjxutLLeO0dF/+TlSI06ySA==; 31:DOBFd7JYCESfWBzXaLtc7hbb1BgWKClMKR+IZ+FQ1PF/58492hVYEfFn8B2IGWiox130Ami0lwZN5nKuprthcODe284nUEoreLojkqfaluqq/0VL+9k/9seFRzegg0gxhj/usn1uNWkDRag4/abqqS4CquOOs+gz9ee3zmrvB3trYVXc84vDrmY5G69yRSghu1GdEwRWIXMCvG1s1vRaPQxUYV2g6ikvCOWAYifn0uI= X-MS-TrafficTypeDiagnostic: CY4PR07MB3464: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 20:TDgyPEv82MVzA7m7lPYz6VV98Augauq+dsWOQ/gWnTUMOq33A7hpUA+2YrHENmd7dEXEmWgx2pZ4rZ7t9VMStaZKWz5C/QckHapwrQsDH0hEOKTYKsJ31ZvBXXc/S/Cf75Js4JK5XlHCMkUdc78uH9WMyIYn8bbQhuZuJM1ITyi4oKYJolzP7VajdAHh5U8vnhjk+lYBbO5I7FInJmHG/y22QcZcvFcRblgMa6ij2nRrWAuxYHDIXHjDgqZxsS9BJk32papGDxq45+dDupzNkmD9ALk0Rplz3Ktx5QH+YuEUVpoigOZJ+2iN53JynqqnCAP0suHKeYBM8lbTP7ek9n6M1K3pKSu3A6I4r8+fhusmlQvoZolI99qEgEnoSgM4/UgIRy6rfQL2ow3hDoNKE3KFhJvzVa4nycBvsHBsDJ+5iCrfsbd7NBioEIhMN6rTK1lUAS/Bpj3Bfc3cLffU/G0tJZWUtlrmN4j3TlIGQLkWrOKbOlbsWpJGyklV8XThrenWX1hc5dOkrI1kyHKh/VD238APdRySsn4ukLzRchpQdLglsuERiKYbZm6Ac/FV1Oc0SZM8rGCBYI3GGy2G90pmVfOOyIh/sI2eKFd7xxs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(35073007944872)(788757137089); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(3231311)(944501410)(52105095)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:CY4PR07MB3464; BCL:0; PCL:0; RULEID:; SRVR:CY4PR07MB3464; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 4:7ZQvlFLMTtlt9HR73SvS4W3JnXMep+ceQOra2rH/OAJRORjmxh6kmuokQjpIhU0gudlgq1AMZkiKL9rUF1RryNonF/Q5ew0MEx2w/+octCrlLh1T/x5D/4CCtD0r4JPJjHjGIrid88qhCTQLKfclFQ/NQb6/dTYs1YOuSG2Epi9niO1JPyz+4v4gHjqI6qQcW7ZS82pUXYPRiA0M+BXAtAPCBU7Btc0NENU/jVRvntgjnxP0ToGCgXGWYbcvOK3ptbd30Eo0RTPOgp4bJ36iNSDePHi2q4ZR43juiSOy7c3K4bhGncBedzP1KO5lTcaD0MHwQHKxazkxNh/FjH0ZV8pihNHSP/4/BRkbki98pRQ= X-Forefront-PRVS: 073515755F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39860400002)(136003)(366004)(396003)(189003)(199004)(72206003)(47776003)(5660300001)(6496006)(50466002)(53936002)(478600001)(58126008)(6666003)(316002)(1076002)(23726003)(25786009)(3846002)(6116002)(97736004)(105586002)(16586007)(106356001)(9686003)(33656002)(55016002)(4326008)(81166006)(81156014)(186003)(2906002)(486006)(476003)(956004)(7736002)(33716001)(53546011)(33896004)(26005)(42882007)(52116002)(8936002)(8676002)(66066001)(305945005)(68736007)(16526019)(386003)(18370500001)(107986001)(42262002)(222073002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3464; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3464; 23:6ToBrjBOog6BxEjiWMQQpLn8TSqmmUu4zHz2enwe6?= =?us-ascii?Q?B1lT9LGBqoGV010IH8pKK7ftzF5PNrMx/TWZP4/NuHBOS4pbdTf0aX/ZwcGs?= =?us-ascii?Q?M7S3+E8cXgV3afR4IIu1f0cO5VtOJTBc1CTdEdBIYf7gCxKFUFPo7Z/YQiAE?= =?us-ascii?Q?BeWIq+TnosR5eC9W6E/2IfQBvRR5ashZS9BYyZ70crmeiammQmiFxjndwOIn?= =?us-ascii?Q?ZlnwTx3Tyr25xIgl5k0ZQJeNISd+5L4l1oPlWpxE7Ke4KyCDVmAlSd8FyF9e?= =?us-ascii?Q?tBIpmrYPqpZ7YfCNcIkK+tOkdMEdRtkQ21c/bTxYcX1o/P819snxqGKYDP8B?= =?us-ascii?Q?DaVXuVwrkc5mBxPBFSviVdhdVYoukc4zNjVXYXp40WtG9uKIP8WeYgC+1j09?= =?us-ascii?Q?IpLghOz0DdV5tModoq/D/d4vZBPvXXfc19sK8PrByQ5ujlSqMA+tNEnQmF9h?= =?us-ascii?Q?hc8+Lbp2jZFDfTWvfysCPgZVKjfmslmJ9vCfV9umlKWY702r5jCylvdF+cyC?= =?us-ascii?Q?1KGUQT/E6+IW/ycn2CSctZXWJ60gNx5pQvR9PixSGKk9ObxltJjTjERDMeza?= =?us-ascii?Q?6qdtNOyD1YNWq2FBgND/Mi2LtxM4vfP4d/2fDmbILaumSedgwPKmKfKvxvVn?= =?us-ascii?Q?dLNzw/53b1LLlkWWptoNicN8jYfOClSWcr82vLTX4VLue1+EPBZbMayLDSoy?= =?us-ascii?Q?ZZ2nhT3MEsMSwzAlglICuxVGxQ4+fcbOphzRHfa7H2zULJ5BNRpJ9y5DjX7v?= =?us-ascii?Q?Ndcplp217RVIVO27q0v3AxWWqAkBOJ5dEt+2IGgNpXq7g6S79Y6FhnwovYX4?= =?us-ascii?Q?qwBKttxurENnBfWdgltL5PsmVI8cXMKqGNFsE1NZSY6C6eLa1nETiwDZ3+m4?= =?us-ascii?Q?ldMkWg4ArIqug959l5lphfEP5QMAcOx0Qj4Z2hrCNwkx1uBZc7NE3QtnDuDQ?= =?us-ascii?Q?RcZ9A2WMDvpL4wxC1OKcLFK+xxiQhA9o8mveoxwVTBQ600c1OmpnhCDEIAVE?= =?us-ascii?Q?oGDC6lutxVc/wxsufMKXm8eWzOpIWVEeBsAVIlNf2ZCWYpQYMSOOgTZi0IZh?= =?us-ascii?Q?uodvdy2A7AsOqD9Kx0lQWpW7GmuO0P6whHbnHgKfeIAv1ulPIXIw4kIy7Gtq?= =?us-ascii?Q?TwFEPCd99MPJQRJ2vUJYanLaWANiLFPMMsID1aMpQoT8fLSjY7H5pVvN9fcA?= =?us-ascii?Q?ZQ0mpBSab/DyjHSuE2eMNlmj/DmQ3qN9CioA9nhpnlOQ6ruEV0HXpNQY8XQQ?= =?us-ascii?Q?0l6aWX9EA+JyV57+Ko=3D?= X-Microsoft-Antispam-Message-Info: 0LmS36Ha8YvImg4MHbLEa54VLsnJrmZVSLA8iqGWaT4DNpOwGRKihRwBKN82BfmfeYmqsaCB34uA2RNMSSHADIU3aZbInSxpUQsW4iaPVXnNMBMcM7OdCrV6OxdCeJcGx/+AGrWnwqT1VQoyFJU5TLuqbg9EpwiIaUyEITn8LZtRjaIz/jOU+mhxZp8c7bNlFkklzpNSwu9QTdJlTu00T5ILIGe0XVEz5OvwGkbag0uXZT658ZPEMLda/V6myis5RpM6GSzMPDtJOEsyr0six54fW/bOr/MRVZ7rhYUtjFOhduOIwxi4VCmt9A49YO9ugO22lXkwSwaLSawQyoDcphI5UENZQ5tanbypS+oh9TI= X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 6:iHY3YIh/PXtSSbWt3XcjiJ2HywxBqAiHaabY/8qAPmoOoBWQujWCcH045KGmbINk2z1dovWV3f7JPB3jErNrruxTPeC277kwUGZnaqyXYgmV6m6rYVDNXmlZ5OJueFkHqwex/mY/s/XGRE+K4f/ocdVVsbfNBSPnMLyd2SaHGmmx4pxEerWt1cSQ/bFmTXqtat6WbkgOcFbdBeC/wN9IxLJh7QV6A9zHFJaP/xwxFYi5jRtX4/avbl02g+ToIUGhDcNULDCndnSuYM8d+wVS/5VdNMgGpsqEQs8ACGLIgzMpWnnqeI6k6u07CttlPPiqjTXLgt5+RrmexCOJACllUTcicUeXYbZS8EFYpk72ulKuJyTUxo/WT1jcqSuvTiZLamQsxbFNCmc3WDMUkE2v9wQtRPeTkJQ/KiGHgrmM4wM7Q9/l8NWkvsagF0C2vP6edKmzSmi7+CLMi71SYtuOsA==; 5:GOzfJfEbuWWB3NyYRP97DgbYapGWkg5TJ5wcw/D4boXvwqcn4ew212q40bmGZWkumPdiL5kWZbuFNOd6r1Bb4FZHmQ9jeVjzLfaEodL3e406LSyZZqDKK4KMxMlfVTRnBRgw8W6J9DW6+uMuaFsqbIoxhneZtZ/3td+TEqCFlLY=; 24:GFssvFFrsL2VGFnDuOya8NKb+rd7vY1awKkf5RDxZgXHD37KTI7/R3Bv2UD68JCppXIUIju+2CR/BH+DEcVXlJDfbptndCbLDsr9caLXAMs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 7:AVZ8Ah1iVMrkasJmvB+GyOJ97qd67gxElWzhMNzYsNNBgs+RfA4+Lmfq+5uPUmUmCPvNP09+Oj1ofNKzltLhdh5duu8kVrIVs0o1eq5wAtJ/zukrHmktadtaWXVlUD2FAzgjzJIytN/SlKXcNKONBwWwi+FvOl7/mEYywdqATPiFwctwUdoYR9FPUg8tbDmhYRaNlZZpFNd22uBu8sXQcJ69bK+f13JlnvC5SoU66babtb/qH5wjWD5LZPZNyCzf X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2018 11:33:19.4408 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ae9f927e-3802-4ed1-4832-08d5eb0fef5a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3464 Subject: [dpdk-dev] [pbhagavatula@caviumnetworks.com: Re: [PATCH 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter] X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2018 11:33:24 -0000 Hi Nikhil, On Mon, Jul 16, 2018 at 11:25:45AM +0530, Rao, Nikhil wrote: > On 7/10/2018 4:26 PM, Pavan Nikhilesh wrote: > > +int __rte_experimental > > +rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint32_t *caps) > > +{ > > The caps get API needs to be similar to rx adapter caps get i.e. it needs to > > have the eth_port_id as a parameter so that the underlying event dev driver can > > expose INTERNAL PORT capability as not all ethdev drivers have the capability > > to interact with the eventdevs internal port. > > > > rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint16_t eth_port_id, > > uint32_t *caps); > Hi Pavan, > > Is querying the INTERNAL PORT on a per ethdev basis useful to the > application ? If an application chooses to use 2 ports one with INTERNAL PORT capability and one _without_ it then it would be useful to have per ethdev based classification similar to Rx adapter. The application can classify events based on event type RTE_EVENT_TYPE_ETHDEV & RTE_EVENT_TYPE_ETH_RX_ADAPTER to segregate between INTERNAL & NON-INTERNAL port at ingress side and enqueue it to either rte_event_eth_tx_adapter_enqueue or to the SINGLE link queue respectively. Also, I dont think eventdev should iterate over all probed ethdevs and give the overall caps as an application might want only a specific ethdev to be connected to the event tx adapter. > > For e.g., the txa_init() function in the adapter implementation can only > decide to use the internal port if it is supported for all ethdevs, > hence I left that upto the eventdev PMD to decide - i.e., it could > iterate across txa->dev_count eth devices to make that determination. > For caps in general, I agree it makes sense to pass in the ethdev, but > the INTERNAL PORT didn't seem useful on a per ethdev basis. > > We could also replace caps_get with something like a > rte_event_eth_tx_adapter_internal_port_check(dev_id) and add a per > ethdev caps if needed later. > > Thanks, > Nikhil Thanks, Pavan.