From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690056.outbound.protection.outlook.com [40.107.69.56]) by dpdk.org (Postfix) with ESMTP id 44C9D16E for ; Mon, 16 Jul 2018 16:27:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9XHfu+Ty7x8wWIpv6dG7JWlJIW2ofGUTkUpSNlCkho0=; b=KScWhE2NbCFJ5INXwO3nZbw7aI0zXf6E8wI7zF5Fv6LS2yUyZnxWR2ty7XPL/0v8GAtZleq/zBwwFV5P4WfjGtllGme9h970Ixc7j9hBJ5TfOp4DJglaDaQDgTyfdRgj4qLl8nzx4VgCtwCH4qfxLB0p/WzdSmDsG5/gUbQZ4UA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (12.108.191.226) by BN6PR07MB3457.namprd07.prod.outlook.com (2603:10b6:405:64::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.21; Mon, 16 Jul 2018 14:27:19 +0000 Date: Mon, 16 Jul 2018 19:57:06 +0530 From: Pavan Nikhilesh To: "Rao, Nikhil" , jkollanukkaran@caviumnetworks.com, olivier.matz@6wind.com Cc: dev@dpdk.org Message-ID: <20180716142705.GA5192@ltp-pvn> References: <20180716113311.GB3118@ltp-pvn> <1F668163772FA946975B9466A9DFF729ED315E93@ORSMSX110.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1F668163772FA946975B9466A9DFF729ED315E93@ORSMSX110.amr.corp.intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [12.108.191.226] X-ClientProxiedBy: MWHPR0201CA0071.namprd02.prod.outlook.com (2603:10b6:301:73::48) To BN6PR07MB3457.namprd07.prod.outlook.com (2603:10b6:405:64::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 334517d7-1118-4d39-6c42-08d5eb283e0f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:BN6PR07MB3457; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3457; 3:CqU/sB/idnQxkr1PU044Qr/PK15s4uI/LYUuiaGuWuVHLXi3D4A4x1CCfnyzQiZ6+JhTQfB/yeTpm+y/38v25TII5ZAqaTMmOxS5Kd/K3SBWDtxPr6UfHvWi8YzNq1I7BgVpO5FRG6UCOPT2HBljNTsKpIdAHu9fDOLVShSKpd1i+h6WlyinfDwo46bUiDrNidr+HWxd18Lo92Vzi8Gevxkm/4dWIvsS7ZzN5Z9xI880hn6RPxa1JFoqaO1sciBW; 25:gQJo4bljs3RtfRgzvuUlHXM6/YFv0VR6EAHlsFfgvH1CqZXgk1nNmONZgG7Kc8Py5PHRbE/cf6tnpeQ8B4JXlmSKs5BmRL7xzkV4x7+P670f8Yz6qtvjIqh5LWiuEpQaQOyJfMuVdV9aT/wyT2w+IYgP+xPKvUBDYE46rcgajVtkUY1N1MX1u2twWZK5GYynVMm0T5jER1YUzqcNdxi/n69hlHe97ipahnXjvdm9djJsn29xy8B4dCOyqJU3xeNlurzu60cPK9AWsrfX53LnvVBGi0/jixWZtk9hCsgBvg77yf3cbh4LhjKsfjZIhrU9Ib5bUyt20yaltzW5LmmGSQ==; 31:SB+enFlvG2pwcaRIrmtSMvjsve3UZmjHHwXTOMO1l2BKbpZ9DUhWzg2P28UIzdYcYKc/XH4HAeP+X0J7QRbgwdHna4lec/zqHQvNq48VVHZHGVv5Dfqp+wQlK8eCKoaHzocH+3rgYaCMs3e+jG7OVo1d7UZD0/AWGQAXXTq08Dm1aUrXEQuuUbYEKGXUynN+MZKrk1l5xqX8rRUpUYcFchRsb4bRjfBAsu0NPSayot0= X-MS-TrafficTypeDiagnostic: BN6PR07MB3457: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3457; 20:hgjJYpFnHuNTXQCsSjbXS59FNEi5Nukw8SBEnxjNee4bYJeC3phDJQr09hqFxpxVy09W/GR7qsU3iknuASkwC7E7vGPOiayCZ621XqJnoSad8YHm8i4aHcfv9f70nbmxHQV8FqZNJ+TDEoZ4NYTJwSaKT+PGDR8qjG9Y5eE4iUqMQP+zqwunDOh0J8obIJlz/n3hx2i8s0qD5sVDkjDtCOYFlYyk8a9oYvrzZ4IjCde86mLPwjoGbZS53+dnJkINtFLO9ALstLS+I94gK3jfcVHxVvBI+H8fx4y4E6/uYQhbGsuUH4833ajOp2H1LNzo9st/TfQwRtlBnYAwIIw/A13RKC+VAwpcnDwJjJMC12EMMXQaTMnvAKfANXL+Ja8WrUvL/urIYVwthunHjcDs+PWnkiA3SIrwOjLOvLLoTPCwWqTV2sD3TgwjfPuBdjEnzCnpL+xLnogxNKprE5XhoPTr56lTad90AshXoNZauyyZIitPVdIu3hALyPYY7Om6cdrqnk6KAk4R14h2dJuDg6ItN7ABBdRxrDttzzYbKbYI+j2MPoD5Rr3gaImD2Fgfuf1jv0htzCyF5AgmtUZPpO4TCAvg7E2rJUdnv48+C7k= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(35073007944872)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(10201501046)(3002001)(3231311)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:BN6PR07MB3457; BCL:0; PCL:0; RULEID:; SRVR:BN6PR07MB3457; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3457; 4:HrFq60C1vDDmpVH11iq4l/1jBSdgHnV0N5zLgJVu+aHAJ3h6GUdwNurd83i8mr+gYCStHy2vj7n8PYNLWxEz3yIic3W0CXhshhjITuTdXRfizRusewOfHk4+hbosygTeafObuTJAnX48SH5p8caAA/cNsxvzPqD/4im51YlRtd/OtaErxivm03xnlO1gPVXV0z6iZIxUeKWy606DM/BWnZT/S8D4tSG8tjzMbEkiBa/huuJq1wR92dbtTqnFkqRLZgmOlhFqNVniKky6ixCSjr3/Wmr4d9SDwAlKNWEODcnFje2FIEE2c5e522i2/qWhnQEgIjeaHczutsThcbsALyqK9upP7oVgqMsvq6g+PtM= X-Forefront-PRVS: 073515755F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(136003)(346002)(376002)(39860400002)(396003)(13464003)(189003)(199004)(4326008)(956004)(476003)(6666003)(446003)(42882007)(81166006)(81156014)(8676002)(68736007)(6116002)(3846002)(1076002)(23726003)(25786009)(11346002)(14444005)(2906002)(47776003)(486006)(66066001)(7736002)(8936002)(305945005)(76176011)(386003)(72206003)(33896004)(53546011)(16586007)(50466002)(58126008)(316002)(52116002)(105586002)(6496006)(106356001)(1857600001)(5660300001)(53936002)(9686003)(55016002)(186003)(478600001)(33656002)(16526019)(97736004)(33716001)(26005)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3457; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB3457; 23:3Og0YsHsZOBbpqWf6jZg0Tow/d+tiRdP0oUVxCGz3?= =?us-ascii?Q?ZtxFIfhPfT5P3taxnCn5svWiEa388SNHvv+jB24s54zLKocX359pDCD36zBE?= =?us-ascii?Q?s7BJ9SySMWFArWdAQ/VDeXNKITwkjZHtIPafSa724K1QAzxs3TIQhivT0U02?= =?us-ascii?Q?TG7jNvPIs66iBGDPqzWGia/3ymcUGbYOOYSD/ou2qU4iLzfndreBYgzOhzH9?= =?us-ascii?Q?cJcfcztQHvJNqdRm9cI4/oDDSFlhxAXURqhfz0iu0vOS9VUUsQWM2JBSH/Bj?= =?us-ascii?Q?GZxvjxFvW9DaXgwZ9YIc/RnD4DPrQRRk9jND3bXbeA8/sApwj/48nBGsJNHd?= =?us-ascii?Q?hnQpYpRv2hP4omqbLfIV6tclkv/3Ag39mA8zZbI44eYIdyshTkqYZw2Y9Vir?= =?us-ascii?Q?PbGj4RSR17M6XOXE4NybzKjLNaXgZEMYABS1VlAL5DLHkjLXb4T4GdjypqBV?= =?us-ascii?Q?1p/Fo56pWUdQZTxOvKsfMcgiKvFcWZKrHpO1Z2qfILkzsrgQCpbZWn20Jd9X?= =?us-ascii?Q?bkCNs8riaQY/drmyiiHN/KFgQ2Px0fbKBwIPOSc5Tc7vEjmaImioDRnikNft?= =?us-ascii?Q?FsFLuguqn827JFYLK4RgiJmr5E5HkuVMK02eLHZJoLox8STIoM1xkGas0cEe?= =?us-ascii?Q?4o5Tt0JkOemHDcaExfEb+Z0l47C2Nvn0riStBJMlUdLCLgTaftP8yd1zImba?= =?us-ascii?Q?7uyYthp/KBMy+mfKknaRXleSl2GuXJXlFmGtCeT5bK+YkNosMITa8wVqxIpd?= =?us-ascii?Q?9Hcb+1+eSxKwQ6xT3ELWLjq6is7FlTtuWezpVu5K0iMPn9tjmQDHD5sXyhVM?= =?us-ascii?Q?f2sOFdFW6qz5oZDtg/zhgFugL8IF9XQ1wJJBuc495mvHzKbzS5bQD7fOfP6q?= =?us-ascii?Q?LRpNhJAt0gAWTgcl3hS715uT0gb4bIUq3t+XA19TAbZx0Dwgb1FKBzlTDU0V?= =?us-ascii?Q?uqDrGykLMlMHm0f+ZSDtqvJs6ll9hUtNC7q7IKcfdoJbbGmDBKAlhnvRv8iQ?= =?us-ascii?Q?rTGXAmTUzBu+sFnTZFNKU9FgNcH5wHSRCtJzWidii88PU3NWW7jQ5yi2ZqWC?= =?us-ascii?Q?/ARiLuEdVAtpEjcnd2rzisU4RpRkerr0RJYLz/20VCd9cnJab7sejizV07vm?= =?us-ascii?Q?pTWW5ldL8784/OtIwFdEK531JavJwBLfBYd1W6WakOjbF1DQSXLRArQT2s/r?= =?us-ascii?Q?EkYgx+Kyy4ujtqywPC/gXOF4332LBe9hKtQLBB2yAAqH6qLrjnx03laBmFxe?= =?us-ascii?Q?3vrVSYRfJR2cWAAQwD1JOgNRwouCrXg4eqQSNJuRqDwjmFPtEu61sGH47kmM?= =?us-ascii?Q?ZvaA4C/VAhTrpxQ7NkffOtwUEqQuGGWk3bmc/aRWrLLH31/vlosKp9d1x52J?= =?us-ascii?Q?MFh0w=3D=3D?= X-Microsoft-Antispam-Message-Info: zKnI03A5PUikbi4wPwMaT0t7Svr0iEnQQtESYzFqB+Act7EOYeb0/NUut7uVtobxVuP+WpY5sBDU0bU+bDiS/KQYi3cT8eaKgX9qXfxLHTsvXkl/hjQSBWLpSmlS0OsRroKCE62pvmB79O8G/rPUTqauhmVCcOS8Kxyb4CD02N8/vXTUYnSORM+6vlLAZ7G3chbhmEpRa84R88iDvrElmiVB5FdQvgzK/WT0OccWDp142YoZfwHZmOyhX8ehNecdT6tcWHHP18928aIlSoLdhBRIVLmGWX+3o8+JKzKvV3yisKZfaiMVFfWENOMJC7nirV9veTm8qd6xBOalkPDLkBxzflTjQUjREJpjkMP6hM8= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3457; 6:iQYS9TvMVDpwZAmmGM/VmngOe6HwkpWD6C5JxA+Swef9blSkimB+9dR2l6lpz6cLoPXOmHHlxEMNwWH//A1vv2UQ7Q/RrlRaOxUerddakSjFILkYXYqsAND1/plBF1X+tfSXKiiyeFFFP/Nkcc63c4S2vqDSNBptl0sRQT92CgN2cd9aZkuiZeNElrdiM+tm9FzToX5+bDoXK10ZzyHwEWDLXArQjUZvvHD+YrVOnk9g4ayVowdjlGJd9C77axyUlN6i+XLBdm0eDuuUE5eW3tZWB7mWi7yxaZfTSk4ydx7pNzsfNMQI8KeaIhw916wDM4rWUK4h0OJDjgbD0/oxcuY/wOVGU2mK5QFutnSVNTZOvpx1onj42JyR0g+ie9BF/xQtoiQY39o/u8thDZ/tNM4rDRu+AE54cwbfgATryyL2ee/3MMEWQQcQe+GTFIwqY456ht2z9VAUhJkCNqq3wg==; 5:mSp6EZaruB4BWBYLuNhxK2WeGSNE8+eFUCbTg7m9j21gMAi+5VrrJsviRKIUInJD6QJgG7wXQwy6JRBW4vvCwU2ukBbLRwkixBPFQFvI+D0SC2f8S2cE0rdHE8zegDFmORZic5Gv1kSuyyhYQlEU6XPAEzNOuZPvZfG+9Vkc2ao=; 24:12AsiOtzdgDfCYEF5g52khJAwVKug69na8EN0+t//KBLHxeJYiIfiUZr0+h1fT3dKMvatiM0bohUrJSFMc0o/b6Fdkjzela/JST68b6hkqw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3457; 7:RBlDX0+kmDZ+965eqSQ7C9/hMcHv/2bsW5Fna2/t4VTlRnvvsFNbjHdtZFyNUbRv9mlu2DhG1LpWHEvK4y31E5l0aJ4umFa8VtzrKUrdyjFvyAlK1ppyFsxOks53Inr3La1GkLpto3UxRGqbFnBCw0rIIMciUPmqkXHQa2eF4Jvz5wFMxd6Yw3xH+ODbv8rxBeu92JPuEa+7SREOaNwXZwu7ZgiRCahbf3emIfhsUk9JHNSAvpvTUEJXx9nib128 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2018 14:27:19.1003 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 334517d7-1118-4d39-6c42-08d5eb283e0f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3457 Subject: [dpdk-dev] [PATCH 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2018 14:27:24 -0000 On Mon, Jul 16, 2018 at 02:17:40PM +0000, Rao, Nikhil wrote: > > > -----Original Message----- > > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > > Sent: Monday, July 16, 2018 5:03 PM > > To: Rao, Nikhil ; > > jkollanukkaran@caviumnetworks.com; olivier.matz@6wind.com > > Cc: dev@dpdk.org > > Subject: [pbhagavatula@caviumnetworks.com: Re: [dpdk-dev] [PATCH 2/4] > > eventdev: add caps API and PMD callbacks for eth Tx adapter] > > > > Hi Nikhil, > > > > On Mon, Jul 16, 2018 at 11:25:45AM +0530, Rao, Nikhil wrote: > > > On 7/10/2018 4:26 PM, Pavan Nikhilesh wrote: > > > > +int __rte_experimental > > > > +rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint32_t *caps) { > > > > The caps get API needs to be similar to rx adapter caps get i.e. it > > > > needs to have the eth_port_id as a parameter so that the underlying > > > > event dev driver can expose INTERNAL PORT capability as not all > > > > ethdev drivers have the capability to interact with the eventdevs > > internal port. > > > > > > > > rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint16_t > > eth_port_id, > > > > uint32_t *caps); > > > Hi Pavan, > > > > > > Is querying the INTERNAL PORT on a per ethdev basis useful to the > > > application ? > > > > If an application chooses to use 2 ports one with INTERNAL PORT capability > > and one _without_ it then it would be useful to have per ethdev based > > classification similar to Rx adapter. The application can classify events based > > on event type RTE_EVENT_TYPE_ETHDEV & > > RTE_EVENT_TYPE_ETH_RX_ADAPTER to segregate between INTERNAL & > > NON-INTERNAL port at ingress side and enqueue it to either > > rte_event_eth_tx_adapter_enqueue or to the SINGLE link queue > > respectively. > > > The current tx adapter is very similar to how the eventdev pipeline app decides between using the generic_tx v/s worker_tx, I guess what you are suggesting is using the 2 concurrently. I am fine with this, > Would you always assume INTERNAL PORT on the Rx side to deduce INTERNAL PORT on the tx side ? Just curious if that was just an example, in the general case, you could have packets ingressing from an INTERNAL port and egressing on a port that is !INTERNAL ? I was just giving an example :). The application would be free to model the pipeline accordingly based on event type and caps. > > > Also, I dont think eventdev should iterate over all probed ethdevs and give > > the overall caps as an application might want only a specific ethdev to be > > connected to the event tx adapter. > > > Agreed. The current adapter only supports either the generic_tx or the worker_tx models and selects either at the earliest point it is feasible to, > > I will update the patch series for caps_get() > > Thanks, > Nikhil Thanks, Pavan