From: Kevin Laatz <kevin.laatz@intel.com>
To: dev@dpdk.org
Cc: jasvinder.singh@intel.com, bernard.iremonger@intel.com,
Kevin Laatz <kevin.laatz@intel.com>
Subject: [dpdk-dev] [PATCH] app/testpmd: fix logically dead code
Date: Tue, 17 Jul 2018 11:34:05 +0100 [thread overview]
Message-ID: <20180717103405.6793-1-kevin.laatz@intel.com> (raw)
Remove logically dead code, tm_port_rate cannot be greater than
UINT32_MAX.
Coverity issue: 302846
Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode")
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
app/test-pmd/softnicfwd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/app/test-pmd/softnicfwd.c b/app/test-pmd/softnicfwd.c
index 1f9eeaf..7ff6228 100644
--- a/app/test-pmd/softnicfwd.c
+++ b/app/test-pmd/softnicfwd.c
@@ -175,9 +175,6 @@ set_tm_hiearchy_nodes_shaper_rate(portid_t port_id,
rte_eth_link_get(port_id, &link_params);
tm_port_rate = (uint64_t)ETH_SPEED_NUM_10G * BYTES_IN_MBPS;
- if (tm_port_rate > UINT32_MAX)
- tm_port_rate = UINT32_MAX;
-
/* Set tm hierarchy shapers rate */
h->root_node_shaper_rate = tm_port_rate;
h->subport_node_shaper_rate =
--
2.9.5
next reply other threads:[~2018-07-17 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 10:34 Kevin Laatz [this message]
2018-07-17 11:16 ` Iremonger, Bernard
2018-07-26 17:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717103405.6793-1-kevin.laatz@intel.com \
--to=kevin.laatz@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).