From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id C08671C01 for ; Wed, 18 Jul 2018 15:10:44 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id r16-v6so4624441wrt.11 for ; Wed, 18 Jul 2018 06:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=KAiLZHhczwrUM/LHrPFtrOQd+vfH2O6t6sYuCSrfnvQ=; b=Vka3tDRTZ+wemCTrduPCk04SjBayWB0QlSz/qqQfXWLvcOS+mg5iRCaCFABX55+zGE UwPJwVGIjSJiMW2H5c7dQBiYulgaKR0J1/Z+oktxL8TjqkyOTcyAnxwUzQAwTKEcVe9y 8Nk+vVvHHwktDa+0ClQ53x/aZt9mUuLu4+C9iZAOVGEygfN82ok73jxbtKZPG+96oLEf 1EmxNvkjUfLrgFKiWy+FoSz7VUIwUab9qkchp5Y8hmtyFyR5nlm1z1Ytc8OHzeG4SiJk 8Ek+RI0QifPH6xbUdlLLDjlJ4EP4yogCutRLa/U5pcLiWV02CyyZaalgV2upcufamGUu qIfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=KAiLZHhczwrUM/LHrPFtrOQd+vfH2O6t6sYuCSrfnvQ=; b=bqfF/KBv/p0Oobpg7jDhkr52ujRUcRu6+71aFPS/c9OR1FisGIf2ttYc8sgtN6ZE9L Gpb7agPWj7fCyHPgf0iHBnnWloxULgNa90PhuN0aCmzYGiYcLJG736jjZbm2y9wHF9sc W8sdAVGLGqsZ5Iphf8nP7YK+vAMoOEh+bv9lvj0RYddQDAOu/6hBo+k1X2n9zRCWxf59 v4LahoDtjjsYqtbnN1sI+z1kwBSBdEhxtvD4C2kOmdR8SSzdTH7W6kOhwN4CDq9ryW7I mEQ76PRcbErCzwV4tIzvp8qTFOy1Iw6QHuySE1cA8u/c610pyQX+aEAuVoSFQj9o5mQl eRpA== X-Gm-Message-State: AOUpUlG9TIOn/fzHNL/nTGLVZZF5aLr4j/YRQa0VLpoJpd8dytTJ2J6L 3YAfvL3251VzAg4kfleXTErgTg== X-Google-Smtp-Source: AAOMgpcImS0A6MQw1YAgXGROzvcVfmhc78k2iyGjveBC1EICXhjU1fGOWgA7VDc27EElpRlhdQ14Uw== X-Received: by 2002:adf:fac1:: with SMTP id a1-v6mr4283059wrs.74.1531919444493; Wed, 18 Jul 2018 06:10:44 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id d14-v6sm5872467wrr.12.2018.07.18.06.10.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Jul 2018 06:10:43 -0700 (PDT) Date: Wed, 18 Jul 2018 15:10:26 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Qi Zhang Cc: thomas@monjalon.net, anatoly.burakov@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20180718131026.3qfymf45meglfuea@bidouze.vm.6wind.com> References: <20180712140144.18146-1-qi.z.zhang@intel.com> <20180712140144.18146-2-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180712140144.18146-2-qi.z.zhang@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 1/4] eal: fix hotplug add and hotplug remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jul 2018 13:10:45 -0000 Hi Qi, On Thu, Jul 12, 2018 at 10:01:41PM +0800, Qi Zhang wrote: > If hotplug add an already plugged PCI device, it will > cause rte_pci_device->device.name be corrupted due to unexpected > rte_devargs_remove. Also if try to hotplug remove an already > unplugged device, it will cause segment fault due to unexpected > bus->unplug on a rte_device whose driver is NULL. > The patch fix these issues. > > Fixes: 7e8b26650146 ("eal: fix hotplug add / remove") > Cc: stable@dpdk.org > > Signed-off-by: Qi Zhang I think we should consolidate this API at some point, maybe list the possible error values as a part of it and remove the experimental tag. In any case, the fix seems correct, thanks, Acked-by: Gaetan Rivet -- Gaëtan Rivet 6WIND