* [dpdk-dev] [PATCH] devtools: remove NFP from test-build
@ 2018-07-19 3:03 Pablo de Lara
2018-07-19 11:11 ` Alejandro Lucero
0 siblings, 1 reply; 3+ messages in thread
From: Pablo de Lara @ 2018-07-19 3:03 UTC (permalink / raw)
To: alejandro.lucero, thomas; +Cc: dev, Pablo de Lara
NFP PMD does not have any external dependency.
It only requires Linux OS, so it is not needed
to be enabled in the test-build script.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
devtools/test-build.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index 3ea82bb46..f6db99fb0 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -153,7 +153,6 @@ config () # <directory> <target> <options>
sed -ri 's,(PMD_SZEDATA2=)n,\1y,' $1/.config
test "$DPDK_DEP_ZLIB" != y || \
sed -ri 's,(BNX2X_PMD=)n,\1y,' $1/.config
- sed -ri 's,(NFP_PMD=)n,\1y,' $1/.config
test "$DPDK_DEP_PCAP" != y || \
sed -ri 's,(PCAP=)n,\1y,' $1/.config
test -z "$ARMV8_CRYPTO_LIB_PATH" || \
--
2.14.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: remove NFP from test-build
2018-07-19 3:03 [dpdk-dev] [PATCH] devtools: remove NFP from test-build Pablo de Lara
@ 2018-07-19 11:11 ` Alejandro Lucero
2018-07-26 8:31 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Alejandro Lucero @ 2018-07-19 11:11 UTC (permalink / raw)
To: Pablo de Lara; +Cc: Thomas Monjalon, dev
On Thu, Jul 19, 2018 at 4:03 AM, Pablo de Lara <
pablo.de.lara.guarch@intel.com> wrote:
> NFP PMD does not have any external dependency.
> It only requires Linux OS, so it is not needed
> to be enabled in the test-build script.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> devtools/test-build.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> index 3ea82bb46..f6db99fb0 100755
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -153,7 +153,6 @@ config () # <directory> <target> <options>
> sed -ri 's,(PMD_SZEDATA2=)n,\1y,' $1/.config
> test "$DPDK_DEP_ZLIB" != y || \
> sed -ri 's,(BNX2X_PMD=)n,\1y,' $1/.config
> - sed -ri 's,(NFP_PMD=)n,\1y,' $1/.config
> test "$DPDK_DEP_PCAP" != y || \
> sed -ri 's,(PCAP=)n,\1y,' $1/.config
> test -z "$ARMV8_CRYPTO_LIB_PATH" || \
> --
> 2.14.4
>
>
Acked: Alejandro Lucero <alejandro.lucero@netronome.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: remove NFP from test-build
2018-07-19 11:11 ` Alejandro Lucero
@ 2018-07-26 8:31 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-07-26 8:31 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev, Alejandro Lucero
19/07/2018 13:11, Alejandro Lucero:
> On Thu, Jul 19, 2018 at 4:03 AM, Pablo de Lara <
> pablo.de.lara.guarch@intel.com> wrote:
>
> > NFP PMD does not have any external dependency.
> > It only requires Linux OS, so it is not needed
> > to be enabled in the test-build script.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >
> Acked: Alejandro Lucero <alejandro.lucero@netronome.com>
For reference, it could have been removed when enabling the PMD:
Fixes: 80987c40fd28 ("config: enable nfp driver on Linux")
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-26 8:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-19 3:03 [dpdk-dev] [PATCH] devtools: remove NFP from test-build Pablo de Lara
2018-07-19 11:11 ` Alejandro Lucero
2018-07-26 8:31 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).