From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 534C2548B for ; Thu, 19 Jul 2018 18:32:04 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id x5-v6so4225266pgp.7 for ; Thu, 19 Jul 2018 09:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YQ2KCV5M1MpgRbcLMYHfBqtqJLx3unIfEiCrK2I+bMM=; b=R7tle5fBoKAST4ahCVxkJe/iFIAVLByh1iB/uOlh6X/GhoUUiHeBKlZJvgkF/IyjYO WAhcnh40vyCruZ8HM3mrsvGZEmJfxNKBdxPi8NR26uJe/+DT9HdZmX348TZkZIOYrzk4 W9GR1bT4qHCdHx5qOm/dihZI5bpK/bDUCLKThdnX64jI8n0enjPi/GbFvrPwbeASHoJu 9D352Yof0TcAlu+Hai2DSoI1YntGw0KRyVOLlC2PHtgWyNZYOecHxqmBqezBVPIIDRGJ BnSZepoig6vyO/oS1DpUeapm+fq/vt/bGdjJumcTKN4d55Lhcmseg6HLYn9aoGHySfSj snpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YQ2KCV5M1MpgRbcLMYHfBqtqJLx3unIfEiCrK2I+bMM=; b=ZclFbR23A+b7XgbKGVwKg4mNL+T+6XThCn5GlDOugfaUFVhzvj1YcWbPQIiVCBMR/+ bRa2AE1Ocu37SDEkLy3kQpbx3w/B0FnX8FLnNTuf9mgGM2Vnwx81+Fe37UO3WYr6FfA3 hHD/gdv7fmN2NgktWy9hcs/djecStmkgrpZSS4gqVj7pGaslmDVScFETrmuiUmx0HNTw QdZEz/gyZ4qnVEbJZIcLYcuBGu65styIzIOEo7ih/7zxbbw2WblIV3E0GhLmQi0qp2nA QsaVsEcLiTpYuGpX89kJ4v1JI0dNDGXNB0JADRbp2ZjBTJ8p8L3dJZgp8Q8KF4tbtX4C 1U2Q== X-Gm-Message-State: AOUpUlEp8+rWTwkYf/0/Bwb9kYP9fCEuIodbvtUD8YGqrdlY38d+Ov/9 iL3pfqEsaO/c9rPcJ0VkPewQeg== X-Google-Smtp-Source: AAOMgpeh+TO3rSBIabcKoJ2avXm9ZSYCLmEJ2FI4g2MJliiyllddYIdJyIsQ7RmK3P7bGF5sFjI7Ug== X-Received: by 2002:a62:930c:: with SMTP id b12-v6mr10169273pfe.193.1532017923487; Thu, 19 Jul 2018 09:32:03 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id u11-v6sm19905714pfd.117.2018.07.19.09.32.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Jul 2018 09:32:03 -0700 (PDT) Date: Thu, 19 Jul 2018 09:32:00 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: "John W. Linville" , Declan Doherty , Chas Williams , Gaetan Rivet , Tetsuya Mukawa , Santosh Shukla , Jerin Jacob , Keith Wiles , Maxime Coquelin , Tiwei Bie , Zhihong Wang , dev@dpdk.org, stable@dpdk.org, Vipin Varghese Message-ID: <20180719093200.6095b52c@xeon-e3> In-Reply-To: <20180719164556.93162-1-ferruh.yigit@intel.com> References: <20180719164556.93162-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] drivers/net: fix segfault in secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 16:32:04 -0000 On Thu, 19 Jul 2018 17:45:56 +0100 Ferruh Yigit wrote: > Calling rte_eth_dev_info_get() on secondary process cause a crash > because eth_dev->device is not set properly. > > Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit Good catch. Maybe eth_dev should do this for the device drivers? Better to make device drivers as simple and safe as possible. There seem to be a lot of bugs related to secondary process model. Do we have a test suite for that.