From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 3A0622F7D for ; Thu, 19 Jul 2018 16:15:22 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2018 07:15:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,374,1526367600"; d="scan'208";a="55584200" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga007.fm.intel.com with SMTP; 19 Jul 2018 07:15:18 -0700 Received: by (sSMTP sendmail emulation); Thu, 19 Jul 2018 15:15:18 +0100 Date: Thu, 19 Jul 2018 15:15:17 +0100 From: Bruce Richardson To: Tiwei Bie Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org, yinan.wang@intel.com, lei.a.yao@intel.com Message-ID: <20180719141517.GA23224@bricha3-MOBL.ger.corp.intel.com> References: <20180717131035.15635-1-tiwei.bie@intel.com> <20180719033731.GA25092@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180719033731.GA25092@debian> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.0 (2018-05-17) Subject: Re: [dpdk-dev] [PATCH] vhost: fix buffer length calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 14:15:22 -0000 On Thu, Jul 19, 2018 at 11:37:31AM +0800, Tiwei Bie wrote: > On Tue, Jul 17, 2018 at 09:10:35PM +0800, Tiwei Bie wrote: > > Fixes: fd68b4739d2c ("vhost: use buffer vectors in dequeue path") > > > > Reported-by: Yinan Wang > > Signed-off-by: Tiwei Bie > > Applied to dpdk-next-virtio/master, thanks. It would be great to get this patch into main tree ASAP, since meson build with gcc 8 is currently broken on master. [Using Fedora 28]. ../lib/librte_vhost/virtio_net.c: In function ‘rte_vhost_enqueue_burst’: cc1: error: ‘__builtin_memcpy’ forming offset [13, 64] is out of the bounds [0, 12] of object ‘tmp_hdr’ with type ‘struct virtio_net_hdr_mrg_rxbuf’ [-Werror=array-bounds] ../lib/librte_vhost/virtio_net.c:636:34: note: ‘tmp_hdr’ declared here struct virtio_net_hdr_mrg_rxbuf tmp_hdr, *hdr = NULL; ^~~~~~~ cc1: error: ‘__builtin_memcpy’ forming offset [13, 64] is out of the bounds [0, 12] of object ‘tmp_hdr’ with type ‘struct virtio_net_hdr_mrg_rxbuf’ [-Werror=array-bounds] ../lib/librte_vhost/virtio_net.c:636:34: note: ‘tmp_hdr’ declared here cc1: all warnings being treated as errors ninja: build stopped: subcommand failed. Regards, /Bruce