From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 3D830160 for ; Tue, 24 Jul 2018 02:50:52 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id y4-v6so1565975pgp.9 for ; Mon, 23 Jul 2018 17:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ovg010ADV50QWhOGIQU+HobERGZOtMe2CPLFC6c9HDU=; b=H4de+wJtWUmACBGi+ib0OQIti0z9GXcEJkCW0URS/tJsdDsWf07dYMXyGT8dHdDT/M pSB0+aSzxjkL6hbqM/6ufPFKf0GRaOMPaSbdIqB1IJbPfBUbxmq47U3vxNXtofcNNuYW s835gdoOF+3fRFfww+YkZZXA7Dcc+IxBraD9xt3r+lTbn8wU487KGwlF4ZMTfM1FykSZ fpha4U+cJJ+jhFOY0FEPUaMPw+kT/F6YTypZPbLlkUvvraWSDWxpxYqsl2aOQgnr1SV4 YKcfiFzCbIxUxbvo3ybxrvMEjOJM8h4vHIwlrnRG6a1ECPPra0E96PZQIcNO9frCqvDf FM+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ovg010ADV50QWhOGIQU+HobERGZOtMe2CPLFC6c9HDU=; b=Oet7R8cVKyrpZc8vI7XooUNBhTx3fPTZebBwUMmwRghT3aLD+AiqCM18/6UGlTLa/j +Hjt85XwB1WAeLpOxpHg1sSdzHQMFjE7p53fZdNZfqS608UfSv4bA5kA/QM9Qn2c8BlR Mrl340YSkA1vj9rs8Q/9gGx2HLqhsBoxgIbQJVX/Sqa/wGG6VwcP5nbNMQfURq+eG3S8 PIjCdyuMKcHGZSY/gNAoavLnwrvlq3YJQwUOce5ctswxXh7dc8KJnr41nflTBmO9uNV9 KgAxhFjZq6j8jmw4SXqH8IKsXLxZJE1czZWAeuxSFsC20mXC8v3EF1ssyT6QpqbA+RiP 6rKg== X-Gm-Message-State: AOUpUlGkrw/BQ2YaSoyA3ZP5UQsFTgrnEIyIAB3eW1JylzJfaF9itiyc shBu4h90Cl1dQcbuLYr6K0Y8VQ== X-Google-Smtp-Source: AAOMgpdohYbO7SBOIoe0Y88wn8hcif4d+xnciFC8y10l0QJQnwDDDGeE7Er0Rbp1hYkwLWBv4zjVgQ== X-Received: by 2002:a62:34c4:: with SMTP id b187-v6mr15267584pfa.15.1532393451203; Mon, 23 Jul 2018 17:50:51 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id d132-v6sm14920990pga.10.2018.07.23.17.50.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 17:50:51 -0700 (PDT) Date: Mon, 23 Jul 2018 17:50:48 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: Adrien Mazarguil , Shahaf Shuler , Nelio Laranjeiro , Yongseok Koh , dev@dpdk.org Message-ID: <20180723175048.3fcdcc7f@xeon-e3> In-Reply-To: References: <20180627173355.4718-1-adrien.mazarguil@6wind.com> <20180713092910.26276-1-adrien.mazarguil@6wind.com> <20180713092910.26276-2-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/6] net/mlx5: lay groundwork for switch offloads X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 00:50:52 -0000 On Mon, 23 Jul 2018 22:40:47 +0100 Ferruh Yigit wrote: > On 7/13/2018 10:40 AM, Adrien Mazarguil wrote: > > With mlx5, unlike normal flow rules implemented through Verbs for traffic > > emitted and received by the application, those targeting different logical > > ports of the device (VF representors for instance) are offloaded at the > > switch level and must be configured through Netlink (TC interface). > > > > This patch adds preliminary support to manage such flow rules through the > > flow API (rte_flow). > > > > Instead of rewriting tons of Netlink helpers and as previously suggested by > > Stephen [1], this patch introduces a new dependency to libmnl [2] > > (LGPL-2.1) when compiling mlx5. > > > > [1] https://mails.dpdk.org/archives/dev/2018-March/092676.html > > [2] https://netfilter.org/projects/libmnl/ > > Just to highlight this new PMD level dependency to libmnl. > > tap pmd also uses netlink and vdev_netvsc also does nl communication, perhaps we > can discuss unifying netlink usage around this new library. > > > > > Signed-off-by: Adrien Mazarguil > > Acked-by: Nelio Laranjeiro > > Cc: Yongseok Koh > > -- > > v2 changes: > > > > - Added NETLINK_CAP_ACK definition if missing from the host system. This > > parameter is also not mandatory anymore and won't prevent creation of > > NL sockets when not supported. > > - Modified mlx5_nl_flow_nl_ack() and mlx5_nl_flow_init() to consume the > > least amount of stack space based on message size, instead of the fixed > > MNL_SOCKET_BUFFER_SIZE which is quite large. > > <...> > I am concerned that this won't work on FreeBSD and it will end up farther behind.