From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0052.outbound.protection.outlook.com [104.47.36.52]) by dpdk.org (Postfix) with ESMTP id 67FCB98 for ; Tue, 24 Jul 2018 17:39:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ph45vmO/wLaBSBfalGZPDkdFyEWScL9G+ObhnsFD4SQ=; b=TRKlVFzfo4E2C0981/0XYEPig/VaccMWt+JwWquVITFGOVJI8EkJwm9ScxSRFaeDrRdMUwuiHvsHTcbqFB+rIP7ryOOkedCPvm7071+GKqfmQBZDFwmxNoGrOK5Pi6yhQtMckI01u9hj2Ur26RHk90ENSBKOWcip2LY2XY+BE5Q= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (50.233.148.155) by BL0PR07MB4995.namprd07.prod.outlook.com (2603:10b6:208:49::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Tue, 24 Jul 2018 15:39:13 +0000 Date: Tue, 24 Jul 2018 21:09:04 +0530 From: Jerin Jacob To: Pavan Nikhilesh Cc: santosh.shukla@caviumnetworks.com, ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20180724153903.GC11073@jerin> References: <20180724104350.20652-1-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180724104350.20652-1-pbhagavatula@caviumnetworks.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [50.233.148.155] X-ClientProxiedBy: CO1PR15CA0098.namprd15.prod.outlook.com (2603:10b6:101:21::18) To BL0PR07MB4995.namprd07.prod.outlook.com (2603:10b6:208:49::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7e9cb0f2-1166-4590-fe3e-08d5f17b9cbd X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4995; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4995; 3:y17XhhB04GqKaaAtX1zEeLReG8IZZbF0GqYVIcxmGrxkXz5HT9GysDJCYF9/uIZ+VAPD3kbN/YWzZ5O8G9z1wdjOVVDV76TVPeshiRr3qPgy67kBtP0isdtGKfJIgGX991AFAsBcqUuaThqdvLaC4Ux1uTnSUkTzTjr9cd9oibz55cVGcR4qQ7rJqWqhJmsAPdIjyHAD4oLsSX1c2lzrtWCOoC8ouggKNkv2Bq7HfzCqCTnP+Lrq48WI/C67Axuf; 25:oQp48Kp5eaM/GPn9FdtdyP7+wUxMse8umNdbVjR5moJHO3Zn6YJbQZHAvTfub9jIuMe2wlIXUBdOo+Mhw7s5RzaE17zHQr78LXnbOQwAETpBPLtzS6zje8ugIhXSHFl78KzpbXFiOYeRHAOqlPc7+gPNxG4Rvi5DbeiKN+hWgkNqq3O9WwgcrSDdX4QaWjKr2rQkdHbbsw7+BUeawQwkAa966GNW1hmwQX3pE7pj0wJQHvZ3OF9XPWgV54zJZ77nAODm5Mj3KgHT4sEnvtKexIylP22E7H9/xyIhYFqglDSX0ah7T3XVQnNgeW7Iflq7XKmU7C1K1xGyKcRiLVC+dA==; 31:19F8bcF3fL0af0SuIM4Xo62Kx2QGrjOiYMMiBHUzoWYHmPUERZlMhjZBG5IXxepE2ktd2QLFuh4k+QXOPgXdISHzj7yWaQUo9xBRsK4r/KNXBSPG3HHKFlbv7BG3t1kVsaWqYwRf6G9aJbY3jXbIZGmH9Ycl3v2/gABZtY/73TVjW5ZdUc18FKN/dELdwzmtViA+IVHA+IFY5OAEx11AoMhHUiiJou79cRxljF+cIXw= X-MS-TrafficTypeDiagnostic: BL0PR07MB4995: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4995; 20:fhIdXLWxsG/e+LrZl/DQOPgDFHZd8r0vrNfEBqN791n9WKB5ScrWG5BCG+bFpHwtLG22QGS9UbTGlZ8kpXYeypHd1Kpdrfz47UCbJIogvd3rkZEdpKD7bw0kdLBHBiVXa9BBnP5CVnkkInBRK3wa0sPRVfxemdh1RCYT5kdDGgG6fVepQsc5rxeRXdPyt5i+0kI6OawXhc/XMUyGn8RKeNOro0Vc6plE8FwXnpqllg8clHqHsrw3jlkZwSNmEJgXfHCpf+Bjp++TNC59HZ1qFXC1XpamIZWTpjKqbiFxuXcWR0h6N1UdjTT0+mTwDKYRiW6/0t+r1Sr6gg+5XMC+53kmylGBtCcCco7PMqi9lLokla7nJnO3J3GU/Heit2hMY5U8e+hdCJ2fmGrvjo6jQp3dlCaXySRSOVqRSjOxsC9PM9t+gvI4P4eaxkU3d/IQA76fz4QZ1RhmBoXUNrK5Z+x/gVerIkGA0rPX+uUcXxoKd4VXogJIHS4tuE/s9gFtpjy9gbLkGoiyjb9gPzWbc3hbBxyEUnbulJQ5tHlsBXbi9rurU0oKxZ4t9qjg9BLj2PnkPkm6XATqLZW2U/jC9c64VFc6OUTK2XEHggm8L1U=; 4:P7IzfpeGntKOwkrVWJ18ieqwrury6EhNdCpoenieJqGilMCgFUyD8MNwv50kDJuvMLu9hSYV6L6D2fSW5UuBGaQTEeFMZisDeYT7zEWP3f7B4e3hSFKWPciukkn9mgzsYcTM6+TuXfsSW/YmoX3XPc30VXSyM41LwtZ5ZlyFslEOEkqlpOIOY3tCwSCLhJfVT5M9bjBf5g9+CNzpEDbllbD00KoZHylPpUWdAuzoIPwOqA39Rep4PfIlVLFIoLgdAGyj1KbZWf6sb3ByPh5hvqlZMdjMN2YlC/Jn4UYdo6QsTZL42Y3Er6xM4XI5GSLv X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(3231311)(944501410)(52105095)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:BL0PR07MB4995; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4995; X-Forefront-PRVS: 0743E8D0A6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(346002)(366004)(376002)(39860400002)(136003)(199004)(189003)(13464003)(66066001)(50466002)(478600001)(1076002)(3846002)(6116002)(23726003)(486006)(72206003)(81166006)(81156014)(6666003)(42882007)(6636002)(55016002)(956004)(476003)(8936002)(97736004)(9686003)(2906002)(6246003)(68736007)(14444005)(33656002)(16586007)(6862004)(58126008)(4326008)(316002)(105586002)(305945005)(229853002)(25786009)(33716001)(11346002)(446003)(47776003)(76176011)(8676002)(386003)(52116002)(26005)(16526019)(5660300001)(44832011)(106356001)(53936002)(33896004)(6496006)(7736002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4995; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4995; 23:beU/e8V0mp4DdubJXkZL0NEZtZJB5wqyuGLoh74MS?= =?us-ascii?Q?AVVMsTtFRfvtVWluTGMLSBgv5+K2znN9hd7Xqs4HEPwopw6bbmY69Up8H//t?= =?us-ascii?Q?cERnVD7/RXv6rJGdN44ETILLWu+walDe1i92uYSR330Oz9gi+/faMMSghbZp?= =?us-ascii?Q?jhGYYYom70q9n6Tuxwse3RwrcjjnkBpyZTrm2LrSxnVK1AiaQJbPR0V2L86D?= =?us-ascii?Q?+1bUjeUl5hNFTJdK3jwTM+fKtu79ZP1edB+juIZoANQHYxyR5uV1a+gvkaqv?= =?us-ascii?Q?AOCocgi46w1/BH5PHDR7AiqoPoWtdBDVPeZc+aQXF8HbnixHPHAA1GFi/Ytx?= =?us-ascii?Q?Kw5cyXe738RiT7UVomWQMfiQiC9Qc7TSo3eoAnzvAehQhr5hpT1za8YoxVqC?= =?us-ascii?Q?dPOzwh4LKJBiepwky4zOBBFBluX4aICCB1u1qOziabyOoTMNGv1/euVgWNCp?= =?us-ascii?Q?gd1u88/Vc6Zqjt6ESN7LELDUxYwBe2miIgjL2+b0oXcKy5dkbKHvXWXsBsI4?= =?us-ascii?Q?hmceChK0lghlEclUZDaesgWtZ/zaiTOgmiKYqTvCkWB28do3BgXmkk9KQILj?= =?us-ascii?Q?FNVhuL9tuJY2bqvzFN4mCUIatat1Vq9pzkoVmlud9o/0ub03/Y2oS1y/NCgq?= =?us-ascii?Q?qeUO1aItutbU+en5HAJBgsvApKevk4HAYYsEhuvdNyiDY72/VsJ9ZUGDVGwk?= =?us-ascii?Q?gWgYWrQIfS8PYNmmtv03FZOJfdCTzz8m5FGxcxbeDB8qN66bCnya2Krh9qQA?= =?us-ascii?Q?WOd0HSVa+mY9LF59eYbL700Vz2czohBij/UFKenVErFv31fFPhe98iixSyei?= =?us-ascii?Q?0sAWuM+9FSZKoDyp0xHq67bnqwB8xLToJL3XgA4SlFOshaWDGDb16vso4wZM?= =?us-ascii?Q?6CPu3kWHppFdRT7CdBbxMqiM6kFku91I+1N7sz37cGVTKKzL+mhBPsffT+lQ?= =?us-ascii?Q?rPpAtipCIaVov1jg46JX63hw82A33eQ+d0AebuIHa8ocT7qPfdYHwhfLAl3R?= =?us-ascii?Q?PWoA8wAgoqS8LlJT07wRLygYmJpF7Ad6cto0KMNg8/yLRPqxrUxCKhIDVIss?= =?us-ascii?Q?eVgWOlYj8G3TtRk52bPjtAoWD2Tv/jiSv4K8PGkd/EnAYZ9BjhmWFwDPGlBY?= =?us-ascii?Q?Qv8h888vMikP4fga0/aACyrxvSbB0Eix6APCS/hmHyiKCpZHLTWp6JR6loIJ?= =?us-ascii?Q?JQkLME/4qsry0jxrWHyF8P/TggAPCOE/MP/rQyjG3QSiX39JvRpF2gkGjulu?= =?us-ascii?Q?kSi3AzHYH0vN5cwwIUw3XCVLVGQR8K6fjL9iUQZfuSR+0a5BHuOiUAM7u1kT?= =?us-ascii?Q?ld9V5/Yu4hd3KcO6JLCnPcWVL5KwJnWGzc7TeKe92gf?= X-Microsoft-Antispam-Message-Info: t1+VMeDs4VMZ7X76Iy1n4wqjIUG4zxXcwzAHROb/YHED9zLz1psKfco1lIBJDQZG2mXEv6dZR+R3zQqO3I9ph9DqLWZ7c3yAeUxamfNpmfIr2m2A9uoEudyrQb6Y0ONWU9aLKvwi2rNDLoHjG7MOkSFrAXuLehlDu7rXybjOi9mrpgiI6xdzUy3v7+udkgpC8Orwpd/tXIsEn2r6EhP9pO6UMtZkNsRuBMX+1UNEy0e6mh0JR+X700D/FSBAroUbA9CJ9h5oKHKzCy46Bq9mefFjAuJEX2EurkU44qyWAx170H84nzyjheZkFjn4gqM1EfTA2ZP4ByKqTSudA+5he9q5tL7Z5fuxZhJ8MyrnCcA= X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4995; 6:Q5AyMtIQSFEzmrosRti9H11rETmtU72enxdo+qTB3gORVjgwJqwWOMm4Lj5T/7nco9Kjb3XBe2+bkUxLQdPTVRr4KW19bkL6lM/1MfvFv5k45LbJQvfdRGj4w73d6hJrEshcxKZDU7pTfiW5ohjAKDH042IDwdOgo5oxEUEsG6Mr07HI8WsXInjOzEubbi+uKg6NTHI1+vYfwxJe8o+dSQ7oeJfnyu2u20U5J75550hpATEvbBJyWiBGs+lrzyhBD6qnlynQuf+NabtTf6WS5M+uM4Qcv3UvZ1s99EIGLujZZV8OF1XKeidZg2cC4doqu0XYOZpSWJWY6yp4AKSY2KHlWVmFEzG0adXejSjHJiYlqEVMwI1hRmzwMhQGuDto+fbZbF926EG9Qhhyv0VA8hVHM1mkgwugSHPrDkus51+QuaIcCs+V5D89oa52kikvB8P+mAU/84kzcvCJCYWMoQ==; 5:5gCCrbhCx9tsrgt/ZCJN4U3q4A9chIk5Me/8Sy0dLZ6PuXL1XrwcPquvUEy+otkR/OQ43cEBDf0DwkfYNoV5lry9aqSmXE8/soLSgb8s7ikSnDydsjqwWhl3DUPpqIjkVnAL3Eq0WVcizdPaCLX8f6Quh0/CkNPBlmIKSGTxxoA=; 7:UZZtk5dDHWGFkIbBINAr7Ej+l29zZcd/RuhtXEJ3kn7/wZnqpETOlYieZUgNB75lTbDuvrZR5V5mvFKQthANEZfPNB/EQizd7qUNl+Brvtd/Z8sOErkr8WVupdFxOPgc5x9G13MTV5nCnkRImrmwYYUieXsMsdd+RAQfKHxe3wThKPuXm8TH2KiwSLzj3XRUhA0OBkMIgzqEow7qXy7zHHjwdK8U5YPeQ3oy82WJeiZaZuv64NWGuu488M2Ny7lt SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2018 15:39:13.1855 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7e9cb0f2-1166-4590-fe3e-08d5f17b9cbd X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4995 Subject: Re: [dpdk-dev] [PATCH] net/octeontx: fix stop clearing fastpath functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 15:39:19 -0000 -----Original Message----- > Date: Tue, 24 Jul 2018 16:13:50 +0530 > From: Pavan Nikhilesh > To: jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com, > ferruh.yigit@intel.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH] net/octeontx: fix stop clearing fastpath > functions > X-Mailer: git-send-email 2.18.0 > > On dev_stop the Rx/Tx_burst functions are being set to NULL, this causes > a SEGFAULT in cases where control path calls stop and a paket is still > being processed by a worker. > Instead clear the fastpath functions in dev_close. > > Fixes: da6c687471a3 ("net/octeontx: add start and stop support") Cc: stable@dpdk.org > > Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob > --- > drivers/net/octeontx/octeontx_ethdev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c > index 1eb453b21..8fe868678 100644 > --- a/drivers/net/octeontx/octeontx_ethdev.c > +++ b/drivers/net/octeontx/octeontx_ethdev.c > @@ -352,6 +352,9 @@ octeontx_dev_close(struct rte_eth_dev *dev) > > rte_free(txq); > } > + > + dev->tx_pkt_burst = NULL; > + dev->rx_pkt_burst = NULL; > } > > static int > @@ -445,9 +448,6 @@ octeontx_dev_stop(struct rte_eth_dev *dev) > ret); > return; > } > - > - dev->tx_pkt_burst = NULL; > - dev->rx_pkt_burst = NULL; > } > > static void > -- > 2.18.0 >