From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A1828F72 for ; Wed, 25 Jul 2018 04:19:09 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2018 19:19:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,400,1526367600"; d="scan'208";a="56947502" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.228]) by fmsmga007.fm.intel.com with ESMTP; 24 Jul 2018 19:19:07 -0700 Date: Wed, 25 Jul 2018 10:18:51 +0800 From: Tiwei Bie To: Marvin Liu Cc: dev@dpdk.org Message-ID: <20180725021851.GA30497@debian> References: <20180724151649.44490-1-yong.liu@intel.com> <20180725095654.66498-1-yong.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180725095654.66498-1-yong.liu@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost: workaround qemu abort X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 02:19:10 -0000 On Wed, Jul 25, 2018 at 05:56:54PM +0800, Marvin Liu wrote: > Current qemu vhost net ring start has a dependency on feature bit > VHOST_USER_F_PROTOCOL_FEATURES. If vhost device start without it, stop > action will be skipped. Consequently, same ioevent fd will be added > twice after reloading driver and then cause qemu abort. However, ring > should be initialized in an enabled state when this feature bit not > negotiated. Work around qemu issue by enabling this feature bit in vhost > user backend. > > Signed-off-by: Marvin Liu > > diff --git a/examples/vhost/main.c b/examples/vhost/main.c > index 2175c1186..4b87331fc 100644 > --- a/examples/vhost/main.c > +++ b/examples/vhost/main.c > @@ -1519,8 +1519,12 @@ main(int argc, char *argv[]) > "vhost driver register failure.\n"); > } > > - if (builtin_net_driver) > + if (builtin_net_driver) { > rte_vhost_driver_set_features(file, VIRTIO_NET_FEATURES); > + /* Workaround for qemu vhost net device startup */ > + rte_vhost_driver_set_features(file, > + 1ULL << VHOST_USER_F_PROTOCOL_FEATURES); rte_vhost_driver_set_features() will overwrite the existing value. You need to OR VIRTIO_NET_FEATURES and (1ULL << VHOST_USER_F_PROTOCOL_FEATURES). > + } > > if (mergeable == 0) { > rte_vhost_driver_disable_features(file, > -- > 2.17.0 >