From: Marvin Liu <yong.liu@intel.com>
To: tiwei.bie@intel.com, dev@dpdk.org
Cc: Marvin Liu <yong.liu@intel.com>
Subject: [dpdk-dev] [PATCH v3] examples/vhost: workaround qemu abort
Date: Wed, 25 Jul 2018 18:25:56 +0800 [thread overview]
Message-ID: <20180725102556.68604-1-yong.liu@intel.com> (raw)
In-Reply-To: <20180724151649.44490-1-yong.liu@intel.com>
Current qemu vhost net ring start has a dependency on feature bit
VHOST_USER_F_PROTOCOL_FEATURES. Without this feature, vhost ring can't
enabled and ioevent fd won't be deleted after vhost device stop. That
will cause qemu abort when reloading driver. Work around qemu issues by
enabling feature bit in vhost user backend.
Signed-off-by: Marvin Liu <yong.liu@intel.com>
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 2175c1186..8573004dd 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -1520,7 +1520,10 @@ main(int argc, char *argv[])
}
if (builtin_net_driver)
- rte_vhost_driver_set_features(file, VIRTIO_NET_FEATURES);
+ /* Workaround for qemu vhost net device startup */
+ rte_vhost_driver_set_features(file,
+ VIRTIO_NET_FEATURES |
+ 1ULL << VHOST_USER_F_PROTOCOL_FEATURES);
if (mergeable == 0) {
rte_vhost_driver_disable_features(file,
--
2.17.0
next prev parent reply other threads:[~2018-07-25 2:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 15:16 [dpdk-dev] [PATCH] examples/vhost: fix " Marvin Liu
2018-07-25 1:23 ` Tiwei Bie
2018-07-25 9:56 ` [dpdk-dev] [PATCH v2] examples/vhost: workaround " Marvin Liu
2018-07-25 2:18 ` Tiwei Bie
2018-07-25 2:42 ` Liu, Yong
2018-07-25 10:25 ` Marvin Liu [this message]
2018-07-25 6:39 ` [dpdk-dev] [PATCH v3] " Tiwei Bie
2018-07-26 5:42 ` Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725102556.68604-1-yong.liu@intel.com \
--to=yong.liu@intel.com \
--cc=dev@dpdk.org \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).