DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: 'Cody Doucette' <doucette@bu.edu>,
	Olivier Matz <olivier.matz@6wind.com>,
	"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"michel@digirati.com.br" <michel@digirati.com.br>,
	Qiaobin Fu <qiaobinf@bu.edu>
Subject: Re: [dpdk-dev] [PATCH v2] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()
Date: Wed, 25 Jul 2018 15:22:20 +0200	[thread overview]
Message-ID: <20180725132220.ztb2hazcbtdqydem@bidouze.vm.6wind.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258DF51D4C3@irsmsx105.ger.corp.intel.com>

Hi Konstantin,

On Wed, Jul 25, 2018 at 09:11:30AM +0000, Ananyev, Konstantin wrote:
> Hi Cody,
> 
> > -----Original Message-----
> > From: Cody Doucette [mailto:doucette@bu.edu]
> > Sent: Thursday, July 19, 2018 4:58 PM
> > To: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Olivier Matz <olivier.matz@6wind.com>; Dumitrescu, Cristian
> > <cristian.dumitrescu@intel.com>
> > Cc: dev@dpdk.org; michel@digirati.com.br; Cody Doucette <doucette@bu.edu>; Qiaobin Fu <qiaobinf@bu.edu>
> > Subject: [PATCH v2] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()
> > 
> > Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any
> > other IPv6 extension headers when finding the fragment header.
> > 
> > According to RFC 8200, there is no guarantee that the IPv6
> > Fragment extension header will come before any other extension
> > header, even though it is recommended.
> > 
> > Signed-off-by: Cody Doucette <doucette@bu.edu>
> > Signed-off-by: Qiaobin Fu <qiaobinf@bu.edu>
> > Reviewed-by: Michel Machado <michel@digirati.com.br>
> > ---
> > v2:
> > * Moved IPv6 extension header definitions to lib_net.
> > 
> 
> Looks ok to me, though now drivers/net/failsafe fails to build on freebsd:
> http://mails.dpdk.org/archives/test-report/2018-July/060532.html
> 
> I fixed that locally by commenting out:
> CFLAGS += -D_XOPEN_SOURCE=700
> at drivers/net/failsafe/Makefile
> 
> Not sure what is the root cause here.
> Gaetan, do you remember why we need it for failsafe driver?
> Konstantin
> 

IIRC, I was using it during the parameters parsing.
I don't see this reason anymore.

Removing it I don't see any issue so if you need to, have at it!

-- 
Gaëtan Rivet
6WIND

  reply	other threads:[~2018-07-25 13:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25  9:11 Ananyev, Konstantin
2018-07-25 13:22 ` Gaëtan Rivet [this message]
2018-07-26  9:40   ` Ananyev, Konstantin
  -- strict thread matches above, loose matches on Subject: below --
2018-07-19 15:58 Cody Doucette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180725132220.ztb2hazcbtdqydem@bidouze.vm.6wind.com \
    --to=gaetan.rivet@6wind.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=doucette@bu.edu \
    --cc=konstantin.ananyev@intel.com \
    --cc=michel@digirati.com.br \
    --cc=olivier.matz@6wind.com \
    --cc=qiaobinf@bu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).