From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id A75FE2BAC for ; Wed, 25 Jul 2018 15:22:38 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id a3-v6so7412486wrt.2 for ; Wed, 25 Jul 2018 06:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=kh/dZeGeS29n2dtdaYCVui4mK/6sXbWsvLFDo5cfCDE=; b=DKTEPwZe+MGY5UPrNpdTsnVXJzXrKxG6Nuq+J7b2zR5FxlxKsNzLNa3zcXF+NLr5VN ifu7YXw0xuyDWGa+oj+a2/ByGgVVf5xSE9cNV2tvk35Ph0IoOc3BiWfqxqoWLZo/DCtB h1eJp90p8stis3f8F/5AJmvKM8cizedFrTJFRu1QQNytwo98dG9lsme1t59hVRDMiCH0 2GY3Eo1zeC8wlnwsV816S/+HxYI8aZO1ezzgsTCYilHTm2JstMHwajjLwqKzKRkM6G7D GuUlbW1rQnSzQn450nSWJ45a3PHQr4ZDrbfZdqplWw25J2UIC0nplSZhSzNE9N0IzX5z 3N/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=kh/dZeGeS29n2dtdaYCVui4mK/6sXbWsvLFDo5cfCDE=; b=neC0K20qU6sOtUdBpSHjw0kdgrLVhC2wCBCqpP1iGD2NT6JW3AaW9aJ5fFTaTtn9uS RW41pi2F4ZyaBJEYSPJbllXj6x3lsvTWmuIMOIvv6C8MP3J81sJOVj9Vt7bMvqAAejpT YWQh94Qp8JBMTqFSkHAC3Bry2lYfY5Ty23x6PHzuUPWVFTIWIbW1QNjTCxHISlB49Srw Zy9jS4n8MkxRWdZMe8bjwIuiU+GnpYyNKqcl68aDb3MXjOFzZlq14TImtvlBJStkJGPm +Y2lM9PI2jtGUaKYkSU7yX6KVNuOAwML5srsmiJ0apydCFcq5DWAoDbvQ3E2rhR8Ie7H V3AQ== X-Gm-Message-State: AOUpUlGicqe2mpUmxdiMGx6+jlhYKEV7kKBwqVt3MRSAA/QksS4EaGrW hhqy36bmUDzwEsnFbZMej2tA/v2strU= X-Google-Smtp-Source: AAOMgpcC6MWS8Q5cN0vAoHhNECu2OI9m+cc3fn4zeQ+3nWcKGIb7eNHtwz8AwkgQluH8Sp7XaYLd0A== X-Received: by 2002:adf:ab14:: with SMTP id q20-v6mr14126744wrc.239.1532524958328; Wed, 25 Jul 2018 06:22:38 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z11-v6sm26821023wrm.94.2018.07.25.06.22.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Jul 2018 06:22:37 -0700 (PDT) Date: Wed, 25 Jul 2018 15:22:20 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: "Ananyev, Konstantin" Cc: 'Cody Doucette' , Olivier Matz , "Dumitrescu, Cristian" , "dev@dpdk.org" , "michel@digirati.com.br" , Qiaobin Fu Message-ID: <20180725132220.ztb2hazcbtdqydem@bidouze.vm.6wind.com> References: <2601191342CEEE43887BDE71AB977258DF51D4C3@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2601191342CEEE43887BDE71AB977258DF51D4C3@irsmsx105.ger.corp.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 13:22:38 -0000 Hi Konstantin, On Wed, Jul 25, 2018 at 09:11:30AM +0000, Ananyev, Konstantin wrote: > Hi Cody, > > > -----Original Message----- > > From: Cody Doucette [mailto:doucette@bu.edu] > > Sent: Thursday, July 19, 2018 4:58 PM > > To: Ananyev, Konstantin ; Olivier Matz ; Dumitrescu, Cristian > > > > Cc: dev@dpdk.org; michel@digirati.com.br; Cody Doucette ; Qiaobin Fu > > Subject: [PATCH v2] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header() > > > > Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any > > other IPv6 extension headers when finding the fragment header. > > > > According to RFC 8200, there is no guarantee that the IPv6 > > Fragment extension header will come before any other extension > > header, even though it is recommended. > > > > Signed-off-by: Cody Doucette > > Signed-off-by: Qiaobin Fu > > Reviewed-by: Michel Machado > > --- > > v2: > > * Moved IPv6 extension header definitions to lib_net. > > > > Looks ok to me, though now drivers/net/failsafe fails to build on freebsd: > http://mails.dpdk.org/archives/test-report/2018-July/060532.html > > I fixed that locally by commenting out: > CFLAGS += -D_XOPEN_SOURCE=700 > at drivers/net/failsafe/Makefile > > Not sure what is the root cause here. > Gaetan, do you remember why we need it for failsafe driver? > Konstantin > IIRC, I was using it during the parameters parsing. I don't see this reason anymore. Removing it I don't see any issue so if you need to, have at it! -- Gaëtan Rivet 6WIND