From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690058.outbound.protection.outlook.com [40.107.69.58]) by dpdk.org (Postfix) with ESMTP id 6DF325B16 for ; Mon, 30 Jul 2018 16:40:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Pt5VJtFq28WiHzGcDRgRRO99YRDTsh8JZlwO8nyM/c=; b=O7xskid41zylnIjsL8WOssQh5R5AQyaksMC0vy+J40TG7e4pKqLSLRBuHKOGWq4A6qChnJierLVKU6zCBl19/yicvWhyqpY6AxfMEYbCz2Ag5OcctUa3/sfnA9tIMhmLnUp/dBo7GP8IPswMb6YsRoLkMr9Zo38jEeV/ZiEYUr8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (50.233.148.155) by DM6PR07MB5003.namprd07.prod.outlook.com (2603:10b6:5:25::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.19; Mon, 30 Jul 2018 14:40:41 +0000 Date: Mon, 30 Jul 2018 20:10:33 +0530 From: Jerin Jacob To: "Ananyev, Konstantin" Cc: Thomas Monjalon , "dev@dpdk.org" , "Yigit, Ferruh" , "shahafs@mellanox.com" Message-ID: <20180730144031.GA14898@jerin> References: <20180729124409.3669-1-jerin.jacob@caviumnetworks.com> <2601191342CEEE43887BDE71AB977258DF51F641@irsmsx105.ger.corp.intel.com> <20180730093555.GA22823@jerin> <1687236.JLa48GYJ5r@xps> <2601191342CEEE43887BDE71AB977258DF51F702@irsmsx105.ger.corp.intel.com> <20180730111823.GA30059@jerin> <2601191342CEEE43887BDE71AB977258DF51F775@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2601191342CEEE43887BDE71AB977258DF51F775@irsmsx105.ger.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [50.233.148.155] X-ClientProxiedBy: CO1PR15CA0068.namprd15.prod.outlook.com (2603:10b6:101:20::12) To DM6PR07MB5003.namprd07.prod.outlook.com (2603:10b6:5:25::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f0e2b530-725d-47d9-efe8-08d5f62a6e52 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:DM6PR07MB5003; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5003; 3:F89snF6g/hlylyKp2YxgEBoRG7gt7B2Pl+0rNZD84hLEy10yWe86j3Fp4H0I2qHZOh1GZiSsCR62/XYaCwqm7aAgGHrnk0OxDDE3Imp8B79f1pdyNWKlVqAhH7OsEJoK77sYRNY5O4LQm9y0Jq5PRxOx4hegTAmrZcJs4e3nJwx7kliMiQFDDTniD5Flfik4JatUpSt8NhnotBqbgmDoLb3egImrCDG4vw70e48yWW5GQ7/K83dHrAMT/KZrac3H; 25:91pUaMOeIDDn2hdmJYCdeIdlYarBwaOw1DPMf2JQH4/ND6vN9c16ShIk29HANX6/RMy6UG+ZagNbXErBHgfkr22k1pN4y5rpOznQoh1ktg4Q9jNakRyRi+atEqGTgBbVNanCXnkprcCohz4nGg1KFfYRbED0tddvmJuAb5uQKKtb6lDB43tRJMVH11HE350hmR6k2vW1xDLHHfPEdUir1qVqlIQEqVvJaCu4CJww/77C3bU3vwnKOURee4iLyNZPahPfTyosqCcScx4dtoRtvFAg5LX/cgOttwUQxbehbUCJ8rvaCD9C/LGxDDbt+jWEeNficgTJ4h9x9+LbmJnJcA==; 31:y3ccjxNCMhZ/VAnwgsHCi2JShkwFYt64NfsKteZPmuteZZFR5eA7842Kq8Nj++B9h+UMQDle95oMd1BZGgjHY5kJDEn5kxunRJcGd9TeQCSOAPKRxsc4tRnoacnrHXZ6uMyEGPnEzwb++ue/qhYAOHJxSL2z1e+gWGi5CKzo5xcSZYBP026+nzv3lnDU+gGlXviBAiQkTfNdsYuaO9cKDpMfpFFImfYwEHJHlUB2tKM= X-MS-TrafficTypeDiagnostic: DM6PR07MB5003: X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5003; 20:0KMUhSnCXbsM3Z5sw28e5gy7yZV47KVlAlgfF8gx8WrxpFnWu7fMl/1uvkUBJDC8gCgQ74zCAl1aHboSnBM3d5RKEcsv7CBhZa8aWK6ZqoqHUseQcH/YPNrfPQQM5NeOx/O6viFvS2G2QZuDvzKG/BpTsKg7hg8UBJ4hacxCrxFAqHRQt3h6nV9g67Irg7K8oxZmy+oIO/IwrmSY00eaLPngAtzYzvGbTrZSfXkOYQxidS6k1JURSjC5x2x9u1SQ1DwBh9Ai+8J9fBCzL/oTg98yrlrBfzh0ebH7aC7ayashGr6lNHMVysxWACh8F625J/V+8vbuTS4+AQRFD/LBzqbNQCWxVyu6bV6sL6gssaEgTQj2r7aFcvL6ZN1Od/eXtrGQqJ+z4LXBzpW9AaFOJy6uQsBRhtgqPwmh3JxQF5iSwLU/VniUw6CSWWH7YvusDBDRPo/uNbuY9IyxWWmc/bg5drPsxgH1CXG9AfzPdt/nW46pFcKzO5HFbL+K+SCIw51dWytSf7FooJqCxVRLVox2QZJatV8o44250Eu04JRtK+LmGWLcn4mKGqT+Pt/IZpmrgqs3Gn587q1OcR99rQU9a0EhomVeHPOdCwUjon8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699)(17755550239193); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(3002001)(93006095)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:DM6PR07MB5003; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB5003; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5003; 4:TCzLFek7e+MdnqEVAIhmK3x/WAVczOr8ZSpQjPf4oMprX6OWi6aKXkoGxXO4ZgQLVzIfU3KcPnIuOt3rYq09OY9FQZZNrhLXRQdYBo64EPUq3VJ83XqmtLfJewHOANDrVfOmTMiRo0o0rbASAhED9HH9A4NTDbxvjR5QW3ky+Rz+6MtaAPEQ/9JGuHCXOQFd+LAB4jfi+N+R/ZrD91DJPgOOjG9vs5Q3kBwAsQRiXhLeIcs91YprBYsJyi3qgaNVasP7MyrQ1TK3K7bK7iSUlJVHKJ7+Ltvm3D1wrksWuFEgo6bshxL3WRQR1amDDVfl+D0rcjMNbVlHprD+AGtC1onx7lIOGXUF22feJbZ91NY= X-Forefront-PRVS: 0749DC2CE6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(346002)(376002)(366004)(136003)(189003)(199004)(13464003)(44832011)(9686003)(486006)(956004)(6916009)(55016002)(50466002)(97736004)(6666003)(5660300001)(53936002)(6246003)(106356001)(446003)(11346002)(105586002)(229853002)(4326008)(476003)(25786009)(26005)(16586007)(186003)(47776003)(52116002)(66066001)(16526019)(23726003)(386003)(53546011)(316002)(58126008)(93886005)(68736007)(42882007)(54906003)(7736002)(76176011)(14444005)(33656002)(1076002)(33896004)(478600001)(8676002)(8936002)(33716001)(305945005)(72206003)(6116002)(81166006)(81156014)(6496006)(3846002)(2906002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB5003; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM6PR07MB5003; 23:lqHoiM7K65gsG/gUBmvVmSMHoC5h7vO9Yo7wk1f7a?= =?us-ascii?Q?mB+6cXflS5K5l8I1j0Dal5/jLxNeRg/pSSk3P48SvKJkP//7EnJ9Eu+3IBYQ?= =?us-ascii?Q?PllL9TNmENaS/lgn4Kh0IRQsI+tlLJzwqvbDWYijjKaCjCzpNkMq0t9cIEiJ?= =?us-ascii?Q?R83BVJF/8UG0fX7Jb7H1MmChY53ZzZFHRrzBysbXjdUwyRt+HSoJnNeLcN+/?= =?us-ascii?Q?QxtdjooSikkv3A2ar+vC6EEkqmyrLTwXaTnrDdFDzWOPnP/s+O6v8I768YDE?= =?us-ascii?Q?s7uZeHfzK7DpT1JCVS5SiLsCBx9pGEIFQPuOUEi6j1c1p+KeA4epW8SmxvKg?= =?us-ascii?Q?jwjHKHgrVibYmdpyRhAEoYpPwJTqBrdXcEREIVmB2UkEJxeYL1gnV+L4n01w?= =?us-ascii?Q?+77IbVcuZbqV1Sen4ZM3b6G1FRDgIfdaRj61SjtcA1PatKMFjESbyYe981/D?= =?us-ascii?Q?BjMh0C+yO4BNtXJABRbnlbF87OaEVW/L7cy9ITHMtlkPIrkpYQ/8e9xUn6Gm?= =?us-ascii?Q?UgwnN0vsIA3zMFHZaXyyNs0s957cp7F32kwHX6S+dOO2ZJ9LUz6ukXwDVUPT?= =?us-ascii?Q?GN2c3IIrJHYHnU79BLi0MyS81YoO+dggpWRDtXoyDnje8T3WV2jXP2vg6e6O?= =?us-ascii?Q?6+ViDTTnapW1x0H4HoBOe+1MlvLHU32CnjjRdZyZvicSejbLjpKj/SNiJmNC?= =?us-ascii?Q?KteOPAbHlbqtMyySi2eZDamzU8STsEW39EdFkSmiNnMmZ/oxmxLvbkK35hmh?= =?us-ascii?Q?Ou1gSPSmh7mSVkgq6Jpj/dPXrYYr1Y5s22rh5dWPGT1q8itA045uBD4uNy68?= =?us-ascii?Q?9Qrc03tpSKWyqNdUjrZt8MlUX97p0q8wjvpuVgCB5Qd7Oaln1WhOK/cLkhnF?= =?us-ascii?Q?9wNXqYV2kw/hIV+mJNl5z9f6ZSFwq3TACRc70GtwgCvgNoB4NI/1WfU6Dbj/?= =?us-ascii?Q?3yuyFZShRpSWM7g19/vlTKvAoSzKBnaUO2JWf4tUPeU5nhSVfb9nE9vbhoMh?= =?us-ascii?Q?ol1WyaZnL9KsLyv533/miB9a/iOykMngfuQvQHOXbArYfCYUpEx1iQPtAoO1?= =?us-ascii?Q?riOZl2ULCB94hh+uWSO8O5Pdtb+C//yilTPy/FerIskc8v9s2n+e/1j5zAjl?= =?us-ascii?Q?AGFhjrhC/BC0Wv6IqcpHJkV0L6LlWPl8p4fmA847KwwskLB4CRPyiVeA3raH?= =?us-ascii?Q?tAg+izW4GPgvJdmektZxAVQMjDPHuNCu+wXWHcJ6GZ6WAFkKmWamn106HbYU?= =?us-ascii?Q?syvKAXQFTAOdQNHrpmK+BI/gioNFwV9MAn1Be9n5z4MTs8/9fGJ6yWUfXXui?= =?us-ascii?Q?pZNbRxAPJb0snk/SLxw1ntZWoyV4nKctSN4UhBvwkY16LkU8Rp4+YC514vPV?= =?us-ascii?Q?MlzOTTUcK0WjHxqNEuEetYVFF6qIwuvzoLUs6C+CaaHbTAL?= X-Microsoft-Antispam-Message-Info: tdA3jR4w/lfKDuJbq49OUaFtGKUYoW5dKcypO9pidzSCJRdv+ev2m+UhpXzTM4k97VwKlNCyVOlz6WC3Z5/bjvfK8vhYzQ2pspyNdkP8uWyUKUhp+Rw9rwuixI3OO+YrFpnZCmRuPk6H8zrqTqpZB05mnxJKXpMWatfIRipLaVLyMKHvZUTroaSttw9nFFdTQ1IWJbHE1mQwNPu93faBS7VEb4+Y5evHYECSd50lUWQwYJGEVdFYnD04k0jaIGRitLsB2Xbn5GEgfeY4Hyw3+mO4SYlhsvU1wHyhQa2StBdgdyj9qeIyb17NRwPDX5FdOW8q/Q+qCHwax/5AY+rhr2HekyEGQB9PZTx7xDCYdlw= X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5003; 6:Azi5onA3rc3rPGGf1aYigmsiQVgTG4dpVI+Qn7nwiPC2+tRPNtH/rnnPww4W78J4v1hYjTUmgBKX+yBAKmpTkuKaLeSUqXRsgDhp8XSpUjfY5PYF4JBB8FRG2BEgmXfL89wdAiF5mWjxpk1u68ZkX8wctv8IvjvGI4JCa7i6LcNxf4yAThFFZU9cewb6XF5jmMXQIF8sNMqtRZ/XcptaqNrElV9JVQUNei7yNS0vKOg+gU9vUJSoFIvQaT8GxwWUwUOzO1Jp5xi1A5SSMUOoBBiDlpPcgPthy/Bk8A6umImglamkWVXIb8IpuepmpyP22nKYNhIXIeqBUwEwZqH0IrxAygEXxB3rDwfvORRclfeeztOc6rQ4eE+3/Q0DX8gRoHtBxsoswGCqi2s3w0iiQDt0oaszZKiIZWrWncWIngmE+RHxPE1T2Ee3asqzZEExGU/yUNmtq1l42OViXJpEzw==; 5:cGD1a4cgvLigFEU+Jua7BggamlZj71xSG/pYkD+Lkl2N11Y8VfMgfG1tgNL6COpAEkKd6NaEHnQt/sHCF/ruLcgnJ9s5Wu4cF5Mm/j4r7koqmUEJfEaUND2JOIQpe1W+doKppABezH/BQON9i5k9uiYJtjWieO0nAXhmrnX8EKI=; 7:CbTqmzkzZtgamXTau7BefDqH+JK/rOt0iHKi5Hf4646Vkj/kz0ePwpWYKM3Uh9lz4IUgGfYjiNxKH5izvBUJAt7sKBF0J2V35mvr8fp/glv42esiljBalIr4aTdlaC3Lsc1ptB05SyGw6BmjC5IbWuly1WC52IAJ4QHisNHCzbMyp5ZMzmJtpgnP0M3C/mzAr6a5rzng45DzOu8TrGvc7HJoisrJF4o3JTEK2/QMe0Whz5bzFeC8e9l8LGGfTZL9 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2018 14:40:41.5762 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f0e2b530-725d-47d9-efe8-08d5f62a6e52 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB5003 Subject: Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 14:40:47 -0000 -----Original Message----- > Date: Mon, 30 Jul 2018 14:12:12 +0000 > From: "Ananyev, Konstantin" > To: Jerin Jacob > CC: Thomas Monjalon , "dev@dpdk.org" , > "Yigit, Ferruh" , "shahafs@mellanox.com" > > Subject: RE: [dpdk-dev] [PATCH] examples: remove Rx checksum offload > > > > > > -----Original Message----- > > > Date: Mon, 30 Jul 2018 11:00:02 +0000 > > > From: "Ananyev, Konstantin" > > > To: Thomas Monjalon , Jerin Jacob > > > > > > CC: "dev@dpdk.org" , "Yigit, Ferruh" > > > , "shahafs@mellanox.com" > > > Subject: RE: [dpdk-dev] [PATCH] examples: remove Rx checksum offload > > > > > > External Email > > > > > > > -----Original Message----- > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > Sent: Monday, July 30, 2018 10:51 AM > > > > To: Jerin Jacob ; Ananyev, Konstantin > > > > Cc: dev@dpdk.org; Yigit, Ferruh ; shahafs@mellanox.com > > > > Subject: Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload > > > > > > > > 30/07/2018 11:35, Jerin Jacob: > > > > > From: "Ananyev, Konstantin" > > > > > > > > > > > > > > As of now, application does not check PKT_RX_*_CKSUM_* flags per > > > > > > > packet, so it does not matter DEV_RX_OFFLOAD_CHECKSUM enabled or not. > > > > > > > > > > > > > > Removing DEV_RX_OFFLOAD_CHECKSUM offload so that driver can save a few > > > > > > > cycles if possible. > > > > > > > > > > > > Personally, I'd move in other direction: keep RX checksum offload and add > > > > > > checks inside sample apps to handle (drop) packets with invalid checksum. > > > > > > > > > > OK. Till someones add the DROP logic in application, Can we take > > > > > this patch? Because there is no point in enabling DEV_RX_OFFLOAD_CHECKSUM > > > > > without DROP or any meaning full action in application. > > > > > > Probably, but at least it gives users a right estimation how long the proper > > > RX/TX routine would take. > > > > For estimation, application can add any flag they want in local setup. > > It does not need to be upstream with out feature complete. > > > > > From other side what the point to disable these flags now, if we know that > > > > At least nicvf Rx routines are crafted based DEV_RX_OFFLOAD_CHECKSUM > > flags. If driver Rx routine crafted such case it will be useful. > > > > > we are doing wrong thing and will have to re-enable them again in future? > > > > But it is not correct now either. Right? > > Yes, right now invalid cksum information is simply ignored. > As you pointed - some PMD select RX routine based on checksum offload flags. > Yes, removing these flags might produce better performance numbers. > But from my perspective - it would be an artificial and temporary improvement, > as for l3fwd like apps we'll need to revert it back and add code to drop invalid packets. IMO, It is OK get a performance hit when do that support in l3fwd. There is no harm in removing the DEV_RX_OFFLOAD_CHECKSUM flag for now and it is correct from application perspective.(you are enabling an offload when you are using it, else don't enable it. I believe, this was philosophy for enabling Rx/Tx offloads) Since it is going in circles, I leave decision to ethdev maintainers. > Konstantin > > > > > > > > > > > > > > If there is no patch sent to use this offload on August 1st, > > > > then I will apply this patch to remove the offload request. > > > > > > > > > > Isn't it too late to do such things right now? > > > We are in RC3 stage and doesn't look like a critical issue. > > > > Yes. We can add it when have we proper fix. Currently, it signaling a wrong > > interpretation to application. > > > > > > > Konstantin > > > > > >