From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id D4F072B92 for ; Tue, 31 Jul 2018 18:31:48 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id j8-v6so6365546pff.6 for ; Tue, 31 Jul 2018 09:31:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=77j8FXqhgOVsYvAej3atH1hb7BaG7xeOEXQD6dmtT54=; b=T3QhvJifIw3/W1fi5vpsVq2jlFnYJna9Bzm/gK8RWx8KBV4CGigEDDvg7MjqacKZwj 27DlD8eQp6lc1SQKiUIho/1OK1FbZTP9S2IZJ1r19XmruYCbYM//79JipZFKrdYfDFCH g613DiA7y3pxQwUTLLlm1RN4tydz3FYFooU86vrpDtho8geFl6ksW4f2vIUc+cytWj33 Z832N8i6fi940jEqVGf3T2zjsllnSe8PcLzn85JFvscITL4eqaTmSkwVLFHwuvV5xH9U wVDe2aBGDMq4kYz0BAOW4eGjyonEmhRnlODDuhodj9dfJoNalkMlGbT4xJYDgN4F0R4W fl+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=77j8FXqhgOVsYvAej3atH1hb7BaG7xeOEXQD6dmtT54=; b=T86/7uVMVkbNXsGRwjIaaF4b/AGY6zd6QWhv8FIGV9kyq1DyZ7S97NhKsl/Byzmyv0 5p21HYVR8CTvmXg5ZY9nQCkY/F5+mJioiqiu8UbtG2aTeAZOng6W9OAVHPlR4J4QtG9X NWejrH0eXAC+kG6ybYlcqEtze3WyDvR0tQ9op5uxFuhvfUz31QIMIhEcniAu1+1k3ytU Y+4A92PyovWXD3IqYFqIwLq8UXUb1tb3xOPzYgsxAoqeVtSNxuctITAFW8rUDhw+Tj+n YEnpsS3a9QeCEm4oxQCyEWOHwNulkrrfRy8ip0RPHe/IWPc2u3B6BHcL4/dUacGSl9EY aQcQ== X-Gm-Message-State: AOUpUlGCujhVQD2X9S+yfbvE3eOA38wsEqwBQKQVchZMwa5pMmxFn4kw mQe/nDQH7MfjvYSNNZlNl51kl9/eOiI= X-Google-Smtp-Source: AAOMgpebkc+MI1EaT+r4yRExmVQTmmsr7l0e5SCB0nMCiQYkIbZOmia5pBZAXwu7xzJs+0QNlmK5QA== X-Received: by 2002:a63:3c0c:: with SMTP id j12-v6mr20828316pga.440.1533054707964; Tue, 31 Jul 2018 09:31:47 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id v23-v6sm19804925pfm.80.2018.07.31.09.31.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Jul 2018 09:31:47 -0700 (PDT) Date: Tue, 31 Jul 2018 09:31:45 -0700 From: Stephen Hemminger To: "Mcnamara, John" Cc: "nhorman@tuxdriver.com" , "dev@dpdk.org" Message-ID: <20180731093145.2c257a89@xeon-e3> In-Reply-To: References: <20180731151416.4868-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] devtools: check_symbol_change requires bash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2018 16:31:49 -0000 On Tue, 31 Jul 2018 16:01:19 +0000 "Mcnamara, John" wrote: > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Tuesday, July 31, 2018 4:14 PM > > To: nhorman@tuxdriver.com > > Cc: dev@dpdk.org; Stephen Hemminger > > Subject: [dpdk-dev] [PATCH] devtools: check_symbol_change requires bash > > > > The syntax of check_symbol_change uses some bash syntax. > > It does not run correctly on Debian where /bin/sh is not the same as > > /bin/bash. > > I think this fix may be required for devtools/checkpatches.sh as well > since it seems to use bash specific call to trap(). > > I saw this in an internal bug report but didn't have a system to check > the fix on. Could you do a quick check. Yes, checkpatches also needs to be bashifyed.