* [dpdk-dev] [PATCH] net/virtio-user: fix the param string
@ 2018-07-30 8:28 Tiwei Bie
2018-07-30 8:43 ` Maxime Coquelin
0 siblings, 1 reply; 3+ messages in thread
From: Tiwei Bie @ 2018-07-30 8:28 UTC (permalink / raw)
To: maxime.coquelin, zhihong.wang, dev; +Cc: stable
Add the missing param "server" to param string.
Also add the missing spaces after params.
Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
Cc: stable@dpdk.org
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
drivers/net/virtio/virtio_user_ethdev.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
index 5ee59d5e5..525d16cab 100644
--- a/drivers/net/virtio/virtio_user_ethdev.c
+++ b/drivers/net/virtio/virtio_user_ethdev.c
@@ -681,6 +681,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user,
"cq=<int> "
"queue_size=<int> "
"queues=<int> "
- "iface=<string>"
- "mrg_rxbuf=<0|1>"
+ "iface=<string> "
+ "server=<0|1> "
+ "mrg_rxbuf=<0|1> "
"in_order=<0|1>");
--
2.18.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/virtio-user: fix the param string
2018-07-30 8:28 [dpdk-dev] [PATCH] net/virtio-user: fix the param string Tiwei Bie
@ 2018-07-30 8:43 ` Maxime Coquelin
2018-08-01 2:06 ` Tiwei Bie
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Coquelin @ 2018-07-30 8:43 UTC (permalink / raw)
To: Tiwei Bie, zhihong.wang, dev; +Cc: stable
On 07/30/2018 10:28 AM, Tiwei Bie wrote:
> Add the missing param "server" to param string.
> Also add the missing spaces after params.
>
> Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> drivers/net/virtio/virtio_user_ethdev.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
> index 5ee59d5e5..525d16cab 100644
> --- a/drivers/net/virtio/virtio_user_ethdev.c
> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> @@ -681,6 +681,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user,
> "cq=<int> "
> "queue_size=<int> "
> "queues=<int> "
> - "iface=<string>"
> - "mrg_rxbuf=<0|1>"
> + "iface=<string> "
> + "server=<0|1> "
> + "mrg_rxbuf=<0|1> "
> "in_order=<0|1>");
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/virtio-user: fix the param string
2018-07-30 8:43 ` Maxime Coquelin
@ 2018-08-01 2:06 ` Tiwei Bie
0 siblings, 0 replies; 3+ messages in thread
From: Tiwei Bie @ 2018-08-01 2:06 UTC (permalink / raw)
To: Maxime Coquelin; +Cc: zhihong.wang, dev, stable
On Mon, Jul 30, 2018 at 10:43:37AM +0200, Maxime Coquelin wrote:
> On 07/30/2018 10:28 AM, Tiwei Bie wrote:
> > Add the missing param "server" to param string.
> > Also add the missing spaces after params.
> >
> > Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> > ---
> > drivers/net/virtio/virtio_user_ethdev.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
> > index 5ee59d5e5..525d16cab 100644
> > --- a/drivers/net/virtio/virtio_user_ethdev.c
> > +++ b/drivers/net/virtio/virtio_user_ethdev.c
> > @@ -681,6 +681,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user,
> > "cq=<int> "
> > "queue_size=<int> "
> > "queues=<int> "
> > - "iface=<string>"
> > - "mrg_rxbuf=<0|1>"
> > + "iface=<string> "
> > + "server=<0|1> "
> > + "mrg_rxbuf=<0|1> "
> > "in_order=<0|1>");
> >
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Applied to dpdk-next-virtio/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-01 2:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-30 8:28 [dpdk-dev] [PATCH] net/virtio-user: fix the param string Tiwei Bie
2018-07-30 8:43 ` Maxime Coquelin
2018-08-01 2:06 ` Tiwei Bie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).