From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id C39C87CD9 for ; Wed, 1 Aug 2018 16:14:01 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id a3-v6so20273677wrt.2 for ; Wed, 01 Aug 2018 07:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AoZf3Q/LdOmpKYTHLAhxiVwUGyQx+Sj5CqpgknFalDQ=; b=D3UutcrTtJDWs1qWHH373mUgcAFqhHmhmwieirFMlRqKb28YYUycPGbEXkAiJ9ywjC XmS4odioKII6KXltzhmtG8N2cYHv3SG2zqjGfD1DQiKScDAE6yBnzM5gRtAhCjfh23En HyhaiyBglaKooNkL/XYl6fRATClY2rsQn9Q6YyDE8XyJDVp5zs2rw1atkjZnYZmYILc1 v1aiVjD2OFHL3N/fjMCNqM1FAlYh7PZPkcoSu5H7zmUZ//D9jni3+35lgmQ/YGnXF+ml 5k0Fuqic+L0VEXXsI28cjbrT0+eDRtKWzCphdakx95IJDPiz93Lxno/ys1Wz9Hnb62Li f17A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AoZf3Q/LdOmpKYTHLAhxiVwUGyQx+Sj5CqpgknFalDQ=; b=BZtVFy8rzNMNDnMR3vdbZSklxf2iRLwXTlDzjUcAIcL0S8WUjq3ejCgtTbxzGH2pFO w1WjcfCtrvtu4eE8A3UvRiZTKpCD5LBMxucvfR+8JAgE5tj9NTZcoLSAJjAa4QTq96eB HSACQvhQbjkyjpeYgfAiQNVslU220hf4AC88YB/XSIeqFR6119wYL+EbZ9v460PJHaZH IclanZvawqdFwWxKyk5lT4ktUyDX9zdTlE4r/LyAHjyIiP+mDr9wS+1rDOCFDUfxWsVL O6fB9XB1GMldeHNVsNFzc6LVkTVgFz+0OuGwz/BknzHIP2NfIqGopInaR7VQ9fhiy5Iw 8/yA== X-Gm-Message-State: AOUpUlEqR2s7GIRU6NYzar8iu3kpm7UXPaXtWsX2q+iuKf+8j8X8+7n4 CK1JCw3a04sHkmj4VlGdKITqjg== X-Google-Smtp-Source: AAOMgpfxO6YeLl2F5Lv+2qFPjVuSVwKCCXXOp5XnQpDwBwXSX21bri0vfBYP+AkDjrtOOI9ebKKEPw== X-Received: by 2002:adf:9996:: with SMTP id y22-v6mr25408213wrb.69.1533132841576; Wed, 01 Aug 2018 07:14:01 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id d14-v6sm23519525wrr.12.2018.08.01.07.14.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Aug 2018 07:14:00 -0700 (PDT) Date: Wed, 1 Aug 2018 16:13:44 +0200 From: Adrien Mazarguil To: Moti Haimovsky Cc: shahafs@mellanox.com, dev@dpdk.org, nelio.laranjeiro@6wind.com Message-ID: <20180801141344.GH5211@6wind.com> References: <1533120218-32538-1-git-send-email-motih@mellanox.com> <1533130807-9183-1-git-send-email-motih@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1533130807-9183-1-git-send-email-motih@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS flow configuration crash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 14:14:01 -0000 On Wed, Aug 01, 2018 at 04:40:07PM +0300, Moti Haimovsky wrote: > This commit fixes a segmentation fault observed when configuring > mlx5 with RSS flow rule containing invalid queues indices such as > negative numbers, queue numbers bigger than the number Rx queues the > PMD or has no queues at all. > > Fixes: 592f05b29a25 ("net/mlx5: add RSS flow action") > Cc: nelio.laranjeiro@6wind.com > > Signed-off-by: Moti Haimovsky > --- > v1: > * Added check for zero queues. NACK until my previous comment regarding RTE_FLOW_ERROR_TYPE_ACTION_CONF is taken into account. -- Adrien Mazarguil 6WIND