From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 881D51B4CE for ; Thu, 2 Aug 2018 17:14:47 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id a11-v6so1348105pgw.6 for ; Thu, 02 Aug 2018 08:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PIAIjAnn1s9hpVkqeBqG5siaEBgD2/a3oND5haoq5eM=; b=EeoyrQhwCtXOFpeDMitJIo0zjpdlNbWR0Q0aN3yYvJ0lVoXfnaDi4pGIrMxWUeZqiJ NyX/M6jjLmqmXRAaDLb8ukjvZEtrVYH22cJsfvZwRX4Ny+ulePskPOtwbdrRBCXBjZtg d0xkGeM0bZg38sQw3NgZEd8PdOnVDFw4UFckd2k99KleP6ptVktDEZuk7PMekfDXdIog rFE+6apIhD/vMVanvioSOMYhOVCknSf0Ej3DvatGTQ0WV2KxrX8DeGz7sqnb1DwTyPV8 iQuAIAYTj0ONThgKNhPBuIbZgpWPtMOEM9LxgEL5vcF6Wt+fkEY7xHAPyOffvpd/CY/d C0xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PIAIjAnn1s9hpVkqeBqG5siaEBgD2/a3oND5haoq5eM=; b=bLTTtSdvUn73Y0udhghAxq+ugrhYAWvYyRB0VgEf515rH1D2AaAgqsUgwWDPcXL9Zw GBmZEAM5sSjZ13tukSpJpkbyxvM4pYwjefLGHwIQCp5d7eUxhxNF2v4hLGfl2tNXcHgd rZixVneRN+IHwaf5572EZIkz+5u3kjtG5C9+GtXKcDyZRNfOt0951+eTvmo/CkzR1f6E kjx1GN4xch0qao0Folk7S0u9+0dX0M2Dcv4EnwATdILKT0XdZRrnB47BH6hBYNbAIzBS aK7iO6caEIwjfaRUnqaqMoDpZr/i5j+GBGH01UPLFGIfahLLo5Ibe0c/BpgQVZ8o8xhs OeUg== X-Gm-Message-State: AOUpUlEqq/jm/aDDhU4NSmBGMI5UW97NeNrLEAujAyc9pAFcyrSAjji8 3bMjLsMxIFs87FdqaFwu+63G2Q== X-Google-Smtp-Source: AAOMgpcBpY9crShQEeL8xz8PeoebGQN8kus7woGPfhnMIXn28ZA9b9qcvQZhIU0YGUu984n1Ud37Ow== X-Received: by 2002:a63:1902:: with SMTP id z2-v6mr3191145pgl.86.1533222886521; Thu, 02 Aug 2018 08:14:46 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id o27-v6sm3729471pfj.35.2018.08.02.08.14.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Aug 2018 08:14:46 -0700 (PDT) Date: Thu, 2 Aug 2018 08:14:44 -0700 From: Stephen Hemminger To: Kevin Traynor Cc: dev@dpdk.org Message-ID: <20180802081444.1211cf79@xeon-e3> In-Reply-To: <1533213223-24028-1-git-send-email-ktraynor@redhat.com> References: <1533213223-24028-1-git-send-email-ktraynor@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 15:14:47 -0000 On Thu, 2 Aug 2018 13:33:43 +0100 Kevin Traynor wrote: > Change log level of messages from ERR back to DEBUG where > existing API indicates that the condition is a success. > > This means applications using the API in its current form will > not get new ERR logs. > > Fixes: bea1e0c70cfc ("ethdev: convert static log type usage to dynamic") The expectations about level come from syslog: LOG_ERR error conditions LOG_WARNING warning conditions LOG_NOTICE normal, but significant, condition LOG_INFO informational message LOG_DEBUG debug-level message Therefore messages where an API did something wrong should be NOTICE and messages where an API's normal action was successful should be INFO or DEBUG. All the "already XXX" messages should be NOTICE.