From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 378AE25D9 for ; Fri, 10 Aug 2018 05:05:53 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2018 20:05:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,217,1531810800"; d="scan'208";a="61324328" Received: from debian.sh.intel.com ([10.67.104.167]) by fmsmga007.fm.intel.com with ESMTP; 09 Aug 2018 20:05:37 -0700 Date: Fri, 10 Aug 2018 11:03:27 +0800 From: Tiwei Bie To: Ilya Maximets Cc: dev@dpdk.org, Maxime Coquelin , Zhihong Wang Message-ID: <20180810030326.GA88853@debian.sh.intel.com> References: <1533830978-23518-1-git-send-email-i.maximets@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1533830978-23518-1-git-send-email-i.maximets@samsung.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] vhost: suppress error if numa is not available X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 03:05:53 -0000 [PATCH] vhost: suppress error if numa is not available s/numa/NUMA/ Otherwise check-git-log.sh [1] will complain: Wrong headline lowercase: vhost: suppress error if numa is not available Apart from that, Reviewed-by: Tiwei Bie [1] https://github.com/DPDK/dpdk/blob/11a1f847d281/devtools/check-git-log.sh#L109 Thanks On Thu, Aug 09, 2018 at 07:09:38PM +0300, Ilya Maximets wrote: > It's a common case that 'get_mempolicy' fails on systems > without NUMA support. No need to flag an error in log for > this situation. > > Signed-off-by: Ilya Maximets > --- > lib/librte_vhost/vhost.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c > index 3c9be10..91026b3 100644 > --- a/lib/librte_vhost/vhost.c > +++ b/lib/librte_vhost/vhost.c > @@ -8,6 +8,7 @@ > #include > #include > #ifdef RTE_LIBRTE_VHOST_NUMA > +#include > #include > #endif > > @@ -480,7 +481,7 @@ rte_vhost_get_numa_node(int vid) > int numa_node; > int ret; > > - if (dev == NULL) > + if (dev == NULL || numa_available() != 0) > return -1; > > ret = get_mempolicy(&numa_node, NULL, 0, dev, > -- > 2.7.4 >