From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 1395A98 for ; Fri, 10 Aug 2018 09:09:06 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A47D081663CF; Fri, 10 Aug 2018 07:09:05 +0000 (UTC) Received: from localhost (dhcp-192-225.str.redhat.com [10.33.192.225]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 60A5B7C49; Fri, 10 Aug 2018 07:09:03 +0000 (UTC) Date: Fri, 10 Aug 2018 09:09:02 +0200 From: Jens Freimann To: Maxime Coquelin Cc: dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com Message-ID: <20180810070902.we3jf4xfpbgu5vst@jenstp.localdomain> References: <20180808152323.9660-1-maxime.coquelin@redhat.com> <20180808152323.9660-2-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20180808152323.9660-2-maxime.coquelin@redhat.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 10 Aug 2018 07:09:05 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 10 Aug 2018 07:09:05 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jfreiman@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [RFC 1/2] vhost: add packed ring support to vring base requests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 07:09:06 -0000 On Wed, Aug 08, 2018 at 05:23:22PM +0200, Maxime Coquelin wrote: >For consistency with Vhost kernel backend, save the wrap >counter value into bit 31 of num's vring state field. > >Signed-off-by: Maxime Coquelin >--- > lib/librte_vhost/vhost_user.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > >diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c >index a2d4c9ffc..31cfdf163 100644 >--- a/lib/librte_vhost/vhost_user.c >+++ b/lib/librte_vhost/vhost_user.c >@@ -648,10 +648,15 @@ static int > vhost_user_set_vring_base(struct virtio_net *dev, > VhostUserMsg *msg) > { >- dev->virtqueue[msg->payload.state.index]->last_used_idx = >- msg->payload.state.num; >- dev->virtqueue[msg->payload.state.index]->last_avail_idx = >- msg->payload.state.num; >+ struct vhost_virtqueue *vq = dev->virtqueue[msg->payload.state.index]; >+ if (dev->features & (1ULL << VIRTIO_F_RING_PACKED)) { >+ vq->avail_wrap_counter = msg->payload.state.num >> 31; >+ vq->used_wrap_counter = vq->avail_wrap_counter; Maybe I don't understand when this is called, but the wrap counters could have different values, no? Apart from that: Reviewed-by: Jens Freimann regards, Jens