From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0040.outbound.protection.outlook.com [104.47.42.40]) by dpdk.org (Postfix) with ESMTP id 7FEB325D9 for ; Fri, 10 Aug 2018 14:08:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X0hASr07/iV2THMcsWXQaQednbVN++DYSOJbkinnvv0=; b=gDtizLYCWceIe9zzFQ7nu46P3tjLsBirKrh+eZDunRJLTr7HYfZ0cDb9l5J2FDT8XRMw+iJMTR+L0v5JGR2TD/clkc3HbL3BG1yTVJ1dggqCmYiEPq22JgpexzoeUw1JjknwkpMuX4oLsTLJl58zi+iP9OkB8pcnrd/DbqTc+wI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.201.124.136) by BL0PR07MB4996.namprd07.prod.outlook.com (2603:10b6:208:49::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.15; Fri, 10 Aug 2018 12:08:33 +0000 Date: Fri, 10 Aug 2018 17:38:17 +0530 From: Jerin Jacob To: "Xing, Beilei" Cc: "Lu, Wenzhuo" , "Wu, Jingjing" , "dev@dpdk.org" Message-ID: <20180810120816.GA16626@jerin> References: <1533534335-119817-1-git-send-email-beilei.xing@intel.com> <20180810034507.GA3295@jerin> <94479800C636CB44BD422CB454846E013220D72B@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94479800C636CB44BD422CB454846E013220D72B@SHSMSX101.ccr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [106.201.124.136] X-ClientProxiedBy: SG2PR04CA0187.apcprd04.prod.outlook.com (2603:1096:4:14::25) To BL0PR07MB4996.namprd07.prod.outlook.com (2603:10b6:208:49::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d8c2115f-f88c-4c50-56b4-08d5feb9ff90 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4996; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4996; 3:yr/Wp2a9ZNko6gZn8yXwPraTuiFPIDXZk0WBbQVCL4+8SOKp5bpOoOuFvrR6b1lxX6R3q4LnucPM1ESK1FLSgYTrjQGhg6Za6AIa/1TmNUNZjQZbHGv8kihyFYFjl3JHsd6xTgJZyYFliRsT8ykzLlMseYxXKShtPfrdflpR/37/1Wd8zNF2l2xWOfQH8b2mWlNA0PIRu6vIXM3Np8Vubfg7xg+L+1ev3DqfJHetnjVr/Yg6Ka2Lv08tXQxM7+8c; 25:WOHzPiJpfn2ILtHDPkcqNDBuIrcp/i1c6u51Uuf3fvVLLdegFVfDCsSYZ1ZaQrmiAzjmkNYYNtVMQV/Hx3D8/Gc2aWqBbdyNVJMhiTz46GW6YOzX1oL3XRkOS9bzFUDRwBMsHHjhH+h8CnJwqiKJ/TjiD6gHSAL7bOeKflpUZlv54xtYQP2Bwf2lqq6GOsuGfPu4wGY+UYf5tUWkXplj6XxgrzKZPA1/wFZsq8XI82lWVeVnYD3bQtiGnq8AN16/aDuIbUvwFgoLsSLd36yidzvrgh7yQdCkPVv3g++8EX6/4S7JGt5J5zD0fEQ4u1poEORt6P84jdABfX00HtU4eA==; 31:w5rDK2cCW5rkrXm07wzuXFBDL4LZrNkHI2BsCszZ6+WN2fvyW2sXyEbEsaWpXqB+AhPtdvjSLXFk9zqX/bDwvQgPbT/1CAr71Y8a+lftSNsVO5GcdI+I8FiJjJsubsJLMwggJOV0KnJ5V4G+2q+O2dsIGLHtl7XzSgmEuze6WQtOUXrpUzqSfdAd3+NUD8003tTSdP5+t19YDpwqGikfOs2ETyGiFHx6QoRaELWy+/4= X-MS-TrafficTypeDiagnostic: BL0PR07MB4996: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4996; 20:sry5uzQ+rHqxS3GszcBbWT+jDVDtJUkjR91RCzd2HfaAtGXo+v68C+Y38cldc2cgvAYlZWO7EvWIJwtpTGjkfLc1GDB1c0qr1Rvy8H7JwiYLzypM1GnnbOW7jL1XNQ6VOp9+YCBqfqCe617oRtuQTdGXerclvEO5Z0jed5Fix13oDSbBd8Dy7jVD858F5FKtquvB0krX3e5bLIY0wv41sXOqnKKv5qwuKDQO0Ubh3gS77msta6rpI/h6FE5sPPDWKo26r1LsgqmZXS4Vwmzjq4qir84RUiI88pF/xdb/AOYPjQXgalPyGphBVPzSYNu/hYEtzX20MvNzZuUQYLli9Mp4I3RBdlCxCBK08zYXC2FxtRp5DAEm+287AFzqWL2jmji4OsHgFECSTrqJhR5Vzj2R/E1ANz6MWJmndmwQU6o16aykprf9Lzee5hgXClutQcMJvyq76ZZL7uyAA2ZpacAWZ3UEiVuFgufBz58RYeu434GUJ95kISHtxEGHwwp3WKG83GD5UaYMWjvvtcPHY6G9naHnKlUvpO3Jb42jnOidkl78nZAjwtiyccmo34XSW3Tpj3VgwR/gKz2dacugR0tyjistd/BCb6roJ+IEmGQ=; 4:OYXhoBMt5h3BlsxXAb7rqenQsPOeC8dplMxSIfcmoDbPSp+PH07JByJsKi7wGWZiCqMcr9JjjLItf5THrbesuL/fTbynG6jtYQbTxYHm691uqnkwEj+kHSo+JKydgRPxfOhOeqIl24sALDTlKChL+u0FORK/dx+PVWzPQIgySbDKLY9A5au0i+e2Jq9Aww71VkI82yo3OniLKItzaC9Eczm7sdDlXpS0IRtf8BGFJMQ8xdAi0Zcw45xA8gLBoj2jQDYiiCq5X+RXqzyN0913UPLsWMxKHmY+HsovX5mOBGQKG1WZS2JHsH82LuEHXV/5 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(3231311)(944501410)(52105095)(3002001)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:BL0PR07MB4996; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4996; X-Forefront-PRVS: 07607ED19A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(366004)(376002)(396003)(136003)(51914003)(13464003)(199004)(189003)(26005)(16526019)(55236004)(53546011)(81156014)(2906002)(81166006)(956004)(186003)(316002)(486006)(33896004)(6916009)(76176011)(16586007)(58126008)(42882007)(52116002)(54906003)(8936002)(7736002)(6116002)(11346002)(33656002)(1076002)(6666003)(446003)(476003)(386003)(97736004)(8676002)(305945005)(3846002)(44832011)(23726003)(72206003)(50466002)(68736007)(55016002)(9686003)(6246003)(66066001)(106356001)(4326008)(105586002)(47776003)(5009440100003)(478600001)(25786009)(14444005)(33716001)(6496006)(229853002)(53936002)(5660300001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4996; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4996; 23:DT5uj4IOI7gBgoNZzD+mnfJrz96c45WfsNWKVyDoF?= =?us-ascii?Q?uHf+HudK5cwtmZpppU42tHCgZfHMHL0VYofHZJQiUUTvszrECXgNHgZj+dDU?= =?us-ascii?Q?oJz/0HfWDIDvalUQ0ekO8BCNqU5R14O+a926ysxZj2enfJGTOJoaMa/Beq7G?= =?us-ascii?Q?FNpwP+OUwMLew1lZ6/d2HVL8H3j8IyGp5PiMjIBf/10Z5cCQ4ppf3//X2Uav?= =?us-ascii?Q?XRRmw6nsWXn4C/Gm8qlv+yyu2VUMiiNT8zvHnXmeA2UZiXfQJMt/s2idJgZ6?= =?us-ascii?Q?3UO5sCxyG2ZpbNM0KLLWSEzbTZuOvb0rd+GQAVL2/BNeaRdDXCpOvd2N7gFu?= =?us-ascii?Q?S7B+4A+G+72vmNVlBHMKcQnJUMDknRZ0VwCvXlnix+vk9MIysvLTgSqVCPhp?= =?us-ascii?Q?yPtM5TxK3FNnWSn6cb4eqvUYkFh1tWk2VUKUl+N+JwU4TKq6EbDR26eIC8Cr?= =?us-ascii?Q?q26JhhOXDZVuEqSLRiQAzvIOoNZfy5Td+u5StuwxtdOg4rmTBIoSx1mKXCBW?= =?us-ascii?Q?GM5rnbKQnmER7wXlcNe7ZpMdqodNTOeLsL6K44yYCiR6FExQVG+7IsvlI5Uc?= =?us-ascii?Q?bkTzihOC2L86lx1/pwUDk2CveRRKDU4goPfDh5AajbG7uz7vcq1JQdkX4RNB?= =?us-ascii?Q?Hhs+Bv0rfi605ejVrWEAxwa9mMJBgl7zRdSzVg+08FlQdENstD31IAbhi4rp?= =?us-ascii?Q?QP52utB5bWNV/S+vjgwo/bZPCIYsU2Xk4GdAHgkwAxuJU1Dfo3VeusmQ+h1S?= =?us-ascii?Q?Vbfuc10ONlsjxeTRAkBgEeFPlWhItuyFBo8yhaEapult6tEcSOCq8h9RYUkP?= =?us-ascii?Q?VgAKcRGmkUOM2XFY5V6q0z4U5hxkRJ68Rlcvzh9eTh55HEZs/J1tjiqzkpOV?= =?us-ascii?Q?NfHwQJbi6NRl5GSZA0IRK7DB301Z/v89IP1cpzQxAl04yicztTTfiPb6mvV5?= =?us-ascii?Q?58m1qVdnBKuCfAs3b5wodmPijjyunWapeqpXtkm3wF2N250zqj/S5cAE/icE?= =?us-ascii?Q?idBZlKAZKs+b01dwQWz8B38nSPQbL4SZpiiquoPpLscSMvh2IFOmT6QAXccI?= =?us-ascii?Q?IzIvZhxGAm1LerATie84JWhyuNnXtXQztIspOjXp4DVLLW0vGWRlKVmklvkU?= =?us-ascii?Q?Lnoznuk4tNkj0DsFKoFQCoW6jJ1uQI3drVJajjVOjhgkHIQoA56oEENf5TQA?= =?us-ascii?Q?Xnddd6rdfqLA4j8SA5EHr0M6pQ6YxgCQpsdyou9489g8l9MOEH4/hsYq7ArO?= =?us-ascii?Q?AwvJbvr1kiuDQQ2NGF6kN3HNBnLCNBARafaNir8FHfIm/2KjREfj56OK3Atf?= =?us-ascii?Q?cu6jKg/HsaDtG8iNyAvr0u7GopLGoTf6dERnKyS/+5TgoF/va8IUWxMR2rL+?= =?us-ascii?Q?Y/Rqan9juhAJfsFDE/Dd/uaGlvlFtq4N8+dRmxMbijgTxQZr1smXiotYpgfu?= =?us-ascii?Q?tpZjyBXyEXmNIgjvJLRwXM0gj/NxrWjWAo6xWRtWuS5h9M4K8DW?= X-Microsoft-Antispam-Message-Info: 5jM0B+gLyMyP0+TUp2JoAah29HGn8vSC+phNiTSF5YdOpZzRsxDnRJXmhEpH+G2sJnR8nM7pyW+uAYrfSK1d8eB7ZbVntf6c1HjM8nSOqySYJa9fdBPEowU9CLNkO/nVB83OZVWxa308HYGxAiBTCe95n852tvkqO1OVdC732VhAKnMba+D8yUJmOIWEoYLyXPGYmr3jPhEOmPD4uPlMWm8DX9McnEdmo96Sr8tQPCWLFyauXDCD1ZvenTbXQc+YmndNPxGNx70Fpzox0HIRpTADPDteN/6eqDfXaHV6uXuQRjWzR0fNl5j/yFwSevjLj3Qnyxtn73kddU8f0RW3DP/Olw1dnU56Y3+3GKJJH5I= X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4996; 6:rYPDYFV49qyr7Tx08zioXr+VVn2OcGSywoWes055CT78CXa9YBUSnrreoKPqz0cQHNE6NSqfUq/7xH2e686qis8m6KOR9QtMWtBOuDAD+NQZywNOT4rplpsZ4Zl70HvJD2+0CNK8wKszQM3IARByUqWOCQg5lSKDWwIKYFt42rXaFBj+DAhmiJZgbmhloyLxiJ23nT7BSVOvt7ptGs6gNAoSyw/jRJy4Qb/A259LRioantj8380DaHIfyHByt+LSNKTcDAIhgrnzg33/RfabYd4qHpCfUnneaHpBWIC/4NYOGpDY6evDC+2BEkDjTi2exjMvpPP7jguEeDwsoehenCC3Uy2W7xmczBQBxOMw6UCcoQFxISnIGKOoySMR9SwtwwsrutGhmCV5wAnsoT39HQogjCQjHo7vn9lwI6Ye7P6PHMDyId5kwyFIidFGXB5DV0Ew5Ko2efSI+dYmBOIoyQ==; 5:l0nKH6Eb1yOCGj+VDEVwdEROo424nAklgQBjXzVdudeoqOWAaRSvdAsndfJhmHpAGxAeDaiut51iJP7Upnk61bcdll0SxjUrootlgqADX4UBpbP4wgnEWj3PoSjJwRISlKnGiH5z5ZcHHSjVV/3UNObCrBRQ47b5PSR64uTacEY=; 7:KWxh8P3jmF7I8EcfVQdyP+Uc+bPuf+TLHbpn6J7gCo9hcSFdDBV2j5Cfhbj071Bate6ordXk5lTMi/O2B8s4wARovvKY+SZ783i4zAWU31Fe1lIhTomqDU2jgDQ1cdw5Vjr91Joo4nB5rNqoK4AM/hARfyf4uB/RbWQ8QrKrxtyphO6cmGdLGDhM5StolfTx0cRcB/HRjuZnn29joUIEmgfANQUObPWK8HTpgD3ut37DSUBbEQJiEhe217v+zcl2 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2018 12:08:33.3323 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d8c2115f-f88c-4c50-56b4-08d5feb9ff90 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4996 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 12:08:38 -0000 -----Original Message----- > Date: Fri, 10 Aug 2018 07:37:21 +0000 > From: "Xing, Beilei" > To: Jerin Jacob > CC: "Lu, Wenzhuo" , "Wu, Jingjing" > , "dev@dpdk.org" > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and > FDIR > > > Hi Jacob, Hi Xing, > > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Friday, August 10, 2018 11:45 AM > > To: Xing, Beilei > > Cc: Lu, Wenzhuo ; Wu, Jingjing > > ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and > > FDIR > > > > -----Original Message----- > > > Date: Mon, 6 Aug 2018 13:45:35 +0800 > > > From: Beilei Xing > > > To: wenzhuo.lu@intel.com, jingjing.wu@intel.com > > > CC: dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and > > > FDIR > > > X-Mailer: git-send-email 2.5.5 > > > > > > > > > This patch adds bitmask support for RSS, FDIR and FDIR flexible > > > payload. > > > > > > Signed-off-by: Beilei Xing > > > --- > > > app/test-pmd/cmdline.c | 199 +++++++++++++++++++++++++--- > > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 +- > > > 2 files changed, 187 insertions(+), 20 deletions(-) > > > > > > +#ifdef RTE_LIBRTE_I40E_PMD > > > > > > How about moving all driver specific tests to driver/net//? > > I think, it wont scale if everyone starts adding their own driver specific tests > > to testpmd. > > > > How about creating > > #A generic string parser in testpmd? something like, port config (port_id) > > .... > > # and do driver_name to port_id lookup > > # and introduce "test" or "self_test" ops in ethdev # and call "test" op on the > > selected port_id > > > > Thanks for the comment, but if so, then will remove and redesign all existed commands. I think it can be discussed in another thread. The new commands can fall in generic scheme. Existing ones can moved after deprecation notice procedure etc. Otherwise hook under rte_flow API, so we don't need the private API.